[meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[Yahia Farghaly]

From: yahiafarghaly <yahiafarghaly@gmail.com>

When using 'apt-key add' on the target image, the gnupg is required
but for gnupg to be fully functional, the coreutils is required to be exist with the gnupg.
Otherwise, it may throw an error in runtime as one of components of coreutils is missing.
For 'apt-key add', i faced the error of 'comm: command not found' so as proper solution, i submit this change.

Signed-off-by: yahiafarghaly <yahiafarghaly@gmail.com>
---
 meta/recipes-support/gnupg/gnupg_2.2.0.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-support/gnupg/gnupg_2.2.0.bb b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
index 0176ddd..8aa0951 100644
--- a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
+++ b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
@@ -44,3 +44,5 @@ do_install_append() {
 PACKAGECONFIG ??= "gnutls"
 PACKAGECONFIG[gnutls] = "--enable-gnutls, --disable-gnutls, gnutls"
 PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
+
+RDEPENDS_${PN} = "coreutils"
-- 
2.7.4

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[Khem Raj]

On Fri, Sep 8, 2017 at 3:17 PM, Yahia Farghaly <yahiafarghaly@gmail.com> wrote:
> From: yahiafarghaly <yahiafarghaly@gmail.com>
>
> When using 'apt-key add' on the target image, the gnupg is required
> but for gnupg to be fully functional, the coreutils is required to be exist with the gnupg.
> Otherwise, it may throw an error in runtime as one of components of coreutils is missing.
> For 'apt-key add', i faced the error of 'comm: command not found' so as proper solution, i submit this change.
>
> Signed-off-by: yahiafarghaly <yahiafarghaly@gmail.com>
> ---
>  meta/recipes-support/gnupg/gnupg_2.2.0.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/gnupg/gnupg_2.2.0.bb b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> index 0176ddd..8aa0951 100644
> --- a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> +++ b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> @@ -44,3 +44,5 @@ do_install_append() {
>  PACKAGECONFIG ??= "gnutls"
>  PACKAGECONFIG[gnutls] = "--enable-gnutls, --disable-gnutls, gnutls"
>  PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
> +
> +RDEPENDS_${PN} = "coreutils"

can we make the packaging more granular where comm is packages into a
package of its
own e.g. coreutils-comm and then create specific rdep on coreutils-comm

> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[yahia farghaly]

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

Ok, this is a nice idea what i think is i may take only comm.c and its
depends then compiling it and try to produce package. is this idea good  ?

Mr.Chen Qi, what do you think about making a specific package for 'comm'
which is a part of coreutils ?

‌

On 9 September 2017 at 01:07, Khem Raj <raj.khem@gmail.com> wrote:

> On Fri, Sep 8, 2017 at 3:17 PM, Yahia Farghaly <yahiafarghaly@gmail.com>
> wrote:
> > From: yahiafarghaly <yahiafarghaly@gmail.com>
> >
> > When using 'apt-key add' on the target image, the gnupg is required
> > but for gnupg to be fully functional, the coreutils is required to be
> exist with the gnupg.
> > Otherwise, it may throw an error in runtime as one of components of
> coreutils is missing.
> > For 'apt-key add', i faced the error of 'comm: command not found' so as
> proper solution, i submit this change.
> >
> > Signed-off-by: yahiafarghaly <yahiafarghaly@gmail.com>
> > ---
> >  meta/recipes-support/gnupg/gnupg_2.2.0.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> > index 0176ddd..8aa0951 100644
> > --- a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> > +++ b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
> > @@ -44,3 +44,5 @@ do_install_append() {
> >  PACKAGECONFIG ??= "gnutls"
> >  PACKAGECONFIG[gnutls] = "--enable-gnutls, --disable-gnutls, gnutls"
> >  PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
> > +
> > +RDEPENDS_${PN} = "coreutils"
>
> can we make the packaging more granular where comm is packages into a
> package of its
> own e.g. coreutils-comm and then create specific rdep on coreutils-comm
>
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
Yahia Farghaly
Graduated from Faculty of Engineering - Electronics and Communications
Department at Cairo University.
Linkedin <https://linkedin.com/in/yahiafarghaly> - GitHub
<https://github.com/yahiafarghaly>

[-- Attachment #2: Type: text/html, Size: 4665 bytes --]

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[yahia farghaly]

[-- Attachment #1: Type: text/plain, Size: 2721 bytes --]

sorry if my question is naive, this is my first time working with yocto and
the first patch i submit in an open source project

‌

On 9 September 2017 at 03:51, yahia farghaly <yahiafarghaly@gmail.com>
wrote:

>
> Ok, this is a nice idea what i think is i may take only comm.c and its
> depends then compiling it and try to produce package. is this idea good  ?
>
> Mr.Chen Qi, what do you think about making a specific package for 'comm'
> which is a part of coreutils ?
>
> ‌
>
> On 9 September 2017 at 01:07, Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Fri, Sep 8, 2017 at 3:17 PM, Yahia Farghaly <yahiafarghaly@gmail.com>
>> wrote:
>> > From: yahiafarghaly <yahiafarghaly@gmail.com>
>> >
>> > When using 'apt-key add' on the target image, the gnupg is required
>> > but for gnupg to be fully functional, the coreutils is required to be
>> exist with the gnupg.
>> > Otherwise, it may throw an error in runtime as one of components of
>> coreutils is missing.
>> > For 'apt-key add', i faced the error of 'comm: command not found' so as
>> proper solution, i submit this change.
>> >
>> > Signed-off-by: yahiafarghaly <yahiafarghaly@gmail.com>
>> > ---
>> >  meta/recipes-support/gnupg/gnupg_2.2.0.bb | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
>> b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
>> > index 0176ddd..8aa0951 100644
>> > --- a/meta/recipes-support/gnupg/gnupg_2.2.0.bb
>> > +++ b/meta/recipes-support/gnupg/gnupg_2.2.0.bb
>> > @@ -44,3 +44,5 @@ do_install_append() {
>> >  PACKAGECONFIG ??= "gnutls"
>> >  PACKAGECONFIG[gnutls] = "--enable-gnutls, --disable-gnutls, gnutls"
>> >  PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
>> > +
>> > +RDEPENDS_${PN} = "coreutils"
>>
>> can we make the packaging more granular where comm is packages into a
>> package of its
>> own e.g. coreutils-comm and then create specific rdep on coreutils-comm
>>
>> > --
>> > 2.7.4
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
>
> --
> Yahia Farghaly
> Graduated from Faculty of Engineering - Electronics and Communications
> Department at Cairo University.
> Linkedin <https://linkedin.com/in/yahiafarghaly> - GitHub
> <https://github.com/yahiafarghaly>
>



-- 
Yahia Farghaly
Graduated from Faculty of Engineering - Electronics and Communications
Department at Cairo University.
Linkedin <https://linkedin.com/in/yahiafarghaly> - GitHub
<https://github.com/yahiafarghaly>

[-- Attachment #2: Type: text/html, Size: 6904 bytes --]

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[Peter Kjellerstedt]

[-- Attachment #1: Type: text/plain, Size: 3658 bytes --]

Not quite. What Khem was aiming for was to modify the packaging of coreutils so that individual binaries end up in their own packages. Currently this is not done for any of the coreutil binaries, but if you look at, e.g., util-linux, you will see this setup for quite a number of its utils.

However, a simpler solution would probably be to just enable comm in busybox…

//Peter

From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of yahia farghaly
Sent: den 9 september 2017 18:06
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe


sorry if my question is naive, this is my first time working with yocto and the first patch i submit in an open source project

‌

On 9 September 2017 at 03:51, yahia farghaly <yahiafarghaly@gmail.com<mailto:yahiafarghaly@gmail.com>> wrote:

Ok, this is a nice idea what i think is i may take only comm.c and its depends then compiling it and try to produce package. is this idea good  ?

Mr.Chen Qi, what do you think about making a specific package for 'comm' which is a part of coreutils ?

‌

On 9 September 2017 at 01:07, Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>> wrote:
On Fri, Sep 8, 2017 at 3:17 PM, Yahia Farghaly <yahiafarghaly@gmail.com<mailto:yahiafarghaly@gmail.com>> wrote:
> From: yahiafarghaly <yahiafarghaly@gmail.com<mailto:yahiafarghaly@gmail.com>>
>
> When using 'apt-key add' on the target image, the gnupg is required
> but for gnupg to be fully functional, the coreutils is required to be exist with the gnupg.
> Otherwise, it may throw an error in runtime as one of components of coreutils is missing.
> For 'apt-key add', i faced the error of 'comm: command not found' so as proper solution, i submit this change.
>
> Signed-off-by: yahiafarghaly <yahiafarghaly@gmail.com<mailto:yahiafarghaly@gmail.com>>
> ---
>  meta/recipes-support/gnupg/gnupg_2.2.0.bb<http://gnupg_2.2.0.bb> | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/gnupg/gnupg_2.2.0.bb<http://gnupg_2.2.0.bb> b/meta/recipes-support/gnupg/gnupg_2.2.0.bb<http://gnupg_2.2.0.bb>
> index 0176ddd..8aa0951 100644
> --- a/meta/recipes-support/gnupg/gnupg_2.2.0.bb<http://gnupg_2.2.0.bb>
> +++ b/meta/recipes-support/gnupg/gnupg_2.2.0.bb<http://gnupg_2.2.0.bb>
> @@ -44,3 +44,5 @@ do_install_append() {
>  PACKAGECONFIG ??= "gnutls"
>  PACKAGECONFIG[gnutls] = "--enable-gnutls, --disable-gnutls, gnutls"
>  PACKAGECONFIG[sqlite3] = "--enable-sqlite, --disable-sqlite, sqlite3"
> +
> +RDEPENDS_${PN} = "coreutils"

can we make the packaging more granular where comm is packages into a
package of its
own e.g. coreutils-comm and then create specific rdep on coreutils-comm

> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



--
Yahia Farghaly
Graduated from Faculty of Engineering - Electronics and Communications Department at Cairo University.
Linkedin<https://linkedin.com/in/yahiafarghaly> - GitHub<https://github.com/yahiafarghaly>



--
Yahia Farghaly
Graduated from Faculty of Engineering - Electronics and Communications Department at Cairo University.
Linkedin<https://linkedin.com/in/yahiafarghaly> - GitHub<https://github.com/yahiafarghaly>

[-- Attachment #2: Type: text/html, Size: 11600 bytes --]

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[Alexander Kanavin]

On 09/09/2017 01:17 AM, Yahia Farghaly wrote:
> From: yahiafarghaly <yahiafarghaly@gmail.com>
> 
> When using 'apt-key add' on the target image, the gnupg is required
> but for gnupg to be fully functional, the coreutils is required to be exist with the gnupg.
> Otherwise, it may throw an error in runtime as one of components of coreutils is missing.
> For 'apt-key add', i faced the error of 'comm: command not found' so as proper solution, i submit this change.
> 

Have you established that it's something in gnupg that needs the 'comm' 
command, and not something in apt-key? Can you point to the specific 
place in gnupg source tree where comm is used?

Thanks,
Alex

Re: [meta-oe][PATCH] gnupg: added a coreutils runtime dependancy to gnupg recipe

[yahia farghaly]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

The error was */usr/bin/apt-key: line 352: comm: command not found*
 so, i investigated around this line and it showed me that apt-key script
try to use* comm* in a function
*merge_back_changes()* i couldn't find a suitable online source for the
code, i just looked at from the resulted image. so as a conclusion, i think
it is not a problem of gnupg.

On 11 September 2017 at 14:52, Alexander Kanavin <
alexander.kanavin@linux.intel.com> wrote:

> On 09/09/2017 01:17 AM, Yahia Farghaly wrote:
>
>> From: yahiafarghaly <yahiafarghaly@gmail.com>
>>
>> When using 'apt-key add' on the target image, the gnupg is required
>> but for gnupg to be fully functional, the coreutils is required to be
>> exist with the gnupg.
>> Otherwise, it may throw an error in runtime as one of components of
>> coreutils is missing.
>> For 'apt-key add', i faced the error of 'comm: command not found' so as
>> proper solution, i submit this change.
>>
>>
> Have you established that it's something in gnupg that needs the 'comm'
> command, and not something in apt-key? Can you point to the specific place
> in gnupg source tree where comm is used?
>
> Thanks,
> Alex
>



-- 
Yahia Farghaly
Graduated from Faculty of Engineering - Electronics and Communications
Department at Cairo University.
Linkedin <https://linkedin.com/in/yahiafarghaly> - GitHub
<https://github.com/yahiafarghaly>

[-- Attachment #2: Type: text/html, Size: 3287 bytes --]