* [PATCH] cmd: nand: Extend nand info to print ecc information
@ 2022-09-22 13:39 Michael Trimarchi
2022-09-22 13:43 ` Dario Binacchi
0 siblings, 1 reply; 4+ messages in thread
From: Michael Trimarchi @ 2022-09-22 13:39 UTC (permalink / raw)
To: u-boot, Balamanikandan Gunasundar; +Cc: Dario Binacchi, linux-amarula
Extract the information about ecc strength and ecc step size
from mtd controller. This information is usefull to check if
what we think as ecc is what we really configured.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
cmd/nand.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/cmd/nand.c b/cmd/nand.c
index e730484d0b..9a9794684b 100644
--- a/cmd/nand.c
+++ b/cmd/nand.c
@@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
printf("%dx ", chip->numchips);
printf("%s, sector size %u KiB\n",
mtd->name, mtd->erasesize >> 10);
- printf(" Page size %8d b\n", mtd->writesize);
- printf(" OOB size %8d b\n", mtd->oobsize);
- printf(" Erase size %8d b\n", mtd->erasesize);
- printf(" subpagesize %8d b\n", chip->subpagesize);
- printf(" options 0x%08x\n", chip->options);
- printf(" bbt options 0x%08x\n", chip->bbt_options);
+ printf(" Page size %8d b\n", mtd->writesize);
+ printf(" OOB size %8d b\n", mtd->oobsize);
+ printf(" Erase size %8d b\n", mtd->erasesize);
+ printf(" ecc strength %8d bits\n", mtd->ecc_strength);
+ printf(" ecc step size %8d b\n", mtd->ecc_step_size);
+ printf(" subpagesize %8d b\n", chip->subpagesize);
+ printf(" options 0x%08x\n", chip->options);
+ printf(" bbt options 0x%08x\n", chip->bbt_options);
/* Set geometry info */
env_set_hex("nand_writesize", mtd->writesize);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: nand: Extend nand info to print ecc information
2022-09-22 13:39 [PATCH] cmd: nand: Extend nand info to print ecc information Michael Trimarchi
@ 2022-09-22 13:43 ` Dario Binacchi
2022-10-21 13:05 ` Michael Nazzareno Trimarchi
0 siblings, 1 reply; 4+ messages in thread
From: Dario Binacchi @ 2022-09-22 13:43 UTC (permalink / raw)
To: Michael Trimarchi; +Cc: u-boot, Balamanikandan Gunasundar, linux-amarula
Hi Michael,
On Thu, Sep 22, 2022 at 3:39 PM Michael Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Extract the information about ecc strength and ecc step size
> from mtd controller. This information is usefull to check if
> what we think as ecc is what we really configured.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> cmd/nand.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/cmd/nand.c b/cmd/nand.c
> index e730484d0b..9a9794684b 100644
> --- a/cmd/nand.c
> +++ b/cmd/nand.c
> @@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
> printf("%dx ", chip->numchips);
> printf("%s, sector size %u KiB\n",
> mtd->name, mtd->erasesize >> 10);
> - printf(" Page size %8d b\n", mtd->writesize);
> - printf(" OOB size %8d b\n", mtd->oobsize);
> - printf(" Erase size %8d b\n", mtd->erasesize);
> - printf(" subpagesize %8d b\n", chip->subpagesize);
> - printf(" options 0x%08x\n", chip->options);
> - printf(" bbt options 0x%08x\n", chip->bbt_options);
> + printf(" Page size %8d b\n", mtd->writesize);
> + printf(" OOB size %8d b\n", mtd->oobsize);
> + printf(" Erase size %8d b\n", mtd->erasesize);
> + printf(" ecc strength %8d bits\n", mtd->ecc_strength);
> + printf(" ecc step size %8d b\n", mtd->ecc_step_size);
> + printf(" subpagesize %8d b\n", chip->subpagesize);
> + printf(" options 0x%08x\n", chip->options);
> + printf(" bbt options 0x%08x\n", chip->bbt_options);
>
> /* Set geometry info */
> env_set_hex("nand_writesize", mtd->writesize);
> --
> 2.34.1
>
Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Thanks and regards,
Dario
--
Dario Binacchi
Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: nand: Extend nand info to print ecc information
2022-09-22 13:43 ` Dario Binacchi
@ 2022-10-21 13:05 ` Michael Nazzareno Trimarchi
2022-10-21 13:14 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-10-21 13:05 UTC (permalink / raw)
To: Dario Binacchi, Tom Rini; +Cc: u-boot, Balamanikandan Gunasundar, linux-amarula
HI Tom
On Thu, Sep 22, 2022 at 3:43 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> Hi Michael,
>
> On Thu, Sep 22, 2022 at 3:39 PM Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Extract the information about ecc strength and ecc step size
> > from mtd controller. This information is usefull to check if
> > what we think as ecc is what we really configured.
> >
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > ---
> > cmd/nand.c | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/cmd/nand.c b/cmd/nand.c
> > index e730484d0b..9a9794684b 100644
> > --- a/cmd/nand.c
> > +++ b/cmd/nand.c
> > @@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
> > printf("%dx ", chip->numchips);
> > printf("%s, sector size %u KiB\n",
> > mtd->name, mtd->erasesize >> 10);
> > - printf(" Page size %8d b\n", mtd->writesize);
> > - printf(" OOB size %8d b\n", mtd->oobsize);
> > - printf(" Erase size %8d b\n", mtd->erasesize);
> > - printf(" subpagesize %8d b\n", chip->subpagesize);
> > - printf(" options 0x%08x\n", chip->options);
> > - printf(" bbt options 0x%08x\n", chip->bbt_options);
> > + printf(" Page size %8d b\n", mtd->writesize);
> > + printf(" OOB size %8d b\n", mtd->oobsize);
> > + printf(" Erase size %8d b\n", mtd->erasesize);
> > + printf(" ecc strength %8d bits\n", mtd->ecc_strength);
> > + printf(" ecc step size %8d b\n", mtd->ecc_step_size);
> > + printf(" subpagesize %8d b\n", chip->subpagesize);
> > + printf(" options 0x%08x\n", chip->options);
> > + printf(" bbt options 0x%08x\n", chip->bbt_options);
> >
> > /* Set geometry info */
> > env_set_hex("nand_writesize", mtd->writesize);
> > --
> > 2.34.1
> >
>
> Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
Can I pick it up?
Michael
> Thanks and regards,
> Dario
> --
>
> Dario Binacchi
>
> Embedded Linux Developer
>
> dario.binacchi@amarulasolutions.com
>
> __________________________________
>
>
> Amarula Solutions SRL
>
> Via Le Canevare 30, 31100 Treviso, Veneto, IT
>
> T. +39 042 243 5310
> info@amarulasolutions.com
>
> www.amarulasolutions.com
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: nand: Extend nand info to print ecc information
2022-10-21 13:05 ` Michael Nazzareno Trimarchi
@ 2022-10-21 13:14 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2022-10-21 13:14 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Dario Binacchi, u-boot, Balamanikandan Gunasundar, linux-amarula
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
On Fri, Oct 21, 2022 at 03:05:48PM +0200, Michael Nazzareno Trimarchi wrote:
> HI Tom
>
> On Thu, Sep 22, 2022 at 3:43 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
> >
> > Hi Michael,
> >
> > On Thu, Sep 22, 2022 at 3:39 PM Michael Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > Extract the information about ecc strength and ecc step size
> > > from mtd controller. This information is usefull to check if
> > > what we think as ecc is what we really configured.
> > >
> > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > ---
> > > cmd/nand.c | 14 ++++++++------
> > > 1 file changed, 8 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/cmd/nand.c b/cmd/nand.c
> > > index e730484d0b..9a9794684b 100644
> > > --- a/cmd/nand.c
> > > +++ b/cmd/nand.c
> > > @@ -417,12 +417,14 @@ static void nand_print_and_set_info(int idx)
> > > printf("%dx ", chip->numchips);
> > > printf("%s, sector size %u KiB\n",
> > > mtd->name, mtd->erasesize >> 10);
> > > - printf(" Page size %8d b\n", mtd->writesize);
> > > - printf(" OOB size %8d b\n", mtd->oobsize);
> > > - printf(" Erase size %8d b\n", mtd->erasesize);
> > > - printf(" subpagesize %8d b\n", chip->subpagesize);
> > > - printf(" options 0x%08x\n", chip->options);
> > > - printf(" bbt options 0x%08x\n", chip->bbt_options);
> > > + printf(" Page size %8d b\n", mtd->writesize);
> > > + printf(" OOB size %8d b\n", mtd->oobsize);
> > > + printf(" Erase size %8d b\n", mtd->erasesize);
> > > + printf(" ecc strength %8d bits\n", mtd->ecc_strength);
> > > + printf(" ecc step size %8d b\n", mtd->ecc_step_size);
> > > + printf(" subpagesize %8d b\n", chip->subpagesize);
> > > + printf(" options 0x%08x\n", chip->options);
> > > + printf(" bbt options 0x%08x\n", chip->bbt_options);
> > >
> > > /* Set geometry info */
> > > env_set_hex("nand_writesize", mtd->writesize);
> > > --
> > > 2.34.1
> > >
> >
> > Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
>
> Can I pick it up?
Yes.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-21 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 13:39 [PATCH] cmd: nand: Extend nand info to print ecc information Michael Trimarchi
2022-09-22 13:43 ` Dario Binacchi
2022-10-21 13:05 ` Michael Nazzareno Trimarchi
2022-10-21 13:14 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.