* [PATCH] powerpc/85xx: Fix typo in code comment
@ 2023-11-24 10:02 ` Dario Binacchi
0 siblings, 0 replies; 7+ messages in thread
From: Dario Binacchi @ 2023-11-24 10:02 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Christophe Leroy, Kumar Gala, Michael Ellerman,
Nicholas Piggin, Pali Rohár, Rob Herring, Scott Wood,
Timur Tabi, Zhicheng Fan, linuxppc-dev
s/singals/signals/
Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
index ec9f60fbebc7..e0cec670d8db 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
@@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
/* P1025 has pins muxed for QE and other functions. To
* enable QE UEC mode, we need to set bit QE0 for UCC1
* in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
- * and QE12 for QE MII management singals in PMUXCR
+ * and QE12 for QE MII management signals in PMUXCR
* register.
*/
setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] powerpc/85xx: Fix typo in code comment
@ 2023-11-24 10:02 ` Dario Binacchi
0 siblings, 0 replies; 7+ messages in thread
From: Dario Binacchi @ 2023-11-24 10:02 UTC (permalink / raw)
To: linux-kernel
Cc: Rob Herring, Zhicheng Fan, linuxppc-dev, Kumar Gala,
Nicholas Piggin, Scott Wood, Dario Binacchi, Pali Rohár,
Timur Tabi
s/singals/signals/
Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
index ec9f60fbebc7..e0cec670d8db 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
@@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
/* P1025 has pins muxed for QE and other functions. To
* enable QE UEC mode, we need to set bit QE0 for UCC1
* in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
- * and QE12 for QE MII management singals in PMUXCR
+ * and QE12 for QE MII management signals in PMUXCR
* register.
*/
setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix typo in code comment
2023-11-24 10:02 ` Dario Binacchi
@ 2023-11-24 13:08 ` Christophe Leroy
-1 siblings, 0 replies; 7+ messages in thread
From: Christophe Leroy @ 2023-11-24 13:08 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Kumar Gala, Michael Ellerman, Nicholas Piggin, Pali Rohár,
Rob Herring, Scott Wood, Timur Tabi, Zhicheng Fan, linuxppc-dev,
Greg Kroah-Hartman
Le 24/11/2023 à 11:02, Dario Binacchi a écrit :
> s/singals/signals/
Is that really worth it to spend time on such a change ?
By sending such a patch, you require people to spend time reviewing your
patch, then maintainer has to spend time handling your patch.
Furthermore, as you added a Fixes: tag, LTS maintainers will have to
spend time handling that too.
Do you really think that this typo is worth a patch ?
This kind of tiny error should be fixed through a more significant patch
adressing this file. But it is not worth a patch on its own.
Christophe
>
> Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> index ec9f60fbebc7..e0cec670d8db 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> @@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
> /* P1025 has pins muxed for QE and other functions. To
> * enable QE UEC mode, we need to set bit QE0 for UCC1
> * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
> - * and QE12 for QE MII management singals in PMUXCR
> + * and QE12 for QE MII management signals in PMUXCR
> * register.
> */
> setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix typo in code comment
@ 2023-11-24 13:08 ` Christophe Leroy
0 siblings, 0 replies; 7+ messages in thread
From: Christophe Leroy @ 2023-11-24 13:08 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Rob Herring, Zhicheng Fan, linuxppc-dev, Kumar Gala,
Nicholas Piggin, Scott Wood, Greg Kroah-Hartman, Pali Rohár,
Timur Tabi
Le 24/11/2023 à 11:02, Dario Binacchi a écrit :
> s/singals/signals/
Is that really worth it to spend time on such a change ?
By sending such a patch, you require people to spend time reviewing your
patch, then maintainer has to spend time handling your patch.
Furthermore, as you added a Fixes: tag, LTS maintainers will have to
spend time handling that too.
Do you really think that this typo is worth a patch ?
This kind of tiny error should be fixed through a more significant patch
adressing this file. But it is not worth a patch on its own.
Christophe
>
> Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> index ec9f60fbebc7..e0cec670d8db 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> @@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
> /* P1025 has pins muxed for QE and other functions. To
> * enable QE UEC mode, we need to set bit QE0 for UCC1
> * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
> - * and QE12 for QE MII management singals in PMUXCR
> + * and QE12 for QE MII management signals in PMUXCR
> * register.
> */
> setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix typo in code comment
2023-11-24 13:08 ` Christophe Leroy
@ 2023-11-24 13:14 ` Dario Binacchi
-1 siblings, 0 replies; 7+ messages in thread
From: Dario Binacchi @ 2023-11-24 13:14 UTC (permalink / raw)
To: Christophe Leroy
Cc: linux-kernel, Kumar Gala, Michael Ellerman, Nicholas Piggin,
Pali Rohár, Rob Herring, Scott Wood, Timur Tabi,
Zhicheng Fan, linuxppc-dev, Greg Kroah-Hartman
On Fri, Nov 24, 2023 at 2:08 PM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 24/11/2023 à 11:02, Dario Binacchi a écrit :
> > s/singals/signals/
>
> Is that really worth it to spend time on such a change ?
>
> By sending such a patch, you require people to spend time reviewing your
> patch, then maintainer has to spend time handling your patch.
> Furthermore, as you added a Fixes: tag, LTS maintainers will have to
> spend time handling that too.
>
> Do you really think that this typo is worth a patch ?
>
> This kind of tiny error should be fixed through a more significant patch
> adressing this file. But it is not worth a patch on its own.
It's not the first time I've submitted patches of this kind, and no one has
ever complained before. However, if it has become an issue, I won't do
it anymore.
Thanks and regards,
Dario
>
> Christophe
>
>
> >
> > Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >
> > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > index ec9f60fbebc7..e0cec670d8db 100644
> > --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > @@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
> > /* P1025 has pins muxed for QE and other functions. To
> > * enable QE UEC mode, we need to set bit QE0 for UCC1
> > * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
> > - * and QE12 for QE MII management singals in PMUXCR
> > + * and QE12 for QE MII management signals in PMUXCR
> > * register.
> > */
> > setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix typo in code comment
@ 2023-11-24 13:14 ` Dario Binacchi
0 siblings, 0 replies; 7+ messages in thread
From: Dario Binacchi @ 2023-11-24 13:14 UTC (permalink / raw)
To: Christophe Leroy
Cc: Rob Herring, Zhicheng Fan, linuxppc-dev, linux-kernel,
Nicholas Piggin, Kumar Gala, Scott Wood, Greg Kroah-Hartman,
Pali Rohár, Timur Tabi
On Fri, Nov 24, 2023 at 2:08 PM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
>
>
> Le 24/11/2023 à 11:02, Dario Binacchi a écrit :
> > s/singals/signals/
>
> Is that really worth it to spend time on such a change ?
>
> By sending such a patch, you require people to spend time reviewing your
> patch, then maintainer has to spend time handling your patch.
> Furthermore, as you added a Fixes: tag, LTS maintainers will have to
> spend time handling that too.
>
> Do you really think that this typo is worth a patch ?
>
> This kind of tiny error should be fixed through a more significant patch
> adressing this file. But it is not worth a patch on its own.
It's not the first time I've submitted patches of this kind, and no one has
ever complained before. However, if it has become an issue, I won't do
it anymore.
Thanks and regards,
Dario
>
> Christophe
>
>
> >
> > Fixes: 04e358d896a7 ("powerpc/85xx: Add Quicc Engine support for p1025rdb")
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >
> > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > index ec9f60fbebc7..e0cec670d8db 100644
> > --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> > @@ -76,7 +76,7 @@ static void __init mpc85xx_rdb_setup_arch(void)
> > /* P1025 has pins muxed for QE and other functions. To
> > * enable QE UEC mode, we need to set bit QE0 for UCC1
> > * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
> > - * and QE12 for QE MII management singals in PMUXCR
> > + * and QE12 for QE MII management signals in PMUXCR
> > * register.
> > */
> > setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE(0) |
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix typo in code comment
2023-11-24 10:02 ` Dario Binacchi
(?)
(?)
@ 2023-12-07 12:38 ` Michael Ellerman
-1 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2023-12-07 12:38 UTC (permalink / raw)
To: linux-kernel, Dario Binacchi
Cc: Rob Herring, Zhicheng Fan, linuxppc-dev, Kumar Gala,
Nicholas Piggin, Scott Wood, Pali Rohár, Timur Tabi
On Fri, 24 Nov 2023 11:02:37 +0100, Dario Binacchi wrote:
> s/singals/signals/
>
>
Applied to powerpc/next.
[1/1] powerpc/85xx: Fix typo in code comment
https://git.kernel.org/powerpc/c/a9e1e4d6e8c77c732e8084b03bae0c78cafdceb0
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-07 12:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 10:02 [PATCH] powerpc/85xx: Fix typo in code comment Dario Binacchi
2023-11-24 10:02 ` Dario Binacchi
2023-11-24 13:08 ` Christophe Leroy
2023-11-24 13:08 ` Christophe Leroy
2023-11-24 13:14 ` Dario Binacchi
2023-11-24 13:14 ` Dario Binacchi
2023-12-07 12:38 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.