All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl: REPEATED_WORD: massive false positive in MAINTAINERS
Date: Thu, 8 Oct 2020 19:05:24 +0530	[thread overview]
Message-ID: <CABJPP5DLhdOfuOX=Ls0-726-ECL3+o4pkVtcRY0gqk2EvLsByg@mail.gmail.com> (raw)
In-Reply-To: <b6cd81b936671a8868fe98536d7c80771bdfd61c.camel@perches.com>

On Thu, Oct 8, 2020 at 6:18 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2020-10-08 at 13:50 +0200, Lukas Bulwahn wrote:
> > Dear Joe, dear Dwaipayan,
> >
> > while maintaining MAINTAINERS, I noticed that the REPEATED_WORD check,
> > which in general is a great addition to checkpatch.pl, generates a massive
> > number of warnings due to one specific pattern in the MAINTAINERS file:
>
> I didn't actually check if there were many
> new false positives, but
> clearly that's one.
>
> Maybe exclude the MAINTAINERS file?
>
> -               if ($rawline =~ /^\+/ || $in_commit_log) {
> +               if (($rawline =~ /^\+/ || $in_commit_log) && $realfile ne "MAINTAINERS") {
>
> Maybe add git to the check for "long long"?
>
> -                               next if ($first eq 'long');
> +                               next if ($first =~ /^(?:long|git)$/);
>
>
>

Hi,
It does resolve all the warnings concerned.
But could we also exclude documentation type blocks like:
/**
* @size size of access
*/
There were quite a few of these in include/linux/instrumented.

And also it isn't case sensitive. So the line
"the the word is repeated" generates a warning, but
"The the word is repeated" doesn't generate anything.

Thanks,
Dwaipayan.

WARNING: multiple messages have this Message-ID (diff)
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] checkpatch.pl: REPEATED_WORD: massive false positive in MAINTAINERS
Date: Thu, 8 Oct 2020 19:05:24 +0530	[thread overview]
Message-ID: <CABJPP5DLhdOfuOX=Ls0-726-ECL3+o4pkVtcRY0gqk2EvLsByg@mail.gmail.com> (raw)
In-Reply-To: <b6cd81b936671a8868fe98536d7c80771bdfd61c.camel@perches.com>

On Thu, Oct 8, 2020 at 6:18 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2020-10-08 at 13:50 +0200, Lukas Bulwahn wrote:
> > Dear Joe, dear Dwaipayan,
> >
> > while maintaining MAINTAINERS, I noticed that the REPEATED_WORD check,
> > which in general is a great addition to checkpatch.pl, generates a massive
> > number of warnings due to one specific pattern in the MAINTAINERS file:
>
> I didn't actually check if there were many
> new false positives, but
> clearly that's one.
>
> Maybe exclude the MAINTAINERS file?
>
> -               if ($rawline =~ /^\+/ || $in_commit_log) {
> +               if (($rawline =~ /^\+/ || $in_commit_log) && $realfile ne "MAINTAINERS") {
>
> Maybe add git to the check for "long long"?
>
> -                               next if ($first eq 'long');
> +                               next if ($first =~ /^(?:long|git)$/);
>
>
>

Hi,
It does resolve all the warnings concerned.
But could we also exclude documentation type blocks like:
/**
* @size size of access
*/
There were quite a few of these in include/linux/instrumented.

And also it isn't case sensitive. So the line
"the the word is repeated" generates a warning, but
"The the word is repeated" doesn't generate anything.

Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-10-08 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 11:50 checkpatch.pl: REPEATED_WORD: massive false positive in MAINTAINERS Lukas Bulwahn
2020-10-08 11:50 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-10-08 12:48 ` Joe Perches
2020-10-08 12:48   ` [Linux-kernel-mentees] " Joe Perches
2020-10-08 13:35   ` Dwaipayan Ray [this message]
2020-10-08 13:35     ` Dwaipayan Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABJPP5DLhdOfuOX=Ls0-726-ECL3+o4pkVtcRY0gqk2EvLsByg@mail.gmail.com' \
    --to=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.