All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Checkpatch still worries about include/asm/ ?
Date: Thu, 18 Mar 2021 22:48:36 +0530	[thread overview]
Message-ID: <CABJPP5DbeBmVT5CTZxtwS2fpJtnasueaPkzUMrwzZZ51cdDRHQ@mail.gmail.com> (raw)
In-Reply-To: <CAKXUXMx-4p361gFewN61NEbrwTjVY9wZFg2i13VMZTUxiDJB=Q@mail.gmail.com>

On Thu, Mar 18, 2021 at 10:33 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> >
> > Hello,
> > include/asm/ got removed a long time back (probably v1.1.45).
> > Checkpatch still worries about that:
> >
> > if ($realfile =~ m@^include/asm/@) {
> > ERROR("MODIFIED_INCLUDE_ASM",
> > "do not modify files in include/asm, change architecture specific
> > files in include/asm-<architecture>\n" . "$here$rawline\n");
> > }
> >
> > Can we remove this check?
> >
>
> Wow, v1.1.45... that must have been taking quite some digging in the
> ancient dirt to find that out.
>
I was actually helped by an user who send a patch in 2016 to remove it:
https://lore.kernel.org/lkml/1482260987-21457-1-git-send-email-pebolle@tiscali.nl/raw

Don't know why it wasnt removed back then.
But it's safe to say this check hasn't been used for decades :)

> I agree, let us remove that rule.

Sure will send the patch.

> Thanks for the documentation effort on checkpatch.pl and cleaning up
> obsolete rules while documenting.
>
It's my pleasure!

Thanks & Regards,
Dwaipayan.

WARNING: multiple messages have this Message-ID (diff)
From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Checkpatch still worries about include/asm/ ?
Date: Thu, 18 Mar 2021 22:48:36 +0530	[thread overview]
Message-ID: <CABJPP5DbeBmVT5CTZxtwS2fpJtnasueaPkzUMrwzZZ51cdDRHQ@mail.gmail.com> (raw)
In-Reply-To: <CAKXUXMx-4p361gFewN61NEbrwTjVY9wZFg2i13VMZTUxiDJB=Q@mail.gmail.com>

On Thu, Mar 18, 2021 at 10:33 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> >
> > Hello,
> > include/asm/ got removed a long time back (probably v1.1.45).
> > Checkpatch still worries about that:
> >
> > if ($realfile =~ m@^include/asm/@) {
> > ERROR("MODIFIED_INCLUDE_ASM",
> > "do not modify files in include/asm, change architecture specific
> > files in include/asm-<architecture>\n" . "$here$rawline\n");
> > }
> >
> > Can we remove this check?
> >
>
> Wow, v1.1.45... that must have been taking quite some digging in the
> ancient dirt to find that out.
>
I was actually helped by an user who send a patch in 2016 to remove it:
https://lore.kernel.org/lkml/1482260987-21457-1-git-send-email-pebolle@tiscali.nl/raw

Don't know why it wasnt removed back then.
But it's safe to say this check hasn't been used for decades :)

> I agree, let us remove that rule.

Sure will send the patch.

> Thanks for the documentation effort on checkpatch.pl and cleaning up
> obsolete rules while documenting.
>
It's my pleasure!

Thanks & Regards,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2021-03-18 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 16:47 Checkpatch still worries about include/asm/ ? Dwaipayan Ray
2021-03-18 16:47 ` Dwaipayan Ray
2021-03-18 17:03 ` Lukas Bulwahn
2021-03-18 17:03   ` Lukas Bulwahn
2021-03-18 17:18   ` Dwaipayan Ray [this message]
2021-03-18 17:18     ` Dwaipayan Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABJPP5DbeBmVT5CTZxtwS2fpJtnasueaPkzUMrwzZZ51cdDRHQ@mail.gmail.com \
    --to=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.