* [U-Boot] Should be Acked-by and Reviewed-by inherited for updated patches?
@ 2013-10-28 8:33 Masahiro Yamada
2013-10-30 0:19 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2013-10-28 8:33 UTC (permalink / raw)
To: u-boot
Hello exports.
When re-posting updated a patch (or patch series),
should be Acked-by and Reviewed-by tag inherited?
Let me give an example.
I posted
"First step towards Kbuild: Use Kbuild style makefiles" v3.
Simon reviewed it and issued Acked-by tag.
> The series:
>
> Acked-by: Simon Glass <sjg@chromium.org>
But, unfortunately the series cannot be applied on the
current u-boot/master any more.
I will need to rebase the series on the u-boot/master
and re-post them as v4.
In this case, should I include
Acked-by: Simon Glass <sjg@chromium.org>
in the log of v4 series?
I think Acked-by tag for v3 cannot garantee
the validity of v4.
So, strictly speaking, I think I should drop
Acked-by tag if any change exists between v3 and v4.
Or should I use a common sense?
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] Should be Acked-by and Reviewed-by inherited for updated patches?
2013-10-28 8:33 [U-Boot] Should be Acked-by and Reviewed-by inherited for updated patches? Masahiro Yamada
@ 2013-10-30 0:19 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-10-30 0:19 UTC (permalink / raw)
To: u-boot
Hi,
2013/10/28 Masahiro Yamada <yamada.m@jp.panasonic.com>:
> Hello exports.
>
>
> When re-posting updated a patch (or patch series),
> should be Acked-by and Reviewed-by tag inherited?
>
>
> Let me give an example.
>
>
> I posted
> "First step towards Kbuild: Use Kbuild style makefiles" v3.
>
>
> Simon reviewed it and issued Acked-by tag.
>
>> The series:
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
>
>
>
> But, unfortunately the series cannot be applied on the
> current u-boot/master any more.
> I will need to rebase the series on the u-boot/master
> and re-post them as v4.
>
>
> In this case, should I include
> Acked-by: Simon Glass <sjg@chromium.org>
> in the log of v4 series?
>
Yes, If you need to rebase the patch, and re-send, you can add
Acked-by: to your patches.
>
> I think Acked-by tag for v3 cannot garantee
> the validity of v4.
> So, strictly speaking, I think I should drop
> Acked-by tag if any change exists between v3 and v4.
>
> Or should I use a common sense?
>
>
>
> Best Regards
> Masahiro Yamada
>
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-30 0:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-28 8:33 [U-Boot] Should be Acked-by and Reviewed-by inherited for updated patches? Masahiro Yamada
2013-10-30 0:19 ` Nobuhiro Iwamatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.