All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT
@ 2012-04-18  2:41 Nobuhiro Iwamatsu
  2012-04-18  7:36 ` Stefano Babic
  2012-04-19  6:44 ` Albert ARIBAUD
  0 siblings, 2 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-04-18  2:41 UTC (permalink / raw)
  To: u-boot

With almost all the architecture and board BOARD_LATE_INIT does not use.
CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
CC: Stefano Babic <sbabic@denx.de>
---
 board/davinci/ea20/ea20.c |    4 ++--
 include/configs/ea20.h    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/davinci/ea20/ea20.c b/board/davinci/ea20/ea20.c
index 43632c2..7e00040 100644
--- a/board/davinci/ea20/ea20.c
+++ b/board/davinci/ea20/ea20.c
@@ -272,7 +272,7 @@ int board_init(void)
 	return 0;
 }
 
-#ifdef BOARD_LATE_INIT
+#ifdef CONFIG_BOARD_LATE_INIT
 
 int board_late_init(void)
 {
@@ -287,7 +287,7 @@ int board_late_init(void)
 
 	return 0;
 }
-#endif /* BOARD_LATE_INIT */
+#endif /* CONFIG_BOARD_LATE_INIT */
 
 #ifdef CONFIG_DRIVER_TI_EMAC
 
diff --git a/include/configs/ea20.h b/include/configs/ea20.h
index e059b30..2c44ddb 100644
--- a/include/configs/ea20.h
+++ b/include/configs/ea20.h
@@ -31,7 +31,7 @@
 #define	CONFIG_SYS_USE_NAND
 #define CONFIG_DRIVER_TI_EMAC_USE_RMII
 #define CONFIG_BOARD_EARLY_INIT_F
-#define BOARD_LATE_INIT
+#define CONFIG_BOARD_LATE_INIT
 #define CONFIG_VIDEO
 #define CONFIG_PREBOOT
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT
  2012-04-18  2:41 [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT Nobuhiro Iwamatsu
@ 2012-04-18  7:36 ` Stefano Babic
  2012-04-19  6:44 ` Albert ARIBAUD
  1 sibling, 0 replies; 5+ messages in thread
From: Stefano Babic @ 2012-04-18  7:36 UTC (permalink / raw)
  To: u-boot

On 18/04/2012 04:41, Nobuhiro Iwamatsu wrote:
> With almost all the architecture and board BOARD_LATE_INIT does not use.
> CONFIG_BOARD_LATE_INIT is used instead.
> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>  board/davinci/ea20/ea20.c |    4 ++--
>  include/configs/ea20.h    |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/davinci/ea20/ea20.c b/board/davinci/ea20/ea20.c
> index 43632c2..7e00040 100644
> --- a/board/davinci/ea20/ea20.c
> +++ b/board/davinci/ea20/ea20.c
> @@ -272,7 +272,7 @@ int board_init(void)
>  	return 0;
>  }
>  
> -#ifdef BOARD_LATE_INIT
> +#ifdef CONFIG_BOARD_LATE_INIT
>  
>  int board_late_init(void)
>  {
> @@ -287,7 +287,7 @@ int board_late_init(void)
>  
>  	return 0;
>  }
> -#endif /* BOARD_LATE_INIT */
> +#endif /* CONFIG_BOARD_LATE_INIT */
>  
>  #ifdef CONFIG_DRIVER_TI_EMAC
>  
> diff --git a/include/configs/ea20.h b/include/configs/ea20.h
> index e059b30..2c44ddb 100644
> --- a/include/configs/ea20.h
> +++ b/include/configs/ea20.h
> @@ -31,7 +31,7 @@
>  #define	CONFIG_SYS_USE_NAND
>  #define CONFIG_DRIVER_TI_EMAC_USE_RMII
>  #define CONFIG_BOARD_EARLY_INIT_F
> -#define BOARD_LATE_INIT
> +#define CONFIG_BOARD_LATE_INIT
>  #define CONFIG_VIDEO
>  #define CONFIG_PREBOOT
>  

Acked-by: Stefano Babic <sbabic@denx.de>

Thanks,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT
  2012-04-18  2:41 [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT Nobuhiro Iwamatsu
  2012-04-18  7:36 ` Stefano Babic
@ 2012-04-19  6:44 ` Albert ARIBAUD
  2012-04-19  6:48   ` Albert ARIBAUD
  1 sibling, 1 reply; 5+ messages in thread
From: Albert ARIBAUD @ 2012-04-19  6:44 UTC (permalink / raw)
  To: u-boot

Hi Nobuhiro Iwamatsu,

Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :
> With almost all the architecture and board BOARD_LATE_INIT does not use.
> CONFIG_BOARD_LATE_INIT is used instead.
> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

I think the commit message above is redundant with the commit summary, 
especially for a trivial one-line change. Can you just post a V2 patch 
with the same code change and commit summary, but without the commit 
message?

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT
  2012-04-19  6:44 ` Albert ARIBAUD
@ 2012-04-19  6:48   ` Albert ARIBAUD
  2012-05-07  1:38     ` Nobuhiro Iwamatsu
  0 siblings, 1 reply; 5+ messages in thread
From: Albert ARIBAUD @ 2012-04-19  6:48 UTC (permalink / raw)
  To: u-boot

Le 19/04/2012 08:44, Albert ARIBAUD a ?crit :
> Hi Nobuhiro Iwamatsu,
>
> Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :
>> With almost all the architecture and board BOARD_LATE_INIT does not use.
>> CONFIG_BOARD_LATE_INIT is used instead.
>> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
>
> I think the commit message above is redundant with the commit summary,
> especially for a trivial one-line change. Can you just post a V2 patch
> with the same code change and commit summary, but without the commit
> message?

... actually, you could apply this to all your elementary patches re 
BOARD_LATE_INIT, and then submit them in a single patch set.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT
  2012-04-19  6:48   ` Albert ARIBAUD
@ 2012-05-07  1:38     ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-05-07  1:38 UTC (permalink / raw)
  To: u-boot

Hi,

Sorry, reply is late.

2012/4/19 Albert ARIBAUD <albert.u.boot@aribaud.net>:
> Le 19/04/2012 08:44, Albert ARIBAUD a ?crit :
>
>> Hi Nobuhiro Iwamatsu,
>>
>> Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :
>>>
>>> With almost all the architecture and board BOARD_LATE_INIT does not use.
>>> CONFIG_BOARD_LATE_INIT is used instead.
>>> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
>>
>>
>> I think the commit message above is redundant with the commit summary,
>> especially for a trivial one-line change. Can you just post a V2 patch
>> with the same code change and commit summary, but without the commit
>> message?
>
>
> ... actually, you could apply this to all your elementary patches re
> BOARD_LATE_INIT, and then submit them in a single patch set.
>

I thought that I would resend to one patch collectively.
However, these were already taken into your repository.
Thank you.

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-05-07  1:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-18  2:41 [U-Boot] [PATCH] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT Nobuhiro Iwamatsu
2012-04-18  7:36 ` Stefano Babic
2012-04-19  6:44 ` Albert ARIBAUD
2012-04-19  6:48   ` Albert ARIBAUD
2012-05-07  1:38     ` Nobuhiro Iwamatsu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.