All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Faye-Lund <kusmabite@gmail.com>
To: linux-tegra@vger.kernel.org
Cc: tbergstrom@nvidia.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: host1x: do not check previously handled gathers
Date: Thu, 23 Jan 2014 18:31:22 +0100	[thread overview]
Message-ID: <CABPQNSarSsWTuYTP0pmBQUiMPcbLG-iPHR-3rS60qSGSVKO0qw@mail.gmail.com> (raw)
In-Reply-To: <1389124986-32501-1-git-send-email-kusmabite@gmail.com>

Ping?

On Tue, Jan 7, 2014 at 9:03 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
>  drivers/gpu/host1x/job.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index de5ec33..e965805 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
>
>                 g->base = job->gather_addr_phys[i];
>
> -               for (j = 0; j < job->num_gathers; j++)
> +               for (j = i + 1; j < job->num_gathers; j++)
>                         if (job->gathers[j].bo == g->bo)
>                                 job->gathers[j].handled = true;
>
> --
> 1.8.1.2
>

WARNING: multiple messages have this Message-ID (diff)
From: Erik Faye-Lund <kusmabite@gmail.com>
To: linux-tegra@vger.kernel.org
Cc: thierry.reding@gmail.com, tbergstrom@nvidia.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH] gpu: host1x: do not check previously handled gathers
Date: Thu, 23 Jan 2014 18:31:22 +0100	[thread overview]
Message-ID: <CABPQNSarSsWTuYTP0pmBQUiMPcbLG-iPHR-3rS60qSGSVKO0qw@mail.gmail.com> (raw)
In-Reply-To: <1389124986-32501-1-git-send-email-kusmabite@gmail.com>

Ping?

On Tue, Jan 7, 2014 at 9:03 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
>  drivers/gpu/host1x/job.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index de5ec33..e965805 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
>
>                 g->base = job->gather_addr_phys[i];
>
> -               for (j = 0; j < job->num_gathers; j++)
> +               for (j = i + 1; j < job->num_gathers; j++)
>                         if (job->gathers[j].bo == g->bo)
>                                 job->gathers[j].handled = true;
>
> --
> 1.8.1.2
>

  reply	other threads:[~2014-01-23 17:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 20:03 [PATCH] gpu: host1x: do not check previously handled gathers Erik Faye-Lund
2014-01-07 20:03 ` Erik Faye-Lund
2014-01-23 17:31 ` Erik Faye-Lund [this message]
2014-01-23 17:31   ` Erik Faye-Lund
2014-01-30 13:51 ` Terje Bergström
     [not found] ` <1389124986-32501-1-git-send-email-kusmabite-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-10 13:10   ` Thierry Reding
2014-02-10 13:10     ` Thierry Reding
2014-02-12 10:18 ` Thierry Reding
2014-02-12 10:18   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABPQNSarSsWTuYTP0pmBQUiMPcbLG-iPHR-3rS60qSGSVKO0qw@mail.gmail.com \
    --to=kusmabite@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=tbergstrom@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.