All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee <derrickstolee@github.com>,
	Git Mailing List <git@vger.kernel.org>,
	Victoria Dye <vdye@github.com>
Subject: Re: What's cooking in git.git (May 2022, #01; Mon, 2)
Date: Thu, 5 May 2022 09:15:31 -0700	[thread overview]
Message-ID: <CABPp-BH8VsH+Y3UxAvZM2kua8XGRE1RyenrESeYwofcq-=kjbQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqmtfwezx5.fsf@gitster.g>

On Thu, May 5, 2022 at 8:56 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Elijah Newren <newren@gmail.com> writes:
>
> > On v2 you said, "There are a few things that I found questionable, but
> > they were mostly documentation issues".  You brought up several points
> > in v2 where my wording in the Documentation was admittedly suboptimal,
> > though I think I addressed all of those in v3.
>
> Correct.  The above is all assuming that "cone is the future" is
> what is shared by the population that depends on sparse-checkout.  I
> do not have strong opinions to declare that, but to help the topic
> move forward, I was giving reviews under the condition, i.e. "If
> there is such a concensus, here are the things in your current
> iteration that would need to be addressed".

Thanks for the clarification.

> I vaguely recall there were folks who didn't like the change of
> default the last time you brought this topic up.  Convincing them is
> not my job---it is yours.  Mine has been to help prepare the code
> ready for public consumption when that happens.

That's a surprise to me; I don't remember anyone bringing that up,
ever.  Did I somehow miss it??  I'd be happy to talk to anyone and
hear their concerns if they do hold such an opinion.  Over the last
year or so both Stolee and Victoria have suggested such a change or
said they wondered why I didn't include such a change with other
sparse-checkout changes we were making, and I mentioned a few times I
thought it'd be a good future plan and finally submitted it.  To the
best of my memory, no one ever offered a counter opinion.

Are you perhaps mixing this up with the case where people brought up
concerns with suggested tab-completion changes?  That's the only other
related series recently where folks brought up concerns with suggested
changes.

  reply	other threads:[~2022-05-05 16:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 22:27 What's cooking in git.git (May 2022, #01; Mon, 2) Junio C Hamano
2022-05-03 21:19 ` Derrick Stolee
2022-05-04 16:18   ` Junio C Hamano
2022-05-05 15:04     ` Elijah Newren
2022-05-05 15:13       ` Derrick Stolee
2022-05-05 15:56       ` Junio C Hamano
2022-05-05 16:15         ` Elijah Newren [this message]
2022-05-05 18:53           ` Elijah Newren
2022-05-05 19:33             ` Junio C Hamano
2022-05-21 21:48             ` cone mode as default for sparse-checkout?, was " Johannes Schindelin
2022-05-04 21:56 ` brian m. carlson
2022-05-05  0:03   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPp-BH8VsH+Y3UxAvZM2kua8XGRE1RyenrESeYwofcq-=kjbQ@mail.gmail.com' \
    --to=newren@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.