All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer.
@ 2015-06-11 21:04 Chaitanya T K
  2015-06-17  9:08 ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya T K @ 2015-06-11 21:04 UTC (permalink / raw)
  To: Felix Fietkau, johannes; +Cc: linux-wireless, Chaitanya T K

In case of Dynamic SMPS enable RTS/CTS for all rates.

Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com>
---
V4: Updated commit log and fixed indent.
V3: Moved the check to set_rate.
V2:Fix indent and add signoff.
---
 net/mac80211/rc80211_minstrel_ht.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index 7430a1d..c8753ce 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -867,7 +867,13 @@ minstrel_ht_set_rate(struct minstrel_priv *mp, struct minstrel_ht_sta *mi,
 	else
 		idx = index % MCS_GROUP_RATES + (group->streams - 1) * 8;
 
-	if (offset > 0) {
+	/* Enable RTS/CTS for below cases.
+	 * 1) To Handle STA's SMPS State, if Nss > 1.
+	 * 2) 2nd and 3rd Rates, as 1st Rate Failed.
+	 */
+	if (offset > 0 &&
+	    (mi->sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
+	     group->streams > 1)) {
 		ratetbl->rate[offset].count = ratetbl->rate[offset].count_rts;
 		flags |= IEEE80211_TX_RC_USE_RTS_CTS;
 	}
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer.
  2015-06-11 21:04 [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer Chaitanya T K
@ 2015-06-17  9:08 ` Johannes Berg
  2015-06-17 10:17   ` Krishna Chaitanya
  0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2015-06-17  9:08 UTC (permalink / raw)
  To: Chaitanya T K; +Cc: Felix Fietkau, linux-wireless

On Fri, 2015-06-12 at 02:34 +0530, Chaitanya T K wrote:
> In case of Dynamic SMPS enable RTS/CTS for all rates.

Applied. I really think you should drop the "." at the end of the
subject though :)

johannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer.
  2015-06-17  9:08 ` Johannes Berg
@ 2015-06-17 10:17   ` Krishna Chaitanya
  2015-06-17 10:58     ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Krishna Chaitanya @ 2015-06-17 10:17 UTC (permalink / raw)
  To: Johannes Berg; +Cc: Felix Fietkau, linux-wireless

On Wed, Jun 17, 2015 at 2:38 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2015-06-12 at 02:34 +0530, Chaitanya T K wrote:
>> In case of Dynamic SMPS enable RTS/CTS for all rates.
>
> Applied. I really think you should drop the "." at the end of the
> subject though :)
>
Oh..will drop it. Is there any special reason?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer.
  2015-06-17 10:17   ` Krishna Chaitanya
@ 2015-06-17 10:58     ` Johannes Berg
  0 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2015-06-17 10:58 UTC (permalink / raw)
  To: Krishna Chaitanya; +Cc: Felix Fietkau, linux-wireless

On Wed, 2015-06-17 at 15:47 +0530, Krishna Chaitanya wrote:
> On Wed, Jun 17, 2015 at 2:38 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Fri, 2015-06-12 at 02:34 +0530, Chaitanya T K wrote:
> >> In case of Dynamic SMPS enable RTS/CTS for all rates.
> >
> > Applied. I really think you should drop the "." at the end of the
> > subject though :)
> >
> Oh..will drop it. Is there any special reason?

Not really. Just consistency and personal preference.

johannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-17 10:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-11 21:04 [PATCH V4] mac80211: minstrel_ht: Handle Dynamic SMPS state of the peer Chaitanya T K
2015-06-17  9:08 ` Johannes Berg
2015-06-17 10:17   ` Krishna Chaitanya
2015-06-17 10:58     ` Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.