All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florent Revest <revest@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org,
	mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org,
	xukuohai@huaweicloud.com
Subject: Re: [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi
Date: Tue, 7 Feb 2023 17:19:18 +0100	[thread overview]
Message-ID: <CABRcYmJQUPp=0TGKACX8-c69hgf8xuLAiLVO3oCFn3i1FCXUfw@mail.gmail.com> (raw)
In-Reply-To: <20230207103519.1f0ef013@gandalf.local.home>

On Tue, Feb 7, 2023 at 4:35 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 7 Feb 2023 16:21:49 +0100
> Florent Revest <revest@chromium.org> wrote:
>
> > Actually, I'm not sure anymore if we should delete the !multi samples...
> >
> > I realized that they are also used as part of the ftrace selftests in:
> > - tools/testing/selftests/ftrace/test.d/direct/ftrace-direct.tc
> > - tools/testing/selftests/ftrace/test.d/direct/kprobe-direct.tc
> >
> > It does not really make sense to use the ftrace-direct-muti sample as
> > a drop-in replacement for the ftrace-direct sample there since they
> > don't really do the same thing so we would either need to change the
> > test a bit or the multi sample.
> > Also, we would still need to adapt the ftrace-direct-too sample since
> > it has no multi equivalent and is required there.
>
> Let's not delete the samples, and they do test slightly different use cases
> (although the code may be somewhat the same). I rather still keep that test
> coverage.
>
> -- Steve

Ack :) Thanks Steve!

I'll undo the work I've started to do on this and send a v2 shortly afterward.

WARNING: multiple messages have this Message-ID (diff)
From: Florent Revest <revest@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,  bpf@vger.kernel.org,
	catalin.marinas@arm.com, will@kernel.org,  mhiramat@kernel.org,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	 kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com
Subject: Re: [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi
Date: Tue, 7 Feb 2023 17:19:18 +0100	[thread overview]
Message-ID: <CABRcYmJQUPp=0TGKACX8-c69hgf8xuLAiLVO3oCFn3i1FCXUfw@mail.gmail.com> (raw)
In-Reply-To: <20230207103519.1f0ef013@gandalf.local.home>

On Tue, Feb 7, 2023 at 4:35 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 7 Feb 2023 16:21:49 +0100
> Florent Revest <revest@chromium.org> wrote:
>
> > Actually, I'm not sure anymore if we should delete the !multi samples...
> >
> > I realized that they are also used as part of the ftrace selftests in:
> > - tools/testing/selftests/ftrace/test.d/direct/ftrace-direct.tc
> > - tools/testing/selftests/ftrace/test.d/direct/kprobe-direct.tc
> >
> > It does not really make sense to use the ftrace-direct-muti sample as
> > a drop-in replacement for the ftrace-direct sample there since they
> > don't really do the same thing so we would either need to change the
> > test a bit or the multi sample.
> > Also, we would still need to adapt the ftrace-direct-too sample since
> > it has no multi equivalent and is required there.
>
> Let's not delete the samples, and they do test slightly different use cases
> (although the code may be somewhat the same). I rather still keep that test
> coverage.
>
> -- Steve

Ack :) Thanks Steve!

I'll undo the work I've started to do on this and send a v2 shortly afterward.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-07 16:19 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 16:34 [PATCH 0/8] Add ftrace direct call for arm64 Florent Revest
2023-02-01 16:34 ` Florent Revest
2023-02-01 16:34 ` [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 15:01   ` Mark Rutland
2023-02-02 15:01     ` Mark Rutland
2023-02-02 17:37     ` Florent Revest
2023-02-02 17:37       ` Florent Revest
2023-02-07 15:21       ` Florent Revest
2023-02-07 15:21         ` Florent Revest
2023-02-07 15:35         ` Steven Rostedt
2023-02-07 15:35           ` Steven Rostedt
2023-02-07 16:19           ` Florent Revest [this message]
2023-02-07 16:19             ` Florent Revest
2023-02-01 16:34 ` [PATCH 2/8] ftrace: Remove the legacy _ftrace_direct API Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 15:11   ` Mark Rutland
2023-02-02 15:11     ` Mark Rutland
2023-02-01 16:34 ` [PATCH 3/8] ftrace: Rename _ftrace_direct_multi APIs to _ftrace_direct APIs Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 15:17   ` Mark Rutland
2023-02-02 15:17     ` Mark Rutland
2023-02-01 16:34 ` [PATCH 4/8] ftrace: Store direct called addresses in their ops Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 15:29   ` Mark Rutland
2023-02-02 15:29     ` Mark Rutland
2023-02-02 17:41     ` Florent Revest
2023-02-02 17:41       ` Florent Revest
2023-02-01 16:34 ` [PATCH 5/8] ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 15:54   ` Mark Rutland
2023-02-02 15:54     ` Mark Rutland
2023-02-02 16:56     ` Mark Rutland
2023-02-02 16:56       ` Mark Rutland
2023-02-02 18:19       ` Florent Revest
2023-02-02 18:19         ` Florent Revest
2023-02-03 10:03         ` Mark Rutland
2023-02-03 10:03           ` Mark Rutland
2023-02-03 11:01           ` Florent Revest
2023-02-03 11:01             ` Florent Revest
2023-02-02 18:18     ` Florent Revest
2023-02-02 18:18       ` Florent Revest
2023-02-01 16:34 ` [PATCH 6/8] ftrace: Fix dead loop caused by direct call in ftrace selftest Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02 19:03   ` Mark Rutland
2023-02-02 19:03     ` Mark Rutland
2023-02-03 12:35     ` Florent Revest
2023-02-03 12:35       ` Florent Revest
2023-02-03 15:37       ` Mark Rutland
2023-02-03 15:37         ` Mark Rutland
2023-02-06 16:25         ` Florent Revest
2023-02-06 16:25           ` Florent Revest
2023-02-01 16:34 ` [PATCH 7/8] arm64: ftrace: Add direct call support Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-03 15:34   ` Mark Rutland
2023-02-03 15:34     ` Mark Rutland
2023-02-06 16:25     ` Florent Revest
2023-02-06 16:25       ` Florent Revest
2023-02-01 16:34 ` [PATCH 8/8] arm64: ftrace: Add direct called trampoline samples support Florent Revest
2023-02-01 16:34   ` Florent Revest
2023-02-02  8:36 ` [PATCH 0/8] Add ftrace direct call for arm64 Xu Kuohai
2023-02-02  8:36   ` Xu Kuohai
2023-02-02 10:50   ` Daniel Borkmann
2023-02-02 10:50     ` Daniel Borkmann
2023-02-02 17:32     ` Florent Revest
2023-02-02 17:32       ` Florent Revest
2023-02-02 20:06 ` Steven Rostedt
2023-02-02 20:06   ` Steven Rostedt
2023-02-03  9:49   ` Mark Rutland
2023-02-03  9:49     ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABRcYmJQUPp=0TGKACX8-c69hgf8xuLAiLVO3oCFn3i1FCXUfw@mail.gmail.com' \
    --to=revest@chromium.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel@iogearbox.net \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    --cc=xukuohai@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.