* [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
@ 2011-10-20 14:02 Ashish Chavan
2011-10-20 16:58 ` [alsa-devel] " Girdwood, Liam
2011-10-21 8:58 ` Mark Brown
0 siblings, 2 replies; 11+ messages in thread
From: Ashish Chavan @ 2011-10-20 14:02 UTC (permalink / raw)
To: Mark Brown, lrg, alsa-devel
Cc: linux-kernel, kuninori.morimoto.gx, David Dajun Chen
This patch adds support for DAPM covering all inputs and outputs
as well as ADC and DAC.
Signed-off-by: Ashish Chavan <ashish.chavan@kpitcummins.com>
Signed-off-by: David Dajun Chen <dchen@diasemi.com>
---
Changes since v3:
- Added missing routes for In-mixer left and right
- Added comment explaining rational behind use of STANDBY registers
Changes since v1:
- used supply widget for mic bias
- removed mic bias hookup
- assigned dapm widgets and routes in card struct
- removed explicit setting of default mixer settings
- removed explicit setting of ios to standby mode
---
sound/soc/codecs/da7210.c | 240 ++++++++++++++++++++++++++++++++++++++++-----
1 files changed, 216 insertions(+), 24 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index f0a1999..2187db9 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -29,6 +29,8 @@
#define DA7210_CONTROL 0x01
#define DA7210_STATUS 0x02
#define DA7210_STARTUP1 0x03
+#define DA7210_STARTUP2 0x04
+#define DA7210_STARTUP3 0x05
#define DA7210_MIC_L 0x07
#define DA7210_MIC_R 0x08
#define DA7210_AUX1_L 0x09
@@ -52,6 +54,7 @@
#define DA7210_DAC_EQ5 0x1B
#define DA7210_OUTMIX_L 0x1C
#define DA7210_OUTMIX_R 0x1D
+#define DA7210_OUT2 0x20
#define DA7210_HP_L_VOL 0x21
#define DA7210_HP_R_VOL 0x22
#define DA7210_HP_CFG 0x23
@@ -372,6 +375,214 @@ static const struct snd_kcontrol_new da7210_snd_controls[] = {
0, snd_soc_get_volsw, da7210_put_noise_sup_sw),
};
+/*
+ * DAPM Controls
+ *
+ * Current DAPM implementation covers almost all codec components e.g. IOs,
+ * mixers, PGAs,ADC and DAC.
+ *
+ * For DA7210 codec, there are two ways to enable/disable analog IOs and
+ * ADC/DAC,
+ * (1) Using "Enable Bit" of register associated with that IO(or ADC/DAC)
+ * e.g. Mic Left can be enabled using bit 7 of MIC_L(0x7) reg
+ *
+ * (2) Using "Standby Bit" of STARTUP2 or STARTUP3 register
+ * e.g. Mic left can be put to STANDBY using bit 0 of STARTUP3(0x5) reg
+ *
+ * Out of these two methods, the one using STANDBY bits is preferred way to
+ * enable/disable individual blocks. This is because STANDBY registers are part
+ * of system controller which allows system power up/down in a controlled,
+ * pop-free manner. Also, as per application note of DA7210, STANDBY register
+ * bits are only effective if a particular IO (or ADC/DAC) is already enabled
+ * using enable/disable register bits. Keeping these things in mind, current
+ * DAPM implementation manipulates only STANDBY bits.
+ *
+ * Overall implementation can be outlined as below,
+ *
+ * - "Enable bit" of an IO or ADC/DAC is used to enable it in probe() function
+ * - "STANDBY bit" is controlled by DAPM
+ */
+/* In Mixer Left */
+static const struct snd_kcontrol_new da7210_dapm_inmixl_controls[] = {
+ SOC_DAPM_SINGLE("Mic Left Switch", DA7210_INMIX_L, 0, 1, 0),
+ SOC_DAPM_SINGLE("Mic Right Switch", DA7210_INMIX_L, 1, 1, 0),
+ SOC_DAPM_SINGLE("Aux1 Left Switch", DA7210_INMIX_L, 2, 1, 0),
+ SOC_DAPM_SINGLE("Aux2 Switch", DA7210_INMIX_L, 3, 1, 0),
+ SOC_DAPM_SINGLE("Outmix Left Switch", DA7210_INMIX_L, 4, 1, 0),
+};
+
+/* In Mixer Right */
+static const struct snd_kcontrol_new da7210_dapm_inmixr_controls[] = {
+ SOC_DAPM_SINGLE("Mic Right Switch", DA7210_INMIX_R, 0, 1, 0),
+ SOC_DAPM_SINGLE("Mic Left Switch", DA7210_INMIX_R, 1, 1, 0),
+ SOC_DAPM_SINGLE("Aux1 Right Switch", DA7210_INMIX_R, 2, 1, 0),
+ SOC_DAPM_SINGLE("Aux2 Switch", DA7210_INMIX_R, 3, 1, 0),
+ SOC_DAPM_SINGLE("Outmix Right Switch", DA7210_INMIX_R, 4, 1, 0),
+};
+
+/* Out Mixer Left */
+static const struct snd_kcontrol_new da7210_dapm_outmixl_controls[] = {
+ SOC_DAPM_SINGLE("Aux1 Left Switch", DA7210_OUTMIX_L, 0, 1, 0),
+ SOC_DAPM_SINGLE("Aux2 Switch", DA7210_OUTMIX_L, 1, 1, 0),
+ SOC_DAPM_SINGLE("INPGA Left Switch", DA7210_OUTMIX_L, 2, 1, 0),
+ SOC_DAPM_SINGLE("INPGA Right Switch", DA7210_OUTMIX_L, 3, 1, 0),
+ SOC_DAPM_SINGLE("DAC Left Switch", DA7210_OUTMIX_L, 4, 1, 0),
+};
+
+/* Out Mixer Right */
+static const struct snd_kcontrol_new da7210_dapm_outmixr_controls[] = {
+ SOC_DAPM_SINGLE("Aux1 Right Switch", DA7210_OUTMIX_R, 0, 1, 0),
+ SOC_DAPM_SINGLE("Aux2 Switch", DA7210_OUTMIX_R, 1, 1, 0),
+ SOC_DAPM_SINGLE("INPGA Left Switch", DA7210_OUTMIX_R, 2, 1, 0),
+ SOC_DAPM_SINGLE("INPGA Right Switch", DA7210_OUTMIX_R, 3, 1, 0),
+ SOC_DAPM_SINGLE("DAC Right Switch", DA7210_OUTMIX_R, 4, 1, 0),
+};
+
+/* Mono Mixer */
+static const struct snd_kcontrol_new da7210_dapm_monomix_controls[] = {
+ SOC_DAPM_SINGLE("INPGA Right Switch", DA7210_OUT2, 3, 1, 0),
+ SOC_DAPM_SINGLE("INPGA Left Switch", DA7210_OUT2, 4, 1, 0),
+ SOC_DAPM_SINGLE("Outmix Right Switch", DA7210_OUT2, 5, 1, 0),
+ SOC_DAPM_SINGLE("Outmix Left Switch", DA7210_OUT2, 6, 1, 0),
+};
+
+/* DAPM widgets */
+static const struct snd_soc_dapm_widget da7210_dapm_widgets[] = {
+ /* Input Side */
+ /* Input Lines */
+ SND_SOC_DAPM_INPUT("MICL"),
+ SND_SOC_DAPM_INPUT("MICR"),
+ SND_SOC_DAPM_INPUT("AUX1L"),
+ SND_SOC_DAPM_INPUT("AUX1R"),
+ SND_SOC_DAPM_INPUT("AUX2"),
+
+ /* Input PGAs */
+ SND_SOC_DAPM_PGA("Mic Left", DA7210_STARTUP3, 0, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Mic Right", DA7210_STARTUP3, 1, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Aux1 Left", DA7210_STARTUP3, 2, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Aux1 Right", DA7210_STARTUP3, 3, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Aux2 Mono", DA7210_STARTUP3, 4, 1, NULL, 0),
+
+ SND_SOC_DAPM_PGA("INPGA Left", DA7210_INMIX_L, 7, 0, NULL, 0),
+ SND_SOC_DAPM_PGA("INPGA Right", DA7210_INMIX_R, 7, 0, NULL, 0),
+
+ /* MICBIAS */
+ SND_SOC_DAPM_SUPPLY("Mic Bias", DA7210_MIC_L, 6, 0, NULL, 0),
+
+ /* Input Mixers */
+ SND_SOC_DAPM_MIXER("In Mixer Left", SND_SOC_NOPM, 0, 0,
+ &da7210_dapm_inmixl_controls[0],
+ ARRAY_SIZE(da7210_dapm_inmixl_controls)),
+
+ SND_SOC_DAPM_MIXER("In Mixer Right", SND_SOC_NOPM, 0, 0,
+ &da7210_dapm_inmixr_controls[0],
+ ARRAY_SIZE(da7210_dapm_inmixr_controls)),
+
+ /* ADCs */
+ SND_SOC_DAPM_ADC("ADC Left", "Capture", DA7210_STARTUP3, 5, 1),
+ SND_SOC_DAPM_ADC("ADC Right", "Capture", DA7210_STARTUP3, 6, 1),
+
+ /* Output Side */
+ /* DACs */
+ SND_SOC_DAPM_DAC("DAC Left", "Playback", DA7210_STARTUP2, 5, 1),
+ SND_SOC_DAPM_DAC("DAC Right", "Playback", DA7210_STARTUP2, 6, 1),
+
+ /* Output Mixers */
+ SND_SOC_DAPM_MIXER("Out Mixer Left", SND_SOC_NOPM, 0, 0,
+ &da7210_dapm_outmixl_controls[0],
+ ARRAY_SIZE(da7210_dapm_outmixl_controls)),
+
+ SND_SOC_DAPM_MIXER("Out Mixer Right", SND_SOC_NOPM, 0, 0,
+ &da7210_dapm_outmixr_controls[0],
+ ARRAY_SIZE(da7210_dapm_outmixr_controls)),
+
+ SND_SOC_DAPM_MIXER("Mono Mixer", SND_SOC_NOPM, 0, 0,
+ &da7210_dapm_monomix_controls[0],
+ ARRAY_SIZE(da7210_dapm_monomix_controls)),
+
+ /* Output PGAs */
+ SND_SOC_DAPM_PGA("OUTPGA Left Enable", DA7210_OUTMIX_L, 7, 0, NULL, 0),
+ SND_SOC_DAPM_PGA("OUTPGA Right Enable", DA7210_OUTMIX_R, 7, 0, NULL, 0),
+
+ SND_SOC_DAPM_PGA("Out1 Left", DA7210_STARTUP2, 0, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Out1 Right", DA7210_STARTUP2, 1, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Out2 Mono", DA7210_STARTUP2, 2, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Headphone Left", DA7210_STARTUP2, 3, 1, NULL, 0),
+ SND_SOC_DAPM_PGA("Headphone Right", DA7210_STARTUP2, 4, 1, NULL, 0),
+
+ /* Output Lines */
+ SND_SOC_DAPM_OUTPUT("OUT1L"),
+ SND_SOC_DAPM_OUTPUT("OUT1R"),
+ SND_SOC_DAPM_OUTPUT("HPL"),
+ SND_SOC_DAPM_OUTPUT("HPR"),
+ SND_SOC_DAPM_OUTPUT("OUT2"),
+};
+
+/* DAPM audio route definition */
+static const struct snd_soc_dapm_route da7210_audio_map[] = {
+ /* Dest Connecting Widget source */
+ /* Input path */
+ {"Mic Left", NULL, "MICL"},
+ {"Mic Right", NULL, "MICR"},
+ {"Aux1 Left", NULL, "AUX1L"},
+ {"Aux1 Right", NULL, "AUX1R"},
+ {"Aux2 Mono", NULL, "AUX2"},
+
+ {"In Mixer Left", "Mic Left Switch", "Mic Left"},
+ {"In Mixer Left", "Mic Right Switch", "Mic Right"},
+ {"In Mixer Left", "Aux1 Left Switch", "Aux1 Left"},
+ {"In Mixer Left", "Aux2 Switch", "Aux2 Mono"},
+ {"In Mixer Left", "Outmix Left Switch", "Out Mixer Left"},
+
+ {"In Mixer Right", "Mic Right Switch", "Mic Right"},
+ {"In Mixer Right", "Mic Left Switch", "Mic Left"},
+ {"In Mixer Right", "Aux1 Right Switch", "Aux1 Right"},
+ {"In Mixer Right", "Aux2 Switch", "Aux2 Mono"},
+ {"In Mixer Right", "Outmix Right Switch", "Out Mixer Right"},
+
+ {"INPGA Left", NULL, "In Mixer Left"},
+ {"ADC Left", NULL, "INPGA Left"},
+
+ {"INPGA Right", NULL, "In Mixer Right"},
+ {"ADC Right", NULL, "INPGA Right"},
+
+ /* Output path */
+ {"Out Mixer Left", "Aux1 Left Switch", "Aux1 Left"},
+ {"Out Mixer Left", "Aux2 Switch", "Aux2 Mono"},
+ {"Out Mixer Left", "INPGA Left Switch", "INPGA Left"},
+ {"Out Mixer Left", "INPGA Right Switch", "INPGA Right"},
+ {"Out Mixer Left", "DAC Left Switch", "DAC Left"},
+
+ {"Out Mixer Right", "Aux1 Right Switch", "Aux1 Right"},
+ {"Out Mixer Right", "Aux2 Switch", "Aux2 Mono"},
+ {"Out Mixer Right", "INPGA Right Switch", "INPGA Right"},
+ {"Out Mixer Right", "INPGA Left Switch", "INPGA Left"},
+ {"Out Mixer Right", "DAC Right Switch", "DAC Right"},
+
+ {"Mono Mixer", "INPGA Right Switch", "INPGA Right"},
+ {"Mono Mixer", "INPGA Left Switch", "INPGA Left"},
+ {"Mono Mixer", "Outmix Right Switch", "Out Mixer Right"},
+ {"Mono Mixer", "Outmix Left Switch", "Out Mixer Left"},
+
+ {"OUTPGA Left Enable", NULL, "Out Mixer Left"},
+ {"OUTPGA Right Enable", NULL, "Out Mixer Right"},
+
+ {"Out1 Left", NULL, "OUTPGA Left Enable"},
+ {"OUT1L", NULL, "Out1 Left"},
+
+ {"Out1 Right", NULL, "OUTPGA Right Enable"},
+ {"OUT1R", NULL, "Out1 Right"},
+
+ {"Headphone Left", NULL, "OUTPGA Left Enable"},
+ {"HPL", NULL, "Headphone Left"},
+
+ {"Headphone Right", NULL, "OUTPGA Right Enable"},
+ {"HPR", NULL, "Headphone Right"},
+
+ {"Out2 Mono", NULL, "Mono Mixer"},
+ {"OUT2", NULL, "Out2 Mono"},
+};
+
/* Codec private data */
struct da7210_priv {
enum snd_soc_control_type control_type;
@@ -411,29 +622,6 @@ static int da7210_volatile_register(struct snd_soc_codec *codec,
return 0;
}
}
-static int da7210_startup(struct snd_pcm_substream *substream,
- struct snd_soc_dai *dai)
-{
- int is_play = substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
- struct snd_soc_codec *codec = dai->codec;
-
- if (is_play) {
- /* Enable Out */
- snd_soc_update_bits(codec, DA7210_OUTMIX_L, 0x1F, 0x10);
- snd_soc_update_bits(codec, DA7210_OUTMIX_R, 0x1F, 0x10);
-
- } else {
- /* Volume 7 */
- snd_soc_update_bits(codec, DA7210_MIC_L, 0x7, 0x7);
- snd_soc_update_bits(codec, DA7210_MIC_R, 0x7, 0x7);
-
- /* Enable Mic */
- snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0x1);
- snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0x1);
- }
-
- return 0;
-}
/*
* Set PCM DAI word length.
@@ -603,7 +791,6 @@ static int da7210_mute(struct snd_soc_dai *dai, int mute)
/* DAI operations */
static struct snd_soc_dai_ops da7210_dai_ops = {
- .startup = da7210_startup,
.hw_params = da7210_hw_params,
.set_fmt = da7210_set_dai_fmt,
.digital_mute = da7210_mute,
@@ -742,6 +929,11 @@ static struct snd_soc_codec_driver soc_codec_dev_da7210 = {
.controls = da7210_snd_controls,
.num_controls = ARRAY_SIZE(da7210_snd_controls),
+
+ .dapm_widgets = da7210_dapm_widgets,
+ .num_dapm_widgets = ARRAY_SIZE(da7210_dapm_widgets),
+ .dapm_routes = da7210_audio_map,
+ .num_dapm_routes = ARRAY_SIZE(da7210_audio_map),
};
#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
--
1.7.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-20 14:02 [PATCH v7 1/3] ASoC: da7210: Add support for DAPM Ashish Chavan
@ 2011-10-20 16:58 ` Girdwood, Liam
2011-10-21 8:58 ` Mark Brown
1 sibling, 0 replies; 11+ messages in thread
From: Girdwood, Liam @ 2011-10-20 16:58 UTC (permalink / raw)
To: Ashish Chavan
Cc: Mark Brown, alsa-devel, David Dajun Chen, kuninori.morimoto.gx,
linux-kernel
On 20 October 2011 15:02, Ashish Chavan <ashish.chavan@kpitcummins.com> wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.
>
> Signed-off-by: Ashish Chavan <ashish.chavan@kpitcummins.com>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> ---
> Changes since v3:
> - Added missing routes for In-mixer left and right
> - Added comment explaining rational behind use of STANDBY registers
>
> Changes since v1:
> - used supply widget for mic bias
> - removed mic bias hookup
> - assigned dapm widgets and routes in card struct
> - removed explicit setting of default mixer settings
> - removed explicit setting of ios to standby mode
> ---
> sound/soc/codecs/da7210.c | 240 ++++++++++++++++++++++++++++++++++++++++-----
> 1 files changed, 216 insertions(+), 24 deletions(-)
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-20 14:02 [PATCH v7 1/3] ASoC: da7210: Add support for DAPM Ashish Chavan
@ 2011-10-21 8:58 ` Mark Brown
2011-10-21 8:58 ` Mark Brown
1 sibling, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 8:58 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx, linux-kernel
On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.
This patch doesn't apply against current code.
> +/*
> + * DAPM Controls
> + *
> + * Current DAPM implementation covers almost all codec components e.g. IOs,
> + * mixers, PGAs,ADC and DAC.
This explanation would better placed next to the code in the probe -
it's that code which looks out of place in a Linux driver.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
@ 2011-10-21 8:58 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 8:58 UTC (permalink / raw)
To: Ashish Chavan
Cc: linux-kernel, alsa-devel, lrg, kuninori.morimoto.gx, David Dajun Chen
On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.
This patch doesn't apply against current code.
> +/*
> + * DAPM Controls
> + *
> + * Current DAPM implementation covers almost all codec components e.g. IOs,
> + * mixers, PGAs,ADC and DAC.
This explanation would better placed next to the code in the probe -
it's that code which looks out of place in a Linux driver.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-21 8:58 ` Mark Brown
(?)
@ 2011-10-21 9:47 ` Ashish Chavan
2011-10-21 10:23 ` Mark Brown
-1 siblings, 1 reply; 11+ messages in thread
From: Ashish Chavan @ 2011-10-21 9:47 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, kuninori.morimoto.gx, linux-kernel, David, Chen, lrg
On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> > This patch adds support for DAPM covering all inputs and outputs
> > as well as ADC and DAC.
>
> This patch doesn't apply against current code.
That's strange! Let me recheck to see if I messed anything.
>
> > +/*
> > + * DAPM Controls
> > + *
> > + * Current DAPM implementation covers almost all codec components e.g. IOs,
> > + * mixers, PGAs,ADC and DAC.
>
> This explanation would better placed next to the code in the probe -
> it's that code which looks out of place in a Linux driver.
Only problem with that is the code to enable individual IOs is not at
one place and is scattered in the probe(). Should I place all such
things in a single block in probe() and put the comment above that?
Thanks,
-- Ashish (GNU FAN)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-21 9:47 ` Ashish Chavan
@ 2011-10-21 10:23 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 10:23 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx, linux-kernel
On Fri, Oct 21, 2011 at 03:17:26PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> > This explanation would better placed next to the code in the probe -
> > it's that code which looks out of place in a Linux driver.
> Only problem with that is the code to enable individual IOs is not at
> one place and is scattered in the probe(). Should I place all such
> things in a single block in probe() and put the comment above that?
That sounds like a good idea - it's fine to split them up per feature
being enabled but if the big comment is in front of all of them that'd
be really helpful.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
@ 2011-10-21 10:23 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 10:23 UTC (permalink / raw)
To: Ashish Chavan
Cc: linux-kernel, alsa-devel, lrg, kuninori.morimoto.gx, David Dajun Chen
On Fri, Oct 21, 2011 at 03:17:26PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> > This explanation would better placed next to the code in the probe -
> > it's that code which looks out of place in a Linux driver.
> Only problem with that is the code to enable individual IOs is not at
> one place and is scattered in the probe(). Should I place all such
> things in a single block in probe() and put the comment above that?
That sounds like a good idea - it's fine to split them up per feature
being enabled but if the big comment is in front of all of them that'd
be really helpful.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-21 10:37 ` Ashish Chavan
@ 2011-10-21 10:31 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 10:31 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx, linux-kernel
On Fri, Oct 21, 2011 at 04:07:21PM +0530, Ashish Chavan wrote:
> Is there web interface to your tree? so that I can introspect your
> version of da7210.c file to find out what is going wrong? Or any other
> way to get your version of that file?
http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
@ 2011-10-21 10:31 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-10-21 10:31 UTC (permalink / raw)
To: Ashish Chavan
Cc: linux-kernel, alsa-devel, lrg, kuninori.morimoto.gx, David Dajun Chen
On Fri, Oct 21, 2011 at 04:07:21PM +0530, Ashish Chavan wrote:
> Is there web interface to your tree? so that I can introspect your
> version of da7210.c file to find out what is going wrong? Or any other
> way to get your version of that file?
http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-21 8:58 ` Mark Brown
(?)
(?)
@ 2011-10-21 10:37 ` Ashish Chavan
2011-10-21 10:31 ` Mark Brown
-1 siblings, 1 reply; 11+ messages in thread
From: Ashish Chavan @ 2011-10-21 10:37 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, kuninori.morimoto.gx, linux-kernel, David, Chen, lrg
On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> > This patch adds support for DAPM covering all inputs and outputs
> > as well as ADC and DAC.
>
> This patch doesn't apply against current code.
Some how I am unable to sync my tree right now. BTW I re-tested it and
it applies fine on my tree. I am assuming that your tree has my earlier
patches for mute controls and ALC applied.
Is there web interface to your tree? so that I can introspect your
version of da7210.c file to find out what is going wrong? Or any other
way to get your version of that file?
>
> > +/*
> > + * DAPM Controls
> > + *
> > + * Current DAPM implementation covers almost all codec components e.g. IOs,
> > + * mixers, PGAs,ADC and DAC.
>
> This explanation would better placed next to the code in the probe -
> it's that code which looks out of place in a Linux driver.
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
2011-10-21 10:31 ` Mark Brown
(?)
@ 2011-10-21 11:01 ` Ashish Chavan
-1 siblings, 0 replies; 11+ messages in thread
From: Ashish Chavan @ 2011-10-21 11:01 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, kuninori.morimoto.gx, linux-kernel, David, Chen, lrg
On Fri, 2011-10-21 at 11:31 +0100, Mark Brown wrote:
> On Fri, Oct 21, 2011 at 04:07:21PM +0530, Ashish Chavan wrote:
>
> > Is there web interface to your tree? so that I can introspect your
> > version of da7210.c file to find out what is going wrong? Or any other
> > way to get your version of that file?
>
> http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi
>
Thanks. Got the issue. Resubmitting the patch shortly.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-10-21 10:53 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-20 14:02 [PATCH v7 1/3] ASoC: da7210: Add support for DAPM Ashish Chavan
2011-10-20 16:58 ` [alsa-devel] " Girdwood, Liam
2011-10-21 8:58 ` Mark Brown
2011-10-21 8:58 ` Mark Brown
2011-10-21 9:47 ` Ashish Chavan
2011-10-21 10:23 ` [alsa-devel] " Mark Brown
2011-10-21 10:23 ` Mark Brown
2011-10-21 10:37 ` Ashish Chavan
2011-10-21 10:31 ` [alsa-devel] " Mark Brown
2011-10-21 10:31 ` Mark Brown
2011-10-21 11:01 ` Ashish Chavan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.