"Submodule registered for path" output with config aliases mixed in

"Submodule registered for path" output with config aliases mixed in

[Mateusz Loskot]

Hi,

$ git version
git version 2.20.1.windows.1

I'm running `git clone --recurse-submodules https://XXX`
The command seems to run well and completes with success.

However, I noticed strange output from git:

```
Submodule 'Binary/A' (https://XXX) registered for path '!f() {
~/AppData/Local/Fork/Fork.exe $PWD; }; fBinary/A'
Submodule 'Binary/B' (https://XXX) registered for path 'À   ♂♦Binary/Intergraph'
Submodule 'Binary/C' (https://XXX) registered for path '!sh -c 'git
log $1@{1}..$1@{0} $@'Binary/C'
Submodule 'Binary/D' (https://XXX) registered for path 'ls-files -o -i
--exclude-standardBinary/D'
Submodule 'Binary/E' (https://XXX) registered for path
'mergetool.TortoiseGitMerge.trustexitcodeBinary/E'
```

I managed to identify where that garbage injections come from:
from git aliases I've got configured [1]

Could anyone explain what is happening here?
Is there anything wrong with my ~/.gitconfig [1] ?


[1] https://github.com/mloskot/wsl-config/tree/master/git

-- 
Best regards,
Mateusz Łoskot, http://mateusz.loskot.net

Re: "Submodule registered for path" output with config aliases mixed in

[Mateusz Loskot]

Hmm, sorry for pushing, but no ideas, really?
Doesn't it seem like a bug?

Matz

On Tue, 19 Feb 2019 at 17:51, Mateusz Loskot <mateusz@loskot.net> wrote:
>
> Hi,
>
> $ git version
> git version 2.20.1.windows.1
>
> I'm running `git clone --recurse-submodules https://...`
> The command seems to run well and completes with success.
>
> However, I noticed strange output from git:
>
> ```
> Submodule 'Binary/A' (https://...) registered for path '!f() { ~/AppData/Local/Fork/Fork.exe $PWD; }; fBinary/A'
> Submodule 'Binary/B' (https://...) registered for path 'À   ♂♦Binary/Intergraph'
> Submodule 'Binary/C' (https://....) registered for path '!sh -c 'git log $1@{1}..$1@{0} $@'Binary/C'
> Submodule 'Binary/D' (https://...) registered for path 'ls-files -o -i --exclude-standardBinary/D'
> Submodule 'Binary/E' (https://...) registered for path 'mergetool.TortoiseGitMerge.trustexitcodeBinary/E'
> ```
>
> I managed to identify where that garbage injections come from:
> from git aliases I've got configured [1]
>
> Could anyone explain what is happening here?
> Is there anything wrong with my ~/.gitconfig [1] ?
>
>
> [1] https://github.com/mloskot/wsl-config/tree/master/git
>
> --
> Best regards,
> Mateusz Łoskot, http://mateusz.loskot.net



-- 
Mateusz Loskot, http://mateusz.loskot.net

Re: "Submodule registered for path" output with config aliases mixed in

[brian m. carlson]

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

On Tue, Feb 19, 2019 at 05:51:05PM +0100, Mateusz Loskot wrote:
> Hi,
> 
> $ git version
> git version 2.20.1.windows.1
> 
> I'm running `git clone --recurse-submodules https://XXX`
> The command seems to run well and completes with success.
> 
> However, I noticed strange output from git:
> 
> ```
> Submodule 'Binary/A' (https://XXX) registered for path '!f() {
> ~/AppData/Local/Fork/Fork.exe $PWD; }; fBinary/A'
> Submodule 'Binary/B' (https://XXX) registered for path 'À   ♂♦Binary/Intergraph'
> Submodule 'Binary/C' (https://XXX) registered for path '!sh -c 'git
> log $1@{1}..$1@{0} $@'Binary/C'
> Submodule 'Binary/D' (https://XXX) registered for path 'ls-files -o -i
> --exclude-standardBinary/D'
> Submodule 'Binary/E' (https://XXX) registered for path
> 'mergetool.TortoiseGitMerge.trustexitcodeBinary/E'
> ```
> 
> I managed to identify where that garbage injections come from:
> from git aliases I've got configured [1]
> 
> Could anyone explain what is happening here?
> Is there anything wrong with my ~/.gitconfig [1] ?

I see the right behavior on my system (Debian amd64/sid) with
2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
don't see any memory warnings on my system.

Does your .gitmodules file appear to be correct in the main repository
when you clone, or does it contain unexpected entries?
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]

Re: "Submodule registered for path" output with config aliases mixed in

[Duy Nguyen]

On Thu, Feb 21, 2019 at 9:19 AM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On Tue, Feb 19, 2019 at 05:51:05PM +0100, Mateusz Loskot wrote:
> > Hi,
> >
> > $ git version
> > git version 2.20.1.windows.1
> >
> > I'm running `git clone --recurse-submodules https://XXX`
> > The command seems to run well and completes with success.
> >
> > However, I noticed strange output from git:
> >
> > ```
> > Submodule 'Binary/A' (https://XXX) registered for path '!f() {
> > ~/AppData/Local/Fork/Fork.exe $PWD; }; fBinary/A'
> > Submodule 'Binary/B' (https://XXX) registered for path 'À   ♂♦Binary/Intergraph'
> > Submodule 'Binary/C' (https://XXX) registered for path '!sh -c 'git
> > log $1@{1}..$1@{0} $@'Binary/C'
> > Submodule 'Binary/D' (https://XXX) registered for path 'ls-files -o -i
> > --exclude-standardBinary/D'
> > Submodule 'Binary/E' (https://XXX) registered for path
> > 'mergetool.TortoiseGitMerge.trustexitcodeBinary/E'
> > ```
> >
> > I managed to identify where that garbage injections come from:
> > from git aliases I've got configured [1]
> >
> > Could anyone explain what is happening here?
> > Is there anything wrong with my ~/.gitconfig [1] ?
>
> I see the right behavior on my system (Debian amd64/sid) with
> 2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
> don't see any memory warnings on my system.

I ran valgrind yesterday (gentoo amd64) and didn't find the problem
either even though it clearly looked like some dangling pointers. I
also audited this code and couldn't find anything obviously wrong. My
only suspicion is maybe some strange getenv() behavior on Windows
(_if_ the super prefix is used, but I can't see how...) and that's
just a dead end for me.
-- 
Duy

Re: "Submodule registered for path" output with config aliases mixed in

[Jeff King]

On Thu, Feb 21, 2019 at 10:47:45AM +0700, Duy Nguyen wrote:

> > > I managed to identify where that garbage injections come from:
> > > from git aliases I've got configured [1]
> > >
> > > Could anyone explain what is happening here?
> > > Is there anything wrong with my ~/.gitconfig [1] ?
> >
> > I see the right behavior on my system (Debian amd64/sid) with
> > 2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
> > don't see any memory warnings on my system.
> 
> I ran valgrind yesterday (gentoo amd64) and didn't find the problem
> either even though it clearly looked like some dangling pointers. I
> also audited this code and couldn't find anything obviously wrong. My
> only suspicion is maybe some strange getenv() behavior on Windows
> (_if_ the super prefix is used, but I can't see how...) and that's
> just a dead end for me.

Certainly we fixed a bunch of getenv() problems in the upcoming 2.21
release, including 8aac69038f (get_super_prefix(): copy getenv() result,
2019-01-11).

Mateusz, can you try with the one of the v2.21.0 release candidates (or
the current tip of "master")?

-Peff

Re: "Submodule registered for path" output with config aliases mixed in

[Mateusz Loskot]

On Thu, 21 Feb 2019 at 05:17, Jeff King <peff@peff.net> wrote:
> On Thu, Feb 21, 2019 at 10:47:45AM +0700, Duy Nguyen wrote:
>
> > > > I managed to identify where that garbage injections come from:
> > > > from git aliases I've got configured [1]
> > > >
> > > > Could anyone explain what is happening here?
> > > > Is there anything wrong with my ~/.gitconfig [1] ?
> > >
> > > I see the right behavior on my system (Debian amd64/sid) with
> > > 2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
> > > don't see any memory warnings on my system.
> >
> > I ran valgrind yesterday (gentoo amd64) and didn't find the problem
> > either even though it clearly looked like some dangling pointers. I
> > also audited this code and couldn't find anything obviously wrong. My
> > only suspicion is maybe some strange getenv() behavior on Windows
> > (_if_ the super prefix is used, but I can't see how...) and that's
> > just a dead end for me.
>
> Certainly we fixed a bunch of getenv() problems in the upcoming 2.21
> release, including 8aac69038f (get_super_prefix(): copy getenv() result,
> 2019-01-11).
>
> Mateusz, can you try with the one of the v2.21.0 release candidates (or
> the current tip of "master")?

Jeff, I have just tried git version 2.21.0.rc2.windows.1 and
I no longer see the problem.
It seems like a bug in earlier version indeed, that has been fixed now.

Brian, yes, the .gitmodules was perfectly correct.

Brian, Duy, Jeff, thank you all for responding; the problem has
been solved for me now.

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net

Re: "Submodule registered for path" output with config aliases mixed in

[Jeff King]

On Thu, Feb 21, 2019 at 11:53:12AM +0100, Mateusz Loskot wrote:

> On Thu, 21 Feb 2019 at 05:17, Jeff King <peff@peff.net> wrote:
> > On Thu, Feb 21, 2019 at 10:47:45AM +0700, Duy Nguyen wrote:
> >
> > > > > I managed to identify where that garbage injections come from:
> > > > > from git aliases I've got configured [1]
> > > > >
> > > > > Could anyone explain what is happening here?
> > > > > Is there anything wrong with my ~/.gitconfig [1] ?
> > > >
> > > > I see the right behavior on my system (Debian amd64/sid) with
> > > > 2.21.0.rc0.258.g878e2cd30e and with master. I've built with ASan and
> > > > don't see any memory warnings on my system.
> > >
> > > I ran valgrind yesterday (gentoo amd64) and didn't find the problem
> > > either even though it clearly looked like some dangling pointers. I
> > > also audited this code and couldn't find anything obviously wrong. My
> > > only suspicion is maybe some strange getenv() behavior on Windows
> > > (_if_ the super prefix is used, but I can't see how...) and that's
> > > just a dead end for me.
> >
> > Certainly we fixed a bunch of getenv() problems in the upcoming 2.21
> > release, including 8aac69038f (get_super_prefix(): copy getenv() result,
> > 2019-01-11).
> >
> > Mateusz, can you try with the one of the v2.21.0 release candidates (or
> > the current tip of "master")?
> 
> Jeff, I have just tried git version 2.21.0.rc2.windows.1 and
> I no longer see the problem.
> It seems like a bug in earlier version indeed, that has been fixed now.

Great, thanks for confirming.

Junio, Johannes: I don't know if there were particular plans to pick up
those getenv() fixes for "maint", but if we're going to do a v2.20.2, it
might be worth it.  It's also possible that it's just due to ca1b411648
(mingw: safe-guard a bit more against getenv() problems, 2019-02-15),
but I'd consider that to be maint-worthy as well.

It may be that we just don't do a v2.20.2, though, since v2.21 is so
close to release.

-Peff

Re: "Submodule registered for path" output with config aliases mixed in

[Junio C Hamano]

Jeff King <peff@peff.net> writes:

> Junio, Johannes: I don't know if there were particular plans to pick up
> those getenv() fixes for "maint", but if we're going to do a v2.20.2, it
> might be worth it.  It's also possible that it's just due to ca1b411648
> (mingw: safe-guard a bit more against getenv() problems, 2019-02-15),
> but I'd consider that to be maint-worthy as well.
>
> It may be that we just don't do a v2.20.2, though, since v2.21 is so
> close to release.

Yeah, they are all low-risk and straight-forward changes, and were
queued on a topic branch forked at 2.19.2 to make it possible to
directly merge to older maintenance tracks.  So if we are going to
update 2.20.x (or even 2.19.x) series, we can certainly include
them.

Thanks.