* [PATCH] drm: Add missing break in the command line mode parsing code
@ 2012-10-09 11:26 Damien Lespiau
2012-10-19 16:55 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Damien Lespiau @ 2012-10-09 11:26 UTC (permalink / raw)
To: intel-gfx, dri-devel
From: Damien Lespiau <damien.lespiau@intel.com>
As we parse the string given on the command line one char at a time, it
seems that we do want a break at every case.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/drm_modes.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 28637c1..50bd5c1 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1054,6 +1054,7 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,
was_digit = false;
} else
goto done;
+ break;
case '0' ... '9':
was_digit = true;
break;
--
1.7.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: Add missing break in the command line mode parsing code
2012-10-09 11:26 [PATCH] drm: Add missing break in the command line mode parsing code Damien Lespiau
@ 2012-10-19 16:55 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2012-10-19 16:55 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1255 bytes --]
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
On Tue, Oct 9, 2012 at 8:26 AM, Damien Lespiau <damien.lespiau@gmail.com>wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> As we parse the string given on the command line one char at a time, it
> seems that we do want a break at every case.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/drm_modes.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 28637c1..50bd5c1 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1054,6 +1054,7 @@ bool drm_mode_parse_command_line_for_connector(const
> char *mode_option,
> was_digit = false;
> } else
> goto done;
> + break;
> case '0' ... '9':
> was_digit = true;
> break;
> --
> 1.7.7.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
[-- Attachment #1.2: Type: text/html, Size: 2072 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-19 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 11:26 [PATCH] drm: Add missing break in the command line mode parsing code Damien Lespiau
2012-10-19 16:55 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.