All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd)
@ 2017-06-11 19:30 Julia Lawall
  2017-06-12 23:58 ` Rodrigo Vivi
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2017-06-11 19:30 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx, Dhinakaran Pandiyan, kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3542 bytes --]

Hello,

There are two tests on IS_KBL_ULT on line 423.  Please check on whether
this is intentional.

thanks,
julia

---------- Forwarded message ----------
Date: Mon, 12 Jun 2017 01:20:56 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee
    Lake.

CC: kbuild-all@01.org
In-Reply-To: <1497045239-17396-1-git-send-email-rodrigo.vivi@intel.com>
TO: Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>

Hi Rodrigo,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.12-rc4 next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-cfl-Basic-DDI-plumbing-for-Coffee-Lake/20170611-230941
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

>> drivers/gpu/drm/i915/intel_ddi.c:423:37-57: duplicated argument to && or ||

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 8ee2d3e5ef67af019c1db3062d9e9fbfca0fa616
vim +423 drivers/gpu/drm/i915/intel_ddi.c

8ee2d3e5 Rodrigo Vivi    2017-06-09  407  	} else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
0fdd4918 Rodrigo Vivi    2016-10-18  408  		*n_entries = ARRAY_SIZE(kbl_u_ddi_translations_dp);
0fdd4918 Rodrigo Vivi    2016-10-18  409  		return kbl_u_ddi_translations_dp;
0fdd4918 Rodrigo Vivi    2016-10-18  410  	} else {
0fdd4918 Rodrigo Vivi    2016-10-18  411  		*n_entries = ARRAY_SIZE(kbl_ddi_translations_dp);
0fdd4918 Rodrigo Vivi    2016-10-18  412  		return kbl_ddi_translations_dp;
0fdd4918 Rodrigo Vivi    2016-10-18  413  	}
0fdd4918 Rodrigo Vivi    2016-10-18  414  }
0fdd4918 Rodrigo Vivi    2016-10-18  415
0fdd4918 Rodrigo Vivi    2016-10-18  416  static const struct ddi_buf_trans *
78ab0bae Ville Syrjälä   2015-12-08  417  skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
f8896f5d David Weinehall 2015-06-25  418  {
06411f08 Jani Nikula     2016-03-24  419  	if (dev_priv->vbt.edp.low_vswing) {
78ab0bae Ville Syrjälä   2015-12-08  420  		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
5f8b2531 Rodrigo Vivi    2015-08-24  421  			*n_entries = ARRAY_SIZE(skl_y_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  422  			return skl_y_ddi_translations_edp;
8ee2d3e5 Rodrigo Vivi    2017-06-09 @423  		} else if (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv) ||
8ee2d3e5 Rodrigo Vivi    2017-06-09  424  			   IS_KBL_ULT(dev_priv)) {
f8896f5d David Weinehall 2015-06-25  425  			*n_entries = ARRAY_SIZE(skl_u_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  426  			return skl_u_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25  427  		} else {
f8896f5d David Weinehall 2015-06-25  428  			*n_entries = ARRAY_SIZE(skl_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  429  			return skl_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25  430  		}
f8896f5d David Weinehall 2015-06-25  431  	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd)
  2017-06-11 19:30 [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd) Julia Lawall
@ 2017-06-12 23:58 ` Rodrigo Vivi
  0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2017-06-12 23:58 UTC (permalink / raw)
  To: Julia Lawall, Rodrigo Vivi; +Cc: intel-gfx, Dhinakaran Pandiyan, kbuild-all


[-- Attachment #1.1: Type: text/plain, Size: 4583 bytes --]

Patch Merges to dinq, thanks for the reviews.

Julia,

DK had also pointed that out and the issue was addressed on latest version
that got reviewed and merged.

I'm sorry but I only saw your comment after I had merged the patch,
otherwise I'd have mentioned you also.


On Sun, Jun 11, 2017 at 12:41 PM Julia Lawall <julia.lawall@lip6.fr> wrote:

> Hello,
>
> There are two tests on IS_KBL_ULT on line 423.  Please check on whether
> this is intentional.
>
> thanks,
> julia
>
> ---------- Forwarded message ----------
> Date: Mon, 12 Jun 2017 01:20:56 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/cfl: Basic DDI plumbing for
> Coffee
>     Lake.
>
> CC: kbuild-all@01.org
> In-Reply-To: <1497045239-17396-1-git-send-email-rodrigo.vivi@intel.com>
> TO: Rodrigo Vivi <rodrigo.vivi@intel.com>
> CC: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan <
> dhinakaran.pandiyan@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
> CC: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, Rodrigo Vivi <
> rodrigo.vivi@intel.com>
>
> Hi Rodrigo,
>
> [auto build test WARNING on drm-intel/for-linux-next]
> [also build test WARNING on v4.12-rc4 next-20170609]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-cfl-Basic-DDI-plumbing-for-Coffee-Lake/20170611-230941
> base:   git://anongit.freedesktop.org/drm-intel for-linux-next
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
>
> >> drivers/gpu/drm/i915/intel_ddi.c:423:37-57: duplicated argument to &&
> or ||
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 8ee2d3e5ef67af019c1db3062d9e9fbfca0fa616
> vim +423 drivers/gpu/drm/i915/intel_ddi.c
>
> 8ee2d3e5 Rodrigo Vivi    2017-06-09  407        } else if
> (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
> 0fdd4918 Rodrigo Vivi    2016-10-18  408                *n_entries =
> ARRAY_SIZE(kbl_u_ddi_translations_dp);
> 0fdd4918 Rodrigo Vivi    2016-10-18  409                return
> kbl_u_ddi_translations_dp;
> 0fdd4918 Rodrigo Vivi    2016-10-18  410        } else {
> 0fdd4918 Rodrigo Vivi    2016-10-18  411                *n_entries =
> ARRAY_SIZE(kbl_ddi_translations_dp);
> 0fdd4918 Rodrigo Vivi    2016-10-18  412                return
> kbl_ddi_translations_dp;
> 0fdd4918 Rodrigo Vivi    2016-10-18  413        }
> 0fdd4918 Rodrigo Vivi    2016-10-18  414  }
> 0fdd4918 Rodrigo Vivi    2016-10-18  415
> 0fdd4918 Rodrigo Vivi    2016-10-18  416  static const struct
> ddi_buf_trans *
> 78ab0bae Ville Syrjälä   2015-12-08  417  skl_get_buf_trans_edp(struct
> drm_i915_private *dev_priv, int *n_entries)
> f8896f5d David Weinehall 2015-06-25  418  {
> 06411f08 Jani Nikula     2016-03-24  419        if
> (dev_priv->vbt.edp.low_vswing) {
> 78ab0bae Ville Syrjälä   2015-12-08  420                if
> (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
> 5f8b2531 Rodrigo Vivi    2015-08-24  421                        *n_entries
> = ARRAY_SIZE(skl_y_ddi_translations_edp);
> acee2998 Ville Syrjälä   2015-12-08  422                        return
> skl_y_ddi_translations_edp;
> 8ee2d3e5 Rodrigo Vivi    2017-06-09 @423                } else if
> (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv) ||
> 8ee2d3e5 Rodrigo Vivi    2017-06-09  424
>  IS_KBL_ULT(dev_priv)) {
> f8896f5d David Weinehall 2015-06-25  425                        *n_entries
> = ARRAY_SIZE(skl_u_ddi_translations_edp);
> acee2998 Ville Syrjälä   2015-12-08  426                        return
> skl_u_ddi_translations_edp;
> f8896f5d David Weinehall 2015-06-25  427                } else {
> f8896f5d David Weinehall 2015-06-25  428                        *n_entries
> = ARRAY_SIZE(skl_ddi_translations_edp);
> acee2998 Ville Syrjälä   2015-12-08  429                        return
> skl_ddi_translations_edp;
> f8896f5d David Weinehall 2015-06-25  430                }
> f8896f5d David Weinehall 2015-06-25  431        }
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation_______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

[-- Attachment #1.2: Type: text/html, Size: 6550 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-12 23:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-11 19:30 [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd) Julia Lawall
2017-06-12 23:58 ` Rodrigo Vivi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.