All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Ben Widawsky <benjamin.widawsky@intel.com>,
	Imre Deak <imre.deak@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/cnl: Avoid ioremap_wc on Cannonlake as well.
Date: Fri, 11 Aug 2017 17:36:47 -0700	[thread overview]
Message-ID: <CABVU7+uUYkSq-qzFjOPizYRzXaYrbY+jQk+Fi7nGT1w9gY4WCw@mail.gmail.com> (raw)
In-Reply-To: <20170811233930.32214-1-rodrigo.vivi@intel.com>

On Fri, Aug 11, 2017 at 4:39 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> WC is apparently not an option for CNL+ on GTT here.
> Trying to use it we get hard hangs.
>
> Credits-to: Ben Widawsky <benjamin.widawsky@intel.com>

forgot to CC relavant people for possible reviews:
Cc: Joonas
Cc: Imre
Cc: Ben

> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 10aa7762d9a6..3019bf509e3d 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2717,7 +2717,7 @@ static int ggtt_probe_common(struct i915_ggtt *ggtt, u64 size)
>          * resort to an uncached mapping. The WC issue is easily caught by the
>          * readback check when writing GTT PTE entries.
>          */
> -       if (IS_GEN9_LP(dev_priv))
> +       if (IS_GEN9_LP(dev_priv) || INTEL_GEN(dev_priv) >= 10)
>                 ggtt->gsm = ioremap_nocache(phys_addr, size);
>         else
>                 ggtt->gsm = ioremap_wc(phys_addr, size);
> --
> 2.13.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-12  0:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11 23:39 [PATCH] drm/i915/cnl: Avoid ioremap_wc on Cannonlake as well Rodrigo Vivi
2017-08-12  0:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-12  0:36 ` Rodrigo Vivi [this message]
2017-08-14 12:13   ` [PATCH] " Joonas Lahtinen
2017-08-14 17:24     ` Vivi, Rodrigo
2017-08-29 23:09       ` Rodrigo Vivi
2017-08-30 11:13         ` Joonas Lahtinen
2017-08-30 11:26           ` Chris Wilson
2017-08-30 11:38             ` Joonas Lahtinen
2017-08-30 17:58               ` Vivi, Rodrigo
2017-08-31  8:27                 ` Joonas Lahtinen
2017-08-31 16:45                   ` Vivi, Rodrigo
2017-08-30  0:16 ` ✓ Fi.CI.BAT: success for drm/i915/cnl: Avoid ioremap_wc on Cannonlake as well. (rev2) Patchwork
2017-08-30  4:33 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABVU7+uUYkSq-qzFjOPizYRzXaYrbY+jQk+Fi7nGT1w9gY4WCw@mail.gmail.com \
    --to=rodrigo.vivi@gmail.com \
    --cc=benjamin.widawsky@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.