[PATCH] uml: x86: add FORCE to user_constants.h

[PATCH] uml: x86: add FORCE to user_constants.h

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

The build system has started warning when filechk is called
without FORCE:

arch/x86/um/Makefile:44: FORCE prerequisite is missing

Add FORCE to make sure the file is checked/rebuilt when
necessary (and to quiet up the warning.)

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 arch/x86/um/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
index 5ccb18290d71..ba5789c35809 100644
--- a/arch/x86/um/Makefile
+++ b/arch/x86/um/Makefile
@@ -40,7 +40,7 @@ $(obj)/user-offsets.s: c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) \
 	-Iarch/x86/include/generated
 targets += user-offsets.s
 
-include/generated/user_constants.h: $(obj)/user-offsets.s
+include/generated/user_constants.h: $(obj)/user-offsets.s FORCE
 	$(call filechk,offsets,__USER_CONSTANT_H__)
 
 UNPROFILE_OBJS := stub_segv.o
-- 
2.31.1


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH] uml: x86: add FORCE to user_constants.h

[David Gow]

On Tue, Sep 28, 2021 at 5:52 PM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> From: Johannes Berg <johannes.berg@intel.com>
>
> The build system has started warning when filechk is called
> without FORCE:
>
> arch/x86/um/Makefile:44: FORCE prerequisite is missing
>
> Add FORCE to make sure the file is checked/rebuilt when
> necessary (and to quiet up the warning.)
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---

Thanks -- this gets rid of the warning in KUnit builds, and the fix
makes sense to me.

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um