All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
	iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/2] dma-mapping: reject GFP_COMP for noncohernt allocaions
Date: Wed, 21 Dec 2022 11:57:03 +0500	[thread overview]
Message-ID: <CABXGCsN+oiy_P=LiUDEtOut_Aq2r+aZ5UZWETD-tj+B-b3VF4Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2212201653520.3532114@eliteleevi.tm.intel.com>

On Tue, Dec 20, 2022 at 7:58 PM Kai Vehmanen
<kai.vehmanen@linux.intel.com> wrote:
>
> Hey,
>
> On Tue, 20 Dec 2022, Christoph Hellwig wrote:
>
> > While not quite as bogus as for the dma-coherent allocations that were
> > fixed earlier, GFP_COMP for these allocations has no benefits for
> > the dma-direct case, and can't be supported at all by dma dma-iommu
>
> tested the series and this fixes the issue:
> Tested-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>
> Minor nit, typo "noncohernt allocaions" in subject of this second patch.
>
> Br, Kai

I also confirm that after applying this patch series issue was gone.

Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>

Thanks.

-- 
Best Regards,
Mike Gavrilov.

WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
	iommu@lists.linux.dev,
	 Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] dma-mapping: reject GFP_COMP for noncohernt allocaions
Date: Wed, 21 Dec 2022 11:57:03 +0500	[thread overview]
Message-ID: <CABXGCsN+oiy_P=LiUDEtOut_Aq2r+aZ5UZWETD-tj+B-b3VF4Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2212201653520.3532114@eliteleevi.tm.intel.com>

On Tue, Dec 20, 2022 at 7:58 PM Kai Vehmanen
<kai.vehmanen@linux.intel.com> wrote:
>
> Hey,
>
> On Tue, 20 Dec 2022, Christoph Hellwig wrote:
>
> > While not quite as bogus as for the dma-coherent allocations that were
> > fixed earlier, GFP_COMP for these allocations has no benefits for
> > the dma-direct case, and can't be supported at all by dma dma-iommu
>
> tested the series and this fixes the issue:
> Tested-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>
> Minor nit, typo "noncohernt allocaions" in subject of this second patch.
>
> Br, Kai

I also confirm that after applying this patch series issue was gone.

Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>

Thanks.

-- 
Best Regards,
Mike Gavrilov.

  reply	other threads:[~2022-12-21  6:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  8:20 fix GFP_COMP use in noncoherent dma allocators Christoph Hellwig
2022-12-20  8:20 ` Christoph Hellwig
2022-12-20  8:20 ` [PATCH 1/2] ALSA: memalloc: don't use GFP_COMP for non-coherent dma allocations Christoph Hellwig
2022-12-20  8:20   ` Christoph Hellwig
2022-12-20  8:20 ` [PATCH 2/2] dma-mapping: reject GFP_COMP for noncohernt allocaions Christoph Hellwig
2022-12-20  8:20   ` Christoph Hellwig
2022-12-20 14:57   ` Kai Vehmanen
2022-12-20 14:57     ` Kai Vehmanen
2022-12-21  6:57     ` Mikhail Gavrilov [this message]
2022-12-21  6:57       ` Mikhail Gavrilov
2022-12-21  7:46     ` Christoph Hellwig
2022-12-21  7:46       ` Christoph Hellwig
2022-12-20 12:27 ` fix GFP_COMP use in noncoherent dma allocators Takashi Iwai
2022-12-20 12:27   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABXGCsN+oiy_P=LiUDEtOut_Aq2r+aZ5UZWETD-tj+B-b3VF4Q@mail.gmail.com' \
    --to=mikhail.v.gavrilov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.