From: Guenter Roeck <groeck@google.com> To: Cheng-Yi Chiang <cychiang@chromium.org> Cc: linux-kernel <linux-kernel@vger.kernel.org>, Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org, Dylan Reid <dgreid@chromium.org>, tzungbi@chromium.org, Rohit kumar <rohitkr@codeaurora.org> Subject: Re: [PATCH v2 2/3] ASoC: Documentation: Add google,cros-ec-codec Date: Mon, 24 Dec 2018 06:38:33 -0800 [thread overview] Message-ID: <CABXOdTdoz-sG3t0n3kKUd0ydJmnmMsoaOJ=yQzWOtT0A8Qp2kw@mail.gmail.com> (raw) In-Reply-To: <20181224083724.75618-2-cychiang@chromium.org> On Mon, Dec 24, 2018 at 12:39 AM Cheng-Yi Chiang <cychiang@chromium.org> wrote: > > Add documentation for Chrome EC codec driver. > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> > --- > Change in v2: Fixed name of driver in MAINTAINERS. > > .../bindings/sound/google,cros-ec-codec.txt | 24 +++++++++++++++++++ Since this is a devicetree binding, it will require an Ack from a DT maintainer. You might want to check the output of scripts/get_maintainer.pl to make sure you don't miss anyone important. Guenter > MAINTAINERS | 5 ++++ > 2 files changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > > diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > new file mode 100644 > index 0000000000000..57718382b3a36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > @@ -0,0 +1,24 @@ > +* Audio codec controlled by ChromeOS EC > + > +Google's ChromeOS EC codec is a digital mic codec provided by the > +Embedded Controller (EC) and is controlled via a host-command interface. > + > +An EC codec node should only be found as a sub-node of the EC node (see > +Documentation/devicetree/bindings/mfd/cros-ec.txt). > + > +Required properties: > +- compatible: Must contain "google,cros-ec-codec" > +- #sound-dai-cells: Should be 1. The cell specifies number of DAIs. > + > +Example: > + > +cros-ec@0 { > + compatible = "google,cros-ec-spi"; > + > + ... > + > + cros_ec_codec: ec-codec { > + compatible = "google,cros-ec-codec"; > + #sound-dai-cells = <1>; > + }; > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 5b9c6af98283b..05e1922624e58 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3636,6 +3636,11 @@ S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/bleung/chrome-platform.git > F: drivers/platform/chrome/ > > +CHROMEOS EC CODEC DRIVER > +M: Cheng-Yi Chiang <cychiang@chromium.org> > +S: Maintained > +F: Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > + > CIRRUS LOGIC AUDIO CODEC DRIVERS > M: Brian Austin <brian.austin@cirrus.com> > M: Paul Handrigan <Paul.Handrigan@cirrus.com> > -- > 2.20.1.415.g653613c723-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <groeck@google.com> To: Cheng-Yi Chiang <cychiang@chromium.org> Cc: alsa-devel@alsa-project.org, tzungbi@chromium.org, Benson Leung <bleung@chromium.org>, linux-kernel <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>, Rohit kumar <rohitkr@codeaurora.org>, Guenter Roeck <groeck@chromium.org>, Dylan Reid <dgreid@chromium.org>, Lee Jones <lee.jones@linaro.org> Subject: Re: [PATCH v2 2/3] ASoC: Documentation: Add google, cros-ec-codec Date: Mon, 24 Dec 2018 06:38:33 -0800 [thread overview] Message-ID: <CABXOdTdoz-sG3t0n3kKUd0ydJmnmMsoaOJ=yQzWOtT0A8Qp2kw@mail.gmail.com> (raw) In-Reply-To: <20181224083724.75618-2-cychiang@chromium.org> On Mon, Dec 24, 2018 at 12:39 AM Cheng-Yi Chiang <cychiang@chromium.org> wrote: > > Add documentation for Chrome EC codec driver. > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> > --- > Change in v2: Fixed name of driver in MAINTAINERS. > > .../bindings/sound/google,cros-ec-codec.txt | 24 +++++++++++++++++++ Since this is a devicetree binding, it will require an Ack from a DT maintainer. You might want to check the output of scripts/get_maintainer.pl to make sure you don't miss anyone important. Guenter > MAINTAINERS | 5 ++++ > 2 files changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > > diff --git a/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > new file mode 100644 > index 0000000000000..57718382b3a36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > @@ -0,0 +1,24 @@ > +* Audio codec controlled by ChromeOS EC > + > +Google's ChromeOS EC codec is a digital mic codec provided by the > +Embedded Controller (EC) and is controlled via a host-command interface. > + > +An EC codec node should only be found as a sub-node of the EC node (see > +Documentation/devicetree/bindings/mfd/cros-ec.txt). > + > +Required properties: > +- compatible: Must contain "google,cros-ec-codec" > +- #sound-dai-cells: Should be 1. The cell specifies number of DAIs. > + > +Example: > + > +cros-ec@0 { > + compatible = "google,cros-ec-spi"; > + > + ... > + > + cros_ec_codec: ec-codec { > + compatible = "google,cros-ec-codec"; > + #sound-dai-cells = <1>; > + }; > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 5b9c6af98283b..05e1922624e58 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3636,6 +3636,11 @@ S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/bleung/chrome-platform.git > F: drivers/platform/chrome/ > > +CHROMEOS EC CODEC DRIVER > +M: Cheng-Yi Chiang <cychiang@chromium.org> > +S: Maintained > +F: Documentation/devicetree/bindings/sound/google,cros-ec-codec.txt > + > CIRRUS LOGIC AUDIO CODEC DRIVERS > M: Brian Austin <brian.austin@cirrus.com> > M: Paul Handrigan <Paul.Handrigan@cirrus.com> > -- > 2.20.1.415.g653613c723-goog >
next prev parent reply other threads:[~2018-12-24 14:38 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-24 8:37 [PATCH v2 1/3] mfd: cros_ec: Add commands to control codec Cheng-Yi Chiang 2018-12-24 8:37 ` [PATCH v2 2/3] ASoC: Documentation: Add google,cros-ec-codec Cheng-Yi Chiang 2018-12-24 14:38 ` Guenter Roeck [this message] 2018-12-24 14:38 ` [PATCH v2 2/3] ASoC: Documentation: Add google, cros-ec-codec Guenter Roeck 2018-12-26 7:17 ` [PATCH v2 2/3] ASoC: Documentation: Add google,cros-ec-codec Cheng-yi Chiang 2018-12-26 7:17 ` [PATCH v2 2/3] ASoC: Documentation: Add google, cros-ec-codec Cheng-yi Chiang 2018-12-24 8:37 ` [PATCH v2 3/3] ASoC: cros_ec_codec: Add codec driver for Cros EC Cheng-Yi Chiang 2018-12-24 14:48 ` Guenter Roeck 2018-12-24 14:48 ` Guenter Roeck 2018-12-26 7:15 ` Cheng-yi Chiang 2018-12-26 7:15 ` Cheng-yi Chiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABXOdTdoz-sG3t0n3kKUd0ydJmnmMsoaOJ=yQzWOtT0A8Qp2kw@mail.gmail.com' \ --to=groeck@google.com \ --cc=alsa-devel@alsa-project.org \ --cc=bleung@chromium.org \ --cc=broonie@kernel.org \ --cc=cychiang@chromium.org \ --cc=dgreid@chromium.org \ --cc=groeck@chromium.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rohitkr@codeaurora.org \ --cc=tzungbi@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.