All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeffrey Vander Stoep <jeffv@google.com>
To: Paul Moore <paul@paul-moore.com>
Cc: LSM List <linux-security-module@vger.kernel.org>,
	SElinux list <selinux@vger.kernel.org>,
	Casey Schaufler <casey@schaufler-ca.com>,
	John Johansen <john.johansen@canonical.com>,
	linux-audit@redhat.com, James Morris <jmorris@namei.org>
Subject: Re: [RFC PATCH 1/4] lsm: separate security_task_getsecid() into subjective and objective variants
Date: Wed, 10 Mar 2021 09:21:10 +0100	[thread overview]
Message-ID: <CABXk95AodFLLH+ay7tF8fUhScBAMUPjbABr3CdK=M50hB0z4sA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQzNN=_iq_9xLs6k92__bY1WL+8oFqh7kHTY5iRc7xK7Q@mail.gmail.com>

On Fri, Mar 5, 2021 at 12:44 AM Paul Moore <paul@paul-moore.com> wrote:
>
> On Thu, Mar 4, 2021 at 5:04 AM Jeffrey Vander Stoep <jeffv@google.com> wrote:
> > On Sat, Feb 20, 2021 at 3:45 PM Paul Moore <paul@paul-moore.com> wrote:
> > > On Fri, Feb 19, 2021 at 9:57 PM James Morris <jmorris@namei.org> wrote:
> > > > On Fri, 19 Feb 2021, Paul Moore wrote:
> > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > > > > index c119736ca56ac..39d501261108d 100644
> > > > > --- a/drivers/android/binder.c
> > > > > +++ b/drivers/android/binder.c
> > > > > @@ -2700,7 +2700,7 @@ static void binder_transaction(struct binder_proc *proc,
> > > > >               u32 secid;
> > > > >               size_t added_size;
> > > > >
> > > > > -             security_task_getsecid(proc->tsk, &secid);
> > > > > +             security_task_getsecid_subj(proc->tsk, &secid);
> > > > >               ret = security_secid_to_secctx(secid, &secctx, &secctx_sz);
> > > > >               if (ret) {
> > > > >                       return_error = BR_FAILED_REPLY;
> > > >
> > > > Can someone from the Android project confirm this is correct for binder?
> >
> > This looks correct to me.
>
> Thanks for the verification.  Should I assume the SELinux specific
> binder changes looked okay too?
>
Yes, those also look good to me.
> https://lore.kernel.org/selinux/84053ed8-4778-f246-2177-cf5c1b9516a9@canonical.com/T/#m4ae49d4a5a62d600fa3f3b1a5bba2d6611b1051c
>
> --
> paul moore
> www.paul-moore.com

WARNING: multiple messages have this Message-ID (diff)
From: Jeffrey Vander Stoep <jeffv@google.com>
To: Paul Moore <paul@paul-moore.com>
Cc: John Johansen <john.johansen@canonical.com>,
	SElinux list <selinux@vger.kernel.org>,
	James Morris <jmorris@namei.org>,
	LSM List <linux-security-module@vger.kernel.org>,
	linux-audit@redhat.com
Subject: Re: [RFC PATCH 1/4] lsm: separate security_task_getsecid() into subjective and objective variants
Date: Wed, 10 Mar 2021 09:21:10 +0100	[thread overview]
Message-ID: <CABXk95AodFLLH+ay7tF8fUhScBAMUPjbABr3CdK=M50hB0z4sA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQzNN=_iq_9xLs6k92__bY1WL+8oFqh7kHTY5iRc7xK7Q@mail.gmail.com>

On Fri, Mar 5, 2021 at 12:44 AM Paul Moore <paul@paul-moore.com> wrote:
>
> On Thu, Mar 4, 2021 at 5:04 AM Jeffrey Vander Stoep <jeffv@google.com> wrote:
> > On Sat, Feb 20, 2021 at 3:45 PM Paul Moore <paul@paul-moore.com> wrote:
> > > On Fri, Feb 19, 2021 at 9:57 PM James Morris <jmorris@namei.org> wrote:
> > > > On Fri, 19 Feb 2021, Paul Moore wrote:
> > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > > > > index c119736ca56ac..39d501261108d 100644
> > > > > --- a/drivers/android/binder.c
> > > > > +++ b/drivers/android/binder.c
> > > > > @@ -2700,7 +2700,7 @@ static void binder_transaction(struct binder_proc *proc,
> > > > >               u32 secid;
> > > > >               size_t added_size;
> > > > >
> > > > > -             security_task_getsecid(proc->tsk, &secid);
> > > > > +             security_task_getsecid_subj(proc->tsk, &secid);
> > > > >               ret = security_secid_to_secctx(secid, &secctx, &secctx_sz);
> > > > >               if (ret) {
> > > > >                       return_error = BR_FAILED_REPLY;
> > > >
> > > > Can someone from the Android project confirm this is correct for binder?
> >
> > This looks correct to me.
>
> Thanks for the verification.  Should I assume the SELinux specific
> binder changes looked okay too?
>
Yes, those also look good to me.
> https://lore.kernel.org/selinux/84053ed8-4778-f246-2177-cf5c1b9516a9@canonical.com/T/#m4ae49d4a5a62d600fa3f3b1a5bba2d6611b1051c
>
> --
> paul moore
> www.paul-moore.com

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  reply	other threads:[~2021-03-10  8:22 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 23:28 [RFC PATCH 0/4] Split security_task_getsecid() into subj and obj variants Paul Moore
2021-02-19 23:28 ` Paul Moore
2021-02-19 23:29 ` [RFC PATCH 1/4] lsm: separate security_task_getsecid() into subjective and objective variants Paul Moore
2021-02-19 23:29   ` Paul Moore
2021-02-20  2:55   ` James Morris
2021-02-20  2:55     ` James Morris
2021-02-20 14:44     ` Paul Moore
2021-02-20 14:44       ` Paul Moore
2021-03-04 10:04       ` Jeffrey Vander Stoep
2021-03-04 10:04         ` Jeffrey Vander Stoep
2021-03-04 23:43         ` Paul Moore
2021-03-04 23:43           ` Paul Moore
2021-03-10  8:21           ` Jeffrey Vander Stoep [this message]
2021-03-10  8:21             ` Jeffrey Vander Stoep
2021-03-11  1:56             ` Paul Moore
2021-03-11  1:56               ` Paul Moore
2021-02-21 12:51   ` John Johansen
2021-02-21 12:51     ` John Johansen
2021-02-21 22:09     ` Paul Moore
2021-02-21 22:09       ` Paul Moore
2021-03-04  0:44     ` Paul Moore
2021-03-04  0:44       ` Paul Moore
2021-03-10  0:28       ` Paul Moore
2021-03-10  0:28         ` Paul Moore
2021-03-10  3:09         ` John Johansen
2021-03-10  3:09           ` John Johansen
2021-02-24 16:49   ` Mimi Zohar
2021-02-24 16:49     ` Mimi Zohar
2021-03-08 19:25   ` Richard Guy Briggs
2021-03-08 19:25     ` Richard Guy Briggs
2021-03-10  0:23     ` Paul Moore
2021-03-10  0:23       ` Paul Moore
2021-03-10  1:03   ` John Johansen
2021-03-10  1:03     ` John Johansen
2021-03-11  1:55     ` Paul Moore
2021-03-11  1:55       ` Paul Moore
2021-02-19 23:29 ` [RFC PATCH 2/4] selinux: clarify task subjective and objective credentials Paul Moore
2021-02-19 23:29   ` Paul Moore
2021-02-21 12:55   ` John Johansen
2021-02-21 12:55     ` John Johansen
2021-03-08 19:26   ` Richard Guy Briggs
2021-03-08 19:26     ` Richard Guy Briggs
2021-03-10  3:05   ` John Johansen
2021-03-10  3:05     ` John Johansen
2021-03-11  4:32     ` Paul Moore
2021-03-11  4:32       ` Paul Moore
2021-03-17 22:56       ` Paul Moore
2021-03-17 22:56         ` Paul Moore
2021-02-19 23:29 ` [RFC PATCH 3/4] smack: differentiate between subjective and objective task credentials Paul Moore
2021-02-19 23:29   ` Paul Moore
2021-02-21 12:56   ` John Johansen
2021-02-21 12:56     ` John Johansen
2021-03-08 19:26   ` Richard Guy Briggs
2021-03-08 19:26     ` Richard Guy Briggs
2021-03-10  1:04   ` John Johansen
2021-03-10  1:04     ` John Johansen
2021-02-19 23:29 ` [RFC PATCH 4/4] apparmor: " Paul Moore
2021-02-19 23:29   ` Paul Moore
2021-02-21 12:57   ` John Johansen
2021-02-21 12:57     ` John Johansen
2021-02-21 22:12     ` Paul Moore
2021-02-21 22:12       ` Paul Moore
2021-02-20  1:49 ` [RFC PATCH 0/4] Split security_task_getsecid() into subj and obj variants Casey Schaufler
2021-02-20  1:49   ` Casey Schaufler
2021-02-20 14:41   ` Paul Moore
2021-02-20 14:41     ` Paul Moore
2021-02-22 23:58     ` Casey Schaufler
2021-02-22 23:58       ` Casey Schaufler
2021-02-23 14:14       ` Mimi Zohar
2021-02-23 14:14         ` Mimi Zohar
2021-02-24  0:03         ` Paul Moore
2021-02-24  0:03           ` Paul Moore
2021-03-04  0:46       ` Paul Moore
2021-03-04  0:46         ` Paul Moore
2021-03-04  2:21         ` Casey Schaufler
2021-03-04  2:21           ` Casey Schaufler
2021-03-04 23:41           ` Paul Moore
2021-03-04 23:41             ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABXk95AodFLLH+ay7tF8fUhScBAMUPjbABr3CdK=M50hB0z4sA@mail.gmail.com' \
    --to=jeffv@google.com \
    --cc=casey@schaufler-ca.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.