[PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Samuli Piippo]

This reverts commit cdd86896c8d29135f937968e9aa07f919cf543d3.

real-ld is always used if that is found, which means you cannot
switch between bfd and gold linkers using -fuse-ld gcc option.

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
 meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
index 878feaf810..e8fbb6186b 100644
--- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
@@ -131,8 +131,6 @@ do_install () {
 
 		ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
 	done
-	t=real-ld
-	ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
 
 	# libquadmath headers need to  be available in the gcc libexec dir
 	install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
-- 
2.25.1

Re: [OE-core] [PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Richard Purdie]

On Fri, 2021-05-21 at 17:33 +0300, Samuli Piippo wrote:
> This reverts commit cdd86896c8d29135f937968e9aa07f919cf543d3.
> 
> real-ld is always used if that is found, which means you cannot
> switch between bfd and gold linkers using -fuse-ld gcc option.
> 
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> ---
>  meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> index 878feaf810..e8fbb6186b 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> @@ -131,8 +131,6 @@ do_install () {
>  
> 
> 
> 
>  		ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix $dest$t$suffix
>  	done
> -	t=real-ld
> -	ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
>  
> 
> 
> 
>  	# libquadmath headers need to  be available in the gcc libexec dir
>  	install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/

It seems the issue that commit fixed back in 2015 is still there if 
we revert this:

https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/3490/steps/26/logs/stdio

Cheers,

Richard

Re: [OE-core] [PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Samuli Piippo]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Was the "gcc-cross-canadian: add symlinks for ld.bfd and ld.gold" change
included in that test build?


On Sat, 22 May 2021 at 08:41, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2021-05-21 at 17:33 +0300, Samuli Piippo wrote:
> > This reverts commit cdd86896c8d29135f937968e9aa07f919cf543d3.
> >
> > real-ld is always used if that is found, which means you cannot
> > switch between bfd and gold linkers using -fuse-ld gcc option.
> >
> > Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> > ---
> >  meta/recipes-devtools/gcc/gcc-cross-canadian.inc | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > index 878feaf810..e8fbb6186b 100644
> > --- a/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-cross-canadian.inc
> > @@ -131,8 +131,6 @@ do_install () {
> >
> >
> >
> >
> >               ln -sf ${BINRELPATH}/${TARGET_PREFIX}$t$suffix
> $dest$t$suffix
> >       done
> > -     t=real-ld
> > -     ln -sf ${BINRELPATH}/${TARGET_PREFIX}ld$suffix $dest$t$suffix
> >
> >
> >
> >
> >       # libquadmath headers need to  be available in the gcc libexec dir
> >       install -d ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/include/
>
> It seems the issue that commit fixed back in 2015 is still there if
> we revert this:
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/3490/steps/26/logs/stdio
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 2294 bytes --]

Re: [OE-core] [PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Richard Purdie]

On Wed, 2021-05-26 at 12:23 +0300, Samuli Piippo wrote:
> Was the "gcc-cross-canadian: add symlinks for ld.bfd and ld.gold" change 
> included in that test build?

Yes, it was.

Cheers,

Richard

Re: [OE-core] [PATCH v3] Revert "gcc-cross-canadian: Add symlink to real-ld alongside other symlinks"

[Samuli Piippo]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

Tested this locally and gcc is trying to find the linker with the multilib
prefix, but that's not available in SDK.
[pid  3784] newfstatat(AT_FDCWD,
"/home/sapiippo/build/toolchain/sysroots/x86_64-pokysdk-linux/usr/libexec/mips-poky-linux/gcc/mips-poky-linux/11.1.0/mips-pokymllib32-linux-ld",
0x7ffe380d44a0, 0) = -1 ENOENT (No such file or directory)

The same works on bitbake builds, where lib32-gcc-cross-mips add the
symlink:
mips-pokymllib32-linux-ld ->
../../../../../bin/mips-pokymllib32-linux/mips-pokymllib32-linux-ld
(even though the binary is built in lib32-binutils-cross-mips)

So, the cross-canadian builds are missing all the multilib links in libexec
that are available in cross builds.

-samuli

On Wed, 26 May 2021 at 12:44, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Wed, 2021-05-26 at 12:23 +0300, Samuli Piippo wrote:
> > Was the "gcc-cross-canadian: add symlinks for ld.bfd and ld.gold" change
> > included in that test build?
>
> Yes, it was.
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 1527 bytes --]