All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix __clzsi2 logic
@ 2022-09-29 22:00 Tuan Phan
  2022-10-03 15:26 ` Daniel Kiper
  0 siblings, 1 reply; 7+ messages in thread
From: Tuan Phan @ 2022-09-29 22:00 UTC (permalink / raw)
  Cc: grub-devel, Tuan Phan

Fix the incorrect return value of __clzsi2 function.

Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
---
 grub-core/kern/compiler-rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c
index 2057c2e0c..55ae9f97e 100644
--- a/grub-core/kern/compiler-rt.c
+++ b/grub-core/kern/compiler-rt.c
@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
 
   for (; j; j >>= 1)
     {
-      if ((temp = val) >> j)
+      if ((temp = (val >> j)))
         {
           if (j == 1)
             {
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] Fix __clzsi2 logic
  2022-09-29 22:00 [PATCH] Fix __clzsi2 logic Tuan Phan
@ 2022-10-03 15:26 ` Daniel Kiper
  2022-10-03 18:06   ` Tuan Phan
  2022-10-03 18:29   ` [PATCH v2] " Tuan Phan
  0 siblings, 2 replies; 7+ messages in thread
From: Daniel Kiper @ 2022-10-03 15:26 UTC (permalink / raw)
  To: Tuan Phan; +Cc: grub-devel

On Thu, Sep 29, 2022 at 03:00:26PM -0700, Tuan Phan wrote:
> Fix the incorrect return value of __clzsi2 function.
>
> Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> but...

> ---
>  grub-core/kern/compiler-rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c
> index 2057c2e0c..55ae9f97e 100644
> --- a/grub-core/kern/compiler-rt.c
> +++ b/grub-core/kern/compiler-rt.c
> @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
>
>    for (; j; j >>= 1)
>      {
> -      if ((temp = val) >> j)
> +      if ((temp = (val >> j)))

... I will drop redundant brackets from here to be in line with things
in the libgcc...

Daniel


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] Fix __clzsi2 logic
  2022-10-03 15:26 ` Daniel Kiper
@ 2022-10-03 18:06   ` Tuan Phan
  2022-10-03 18:29   ` [PATCH v2] " Tuan Phan
  1 sibling, 0 replies; 7+ messages in thread
From: Tuan Phan @ 2022-10-03 18:06 UTC (permalink / raw)
  To: Daniel Kiper; +Cc: grub-devel

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Mon, Oct 3, 2022 at 8:26 AM Daniel Kiper <dkiper@net-space.pl> wrote:

> On Thu, Sep 29, 2022 at 03:00:26PM -0700, Tuan Phan wrote:
> > Fix the incorrect return value of __clzsi2 function.
> >
> > Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
> > Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> but...
>
> > ---
> >  grub-core/kern/compiler-rt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c
> > index 2057c2e0c..55ae9f97e 100644
> > --- a/grub-core/kern/compiler-rt.c
> > +++ b/grub-core/kern/compiler-rt.c
> > @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
> >
> >    for (; j; j >>= 1)
> >      {
> > -      if ((temp = val) >> j)
> > +      if ((temp = (val >> j)))
>
> ... I will drop redundant brackets from here to be in line with things
> in the libgcc...
>
> Daniel
>

Thanks for the review, I will drop the redundant brackets.

[-- Attachment #2: Type: text/html, Size: 1594 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] Fix __clzsi2 logic
  2022-10-03 15:26 ` Daniel Kiper
  2022-10-03 18:06   ` Tuan Phan
@ 2022-10-03 18:29   ` Tuan Phan
  2022-10-10 16:43     ` Tuan Phan
  1 sibling, 1 reply; 7+ messages in thread
From: Tuan Phan @ 2022-10-03 18:29 UTC (permalink / raw)
  Cc: grub-devel, Tuan Phan, Daniel Kiper

Fix the incorrect return value of __clzsi2 function.

Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---
V2: Drop redundant brackets
Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
---
 grub-core/kern/compiler-rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c
index 2057c2e0c..738bb8420 100644
--- a/grub-core/kern/compiler-rt.c
+++ b/grub-core/kern/compiler-rt.c
@@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
 
   for (; j; j >>= 1)
     {
-      if ((temp = val) >> j)
+      if (temp = (val >> j))
         {
           if (j == 1)
             {
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix __clzsi2 logic
  2022-10-03 18:29   ` [PATCH v2] " Tuan Phan
@ 2022-10-10 16:43     ` Tuan Phan
  2022-10-10 20:29       ` Daniel Kiper
  0 siblings, 1 reply; 7+ messages in thread
From: Tuan Phan @ 2022-10-10 16:43 UTC (permalink / raw)
  Cc: grub-devel, Daniel Kiper

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <tphan@ventanamicro.com> wrote:

> Fix the incorrect return value of __clzsi2 function.
>
> Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> V2: Drop redundant brackets
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---
>  grub-core/kern/compiler-rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-rt.c
> index 2057c2e0c..738bb8420 100644
> --- a/grub-core/kern/compiler-rt.c
> +++ b/grub-core/kern/compiler-rt.c
> @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
>
>    for (; j; j >>= 1)
>      {
> -      if ((temp = val) >> j)
> +      if (temp = (val >> j))
>          {
>            if (j == 1)
>              {
> --
> 2.25.1
>
>
Hi Daniel,
Any chances that this patch will be merged soon?

Thanks,

[-- Attachment #2: Type: text/html, Size: 1620 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix __clzsi2 logic
  2022-10-10 16:43     ` Tuan Phan
@ 2022-10-10 20:29       ` Daniel Kiper
  2022-10-10 21:44         ` Tuan Phan
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Kiper @ 2022-10-10 20:29 UTC (permalink / raw)
  To: Tuan Phan; +Cc: grub-devel

On Mon, Oct 10, 2022 at 09:43:20AM -0700, Tuan Phan wrote:
> On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <tphan@ventanamicro.com> wrote:
>      Fix the incorrect return value of __clzsi2 function.
>
>      Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
>      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
>      Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>      ---
>      V2: Drop redundant brackets
>      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
>      ---
>       grub-core/kern/compiler-rt.c | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
>
>      diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-
>      rt.c
>      index 2057c2e0c..738bb8420 100644
>      --- a/grub-core/kern/compiler-rt.c
>      +++ b/grub-core/kern/compiler-rt.c
>      @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
>
>         for (; j; j >>= 1)
>           {
>      -      if ((temp = val) >> j)
>      +      if (temp = (val >> j))
>               {
>                 if (j == 1)
>                   {
>      --
>      2.25.1
>
> Hi Daniel,
> Any chances that this patch will be merged soon? 

It has been merged together with other patches last week.

Daniel


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix __clzsi2 logic
  2022-10-10 20:29       ` Daniel Kiper
@ 2022-10-10 21:44         ` Tuan Phan
  0 siblings, 0 replies; 7+ messages in thread
From: Tuan Phan @ 2022-10-10 21:44 UTC (permalink / raw)
  To: Daniel Kiper; +Cc: grub-devel

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Mon, Oct 10, 2022 at 1:46 PM Daniel Kiper <dkiper@net-space.pl> wrote:

> On Mon, Oct 10, 2022 at 09:43:20AM -0700, Tuan Phan wrote:
> > On Mon, Oct 3, 2022 at 11:30 AM Tuan Phan <tphan@ventanamicro.com>
> wrote:
> >      Fix the incorrect return value of __clzsi2 function.
> >
> >      Fixes: e795b90 ("RISC-V: Add libgcc helpers for clz")
> >      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> >      Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >      ---
> >      V2: Drop redundant brackets
> >      Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> >      ---
> >       grub-core/kern/compiler-rt.c | 2 +-
> >       1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >      diff --git a/grub-core/kern/compiler-rt.c b/grub-core/kern/compiler-
> >      rt.c
> >      index 2057c2e0c..738bb8420 100644
> >      --- a/grub-core/kern/compiler-rt.c
> >      +++ b/grub-core/kern/compiler-rt.c
> >      @@ -431,7 +431,7 @@ __clzsi2 (grub_uint32_t val)
> >
> >         for (; j; j >>= 1)
> >           {
> >      -      if ((temp = val) >> j)
> >      +      if (temp = (val >> j))
> >               {
> >                 if (j == 1)
> >                   {
> >      --
> >      2.25.1
> >
> > Hi Daniel,
> > Any chances that this patch will be merged soon?
>
> It has been merged together with other patches last week.
>
> Daniel
>
Awesome, thanks!

[-- Attachment #2: Type: text/html, Size: 2245 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-10 21:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 22:00 [PATCH] Fix __clzsi2 logic Tuan Phan
2022-10-03 15:26 ` Daniel Kiper
2022-10-03 18:06   ` Tuan Phan
2022-10-03 18:29   ` [PATCH v2] " Tuan Phan
2022-10-10 16:43     ` Tuan Phan
2022-10-10 20:29       ` Daniel Kiper
2022-10-10 21:44         ` Tuan Phan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.