From: Jassi Brar <jassisinghbrar@gmail.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox
Date: Wed, 18 Sep 2019 08:34:41 -0500 [thread overview]
Message-ID: <CABb+yY09pPqM-47zNFVGMNM9wrDF9iiVuqKTXrEd4-PdOxBPrQ@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB44811AE46803D10FD8A5B8B0888E0@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Wed, Sep 18, 2019 at 3:53 AM Peng Fan <peng.fan@nxp.com> wrote:
> > >
> > > > +
> > > > + "#mbox-cells":
> > > > + const: 1
> > >
> > > Why is this "1"? What is this number used for? It used to be the channel ID,
> > but since you are describing a single channel controller only, this should be 0
> > now.
> > >
> > Yes. I overlooked it and actually queued the patch for pull request.
>
> In Documentation/devicetree/bindings/mailbox/mailbox.txt
> #mbox-cells: Must be at least 1.
>
> So I use 1 here, 0 not work. Because of_mbox_index_xlate expect at least 1 here.
> So I need modify Documentation/devicetree/bindings/mailbox/mailbox.txt
> and add xlate for smc mailbox?
>
No, you just can not use the generic xlate() provided by the api.
Please implement your own xlate() that requires no argument.
Cheers!
WARNING: multiple messages have this Message-ID (diff)
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
Andre Przywara <andre.przywara@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox
Date: Wed, 18 Sep 2019 08:34:41 -0500 [thread overview]
Message-ID: <CABb+yY09pPqM-47zNFVGMNM9wrDF9iiVuqKTXrEd4-PdOxBPrQ@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB44811AE46803D10FD8A5B8B0888E0@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Wed, Sep 18, 2019 at 3:53 AM Peng Fan <peng.fan@nxp.com> wrote:
> > >
> > > > +
> > > > + "#mbox-cells":
> > > > + const: 1
> > >
> > > Why is this "1"? What is this number used for? It used to be the channel ID,
> > but since you are describing a single channel controller only, this should be 0
> > now.
> > >
> > Yes. I overlooked it and actually queued the patch for pull request.
>
> In Documentation/devicetree/bindings/mailbox/mailbox.txt
> #mbox-cells: Must be at least 1.
>
> So I use 1 here, 0 not work. Because of_mbox_index_xlate expect at least 1 here.
> So I need modify Documentation/devicetree/bindings/mailbox/mailbox.txt
> and add xlate for smc mailbox?
>
No, you just can not use the generic xlate() provided by the api.
Please implement your own xlate() that requires no argument.
Cheers!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-18 13:34 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 9:44 [PATCH V6 0/2] mailbox: arm: introduce smc triggered mailbox Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-16 9:44 ` [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-17 17:31 ` Andre Przywara
2019-09-17 17:31 ` Andre Przywara
2019-09-17 17:31 ` Andre Przywara
2019-09-18 5:27 ` Jassi Brar
2019-09-18 5:27 ` Jassi Brar
2019-09-18 5:27 ` Jassi Brar
2019-09-18 8:53 ` Peng Fan
2019-09-18 8:53 ` Peng Fan
2019-09-18 8:53 ` Peng Fan
2019-09-18 13:34 ` Jassi Brar [this message]
2019-09-18 13:34 ` Jassi Brar
2019-09-18 13:34 ` Jassi Brar
2019-09-18 13:51 ` Peng Fan
2019-09-18 13:51 ` Peng Fan
2019-09-18 13:51 ` Peng Fan
2019-09-18 9:43 ` Andre Przywara
2019-09-18 9:43 ` Andre Przywara
2019-09-18 9:43 ` Andre Przywara
2019-09-18 14:19 ` Jassi Brar
2019-09-18 14:19 ` Jassi Brar
2019-09-18 14:19 ` Jassi Brar
2019-09-18 14:46 ` Andre Przywara
2019-09-18 14:46 ` Andre Przywara
2019-09-18 14:46 ` Andre Przywara
2019-09-18 15:31 ` Jassi Brar
2019-09-18 15:31 ` Jassi Brar
2019-09-18 15:31 ` Jassi Brar
2019-09-18 17:06 ` Andre Przywara
2019-09-18 17:06 ` Andre Przywara
2019-09-18 17:06 ` Andre Przywara
2019-09-18 9:02 ` Peng Fan
2019-09-18 9:02 ` Peng Fan
2019-09-18 9:02 ` Peng Fan
2019-09-16 9:44 ` [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-16 9:44 ` Peng Fan
2019-09-17 17:38 ` Andre Przywara
2019-09-17 17:38 ` Andre Przywara
2019-09-17 17:38 ` Andre Przywara
2019-09-18 9:09 ` Peng Fan
2019-09-18 9:09 ` Peng Fan
2019-09-18 9:09 ` Peng Fan
2019-09-18 10:00 ` Andre Przywara
2019-09-18 10:00 ` Andre Przywara
2019-09-18 10:00 ` Andre Przywara
2019-09-18 13:31 ` Jassi Brar
2019-09-18 13:31 ` Jassi Brar
2019-09-18 13:31 ` Jassi Brar
2019-09-18 13:58 ` Andre Przywara
2019-09-18 13:58 ` Andre Przywara
2019-09-18 13:58 ` Andre Przywara
2019-09-18 14:22 ` Jassi Brar
2019-09-18 14:22 ` Jassi Brar
2019-09-18 14:22 ` Jassi Brar
2019-09-19 5:36 ` Peng Fan
2019-09-19 5:36 ` Peng Fan
2019-09-19 5:36 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY09pPqM-47zNFVGMNM9wrDF9iiVuqKTXrEd4-PdOxBPrQ@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.