From: Jassi Brar <jassisinghbrar@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Felipe Balbi <balbi@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout
Date: Mon, 29 Aug 2011 19:52:09 +0530 [thread overview]
Message-ID: <CABb+yY1aQtN2fHKDk9a1MoAra40PSg3kotUJMhGJt8sb7EqTgA@mail.gmail.com> (raw)
In-Reply-To: <4E5B9CB0.4090708@ladisch.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1087 bytes --]
On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@ladisch.de> wrote:
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= val_len) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= 0) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â value, index + 2, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â jacks[i].unitid << 8, buf, 3, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â 50, 0, &new_status, 1, 1000);
>>
>> How about also converting to use a local define for timeout value ?
>
> ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> we could just as well drop this parameter.
Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: Jassi Brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Clemens Ladisch <clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux USB Mailing List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout
Date: Mon, 29 Aug 2011 19:52:09 +0530 [thread overview]
Message-ID: <CABb+yY1aQtN2fHKDk9a1MoAra40PSg3kotUJMhGJt8sb7EqTgA@mail.gmail.com> (raw)
In-Reply-To: <4E5B9CB0.4090708-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1059 bytes --]
On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@ladisch.de> wrote:
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= val_len) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= 0) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â value, index + 2, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â jacks[i].unitid << 8, buf, 3, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â 50, 0, &new_status, 1, 1000);
>>
>> How about also converting to use a local define for timeout value ?
>
> ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> we could just as well drop this parameter.
Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±ºÆâžØ^n‡r¡ö¦zË\x1aëh™¨èÚ&¢îý»\x05ËÛÔØï¦v¬Îf\x1dp)¹¹br šê+€Ê+zf£¢·hšˆ§~††Ûiÿûàz¹\x1e®w¥¢¸?™¨èÚ&¢)ߢ^[f
next prev parent reply other threads:[~2011-08-29 14:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 11:10 [PATCH] sound: usb: mixer: increase control transfer timeout Felipe Balbi
2011-08-29 11:10 ` Felipe Balbi
2011-08-29 11:16 ` Sebastian Andrzej Siewior
2011-08-29 11:16 ` Sebastian Andrzej Siewior
2011-08-29 11:19 ` Felipe Balbi
2011-08-29 11:19 ` Felipe Balbi
2011-08-29 11:58 ` Clemens Ladisch
2011-08-29 11:58 ` Clemens Ladisch
2011-08-29 12:23 ` Felipe Balbi
2011-08-29 12:23 ` Felipe Balbi
2011-08-29 12:31 ` [PATCH v2] " Felipe Balbi
2011-08-29 12:37 ` Jassi Brar
2011-08-29 12:37 ` Jassi Brar
2011-08-29 13:00 ` Felipe Balbi
2011-08-29 13:00 ` Felipe Balbi
2011-08-29 13:34 ` Jassi Brar
2011-08-29 13:34 ` Jassi Brar
2011-08-29 14:05 ` Clemens Ladisch
2011-08-29 14:05 ` Clemens Ladisch
2011-08-29 14:22 ` Jassi Brar [this message]
2011-08-29 14:22 ` Jassi Brar
2011-09-12 10:57 ` Takashi Iwai
2011-09-12 10:57 ` Takashi Iwai
2011-09-16 6:25 ` [PATCH] " Takashi Iwai
2011-09-16 6:25 ` Takashi Iwai
2011-09-26 8:49 ` Felipe Balbi
2011-09-27 6:52 ` Clemens Ladisch
2011-09-27 6:52 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY1aQtN2fHKDk9a1MoAra40PSg3kotUJMhGJt8sb7EqTgA@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=balbi@ti.com \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.