From: Jassi Brar <jassisinghbrar@gmail.com> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>, Bjorn Andersson <bjorn.andersson@linaro.org> Subject: Re: [PATCH] mailbox: add support for doorbell/signal mode controllers Date: Wed, 1 Nov 2017 23:33:34 +0530 [thread overview] Message-ID: <CABb+yY1tcm-68E5oG75hstuMd6AOeb=BB6HeKGnQ1zj4Qya6hg@mail.gmail.com> (raw) In-Reply-To: <1509553964-4451-1-git-send-email-sudeep.holla@arm.com> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prepare callback. > Controller doesn't need any data to be passed from the client. > Some controllers need a non-zero value written to a register in order to trigger the signal. That register is visible to the remote. While the data/packet is setup during tx_prepare() callback. You are overlooking this class of doorbell controllers. > > This is rough idea I have on extending mailbox interface to support > the doorbell requirements. > What doorbell requirements does the api not support? QComm's APCS IPC is what you call a "doorbell" controller and is already supported by the API. It could run SCMI even easier than MHU (your controller). > The new API send_signal will eliminate the > issue Jassi has explained in earlier discussion with respect to generic > message format using Rockchip example. > Sorry I don't see how. Please explain how can send_signal() api be used by, say, rockchip to support SCMI? I am not convinced we should clone an api just so that a client driver becomes simpler. Esp when it shifts, and not avoid, the additional code (to support the client) onto the provider side. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] mailbox: add support for doorbell/signal mode controllers Date: Wed, 1 Nov 2017 23:33:34 +0530 [thread overview] Message-ID: <CABb+yY1tcm-68E5oG75hstuMd6AOeb=BB6HeKGnQ1zj4Qya6hg@mail.gmail.com> (raw) In-Reply-To: <1509553964-4451-1-git-send-email-sudeep.holla@arm.com> On Wed, Nov 1, 2017 at 10:02 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > Such controllers don't need to transmit any data, they just transmit > the signal. In such controllers the data pointer passed to > mbox_send_message is passed to client via it's tx_prepare callback. > Controller doesn't need any data to be passed from the client. > Some controllers need a non-zero value written to a register in order to trigger the signal. That register is visible to the remote. While the data/packet is setup during tx_prepare() callback. You are overlooking this class of doorbell controllers. > > This is rough idea I have on extending mailbox interface to support > the doorbell requirements. > What doorbell requirements does the api not support? QComm's APCS IPC is what you call a "doorbell" controller and is already supported by the API. It could run SCMI even easier than MHU (your controller). > The new API send_signal will eliminate the > issue Jassi has explained in earlier discussion with respect to generic > message format using Rockchip example. > Sorry I don't see how. Please explain how can send_signal() api be used by, say, rockchip to support SCMI? I am not convinced we should clone an api just so that a client driver becomes simpler. Esp when it shifts, and not avoid, the additional code (to support the client) onto the provider side. Thanks.
next prev parent reply other threads:[~2017-11-01 18:03 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-01 16:32 [PATCH] mailbox: add support for doorbell/signal mode controllers Sudeep Holla 2017-11-01 16:32 ` Sudeep Holla 2017-11-01 18:03 ` Jassi Brar [this message] 2017-11-01 18:03 ` Jassi Brar 2017-11-01 18:15 ` Sudeep Holla 2017-11-01 18:15 ` Sudeep Holla 2017-11-01 22:17 ` Bjorn Andersson 2017-11-01 22:17 ` Bjorn Andersson 2017-11-02 3:02 ` Jassi Brar 2017-11-02 3:02 ` Jassi Brar 2017-11-02 3:27 ` Bjorn Andersson 2017-11-02 3:27 ` Bjorn Andersson 2017-11-02 4:48 ` Jassi Brar 2017-11-02 4:48 ` Jassi Brar 2017-11-02 2:39 ` Jassi Brar 2017-11-02 2:39 ` Jassi Brar 2017-11-02 10:47 ` Sudeep Holla 2017-11-02 10:47 ` Sudeep Holla 2017-11-02 11:26 ` Jassi Brar 2017-11-02 11:26 ` Jassi Brar 2017-11-02 11:49 ` Sudeep Holla 2017-11-02 11:49 ` Sudeep Holla 2017-11-02 12:21 ` Jassi Brar 2017-11-02 12:21 ` Jassi Brar 2017-11-02 12:37 ` Sudeep Holla 2017-11-02 12:37 ` Sudeep Holla 2017-11-02 14:52 ` Jassi Brar 2017-11-02 14:52 ` Jassi Brar 2017-11-01 22:12 ` Bjorn Andersson 2017-11-01 22:12 ` Bjorn Andersson 2017-11-02 2:56 ` Jassi Brar 2017-11-02 2:56 ` Jassi Brar 2017-11-02 10:51 ` Sudeep Holla 2017-11-02 10:51 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABb+yY1tcm-68E5oG75hstuMd6AOeb=BB6HeKGnQ1zj4Qya6hg@mail.gmail.com' \ --to=jassisinghbrar@gmail.com \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.