soc: mediatek: cmdq: add address shift in jump

All of lore.kernel.org
 help / color / mirror / Atom feed

* soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34 ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: David Airlie, Daniel Vetter, Mark Rutland, dri-devel, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, Yongqiang Niu

Change since v1:
-move out from mt8192 seri series

Yongqiang Niu (1):
  soc: mediatek: cmdq: add address shift in jump

 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.1.dirty


^ permalink raw reply	[flat|nested] 16+ messages in thread

* soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34 ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, linux-arm-kernel

Change since v1:
-move out from mt8192 seri series

Yongqiang Niu (1):
  soc: mediatek: cmdq: add address shift in jump

 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.1.dirty

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34 ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, Daniel Vetter, linux-arm-kernel

Change since v1:
-move out from mt8192 seri series

Yongqiang Niu (1):
  soc: mediatek: cmdq: add address shift in jump

 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.1.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34 ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, Daniel Vetter, linux-arm-kernel

Change since v1:
-move out from mt8192 seri series

Yongqiang Niu (1):
  soc: mediatek: cmdq: add address shift in jump

 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.1.1.dirty
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH v2] soc: mediatek: cmdq: add address shift in jump
  2020-12-23  8:34 ` Yongqiang Niu
  (?)
  (?)
@ 2020-12-23  8:34   ` Yongqiang Niu
  -1 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: David Airlie, Daniel Vetter, Mark Rutland, dri-devel, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, Yongqiang Niu

Add address shift when compose jump instruction
to compatible with 35bit format.

Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")

Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 5665b6e..75378e3 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
 	dma_sync_single_for_cpu(dev, prev_task->pa_base,
 				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
-		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
+		(u64)CMDQ_JUMP_BY_PA << 32 |
+		(task->pa_base >> task->cmdq->shift_pa);
 	dma_sync_single_for_device(dev, prev_task->pa_base,
 				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 
-- 
1.8.1.1.dirty


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34   ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, linux-arm-kernel

Add address shift when compose jump instruction
to compatible with 35bit format.

Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")

Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 5665b6e..75378e3 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
 	dma_sync_single_for_cpu(dev, prev_task->pa_base,
 				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
-		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
+		(u64)CMDQ_JUMP_BY_PA << 32 |
+		(task->pa_base >> task->cmdq->shift_pa);
 	dma_sync_single_for_device(dev, prev_task->pa_base,
 				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 
-- 
1.8.1.1.dirty

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34   ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, Daniel Vetter, linux-arm-kernel

Add address shift when compose jump instruction
to compatible with 35bit format.

Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")

Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 5665b6e..75378e3 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
 	dma_sync_single_for_cpu(dev, prev_task->pa_base,
 				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
-		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
+		(u64)CMDQ_JUMP_BY_PA << 32 |
+		(task->pa_base >> task->cmdq->shift_pa);
 	dma_sync_single_for_device(dev, prev_task->pa_base,
 				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 
-- 
1.8.1.1.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2020-12-23  8:34   ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2020-12-23  8:34 UTC (permalink / raw)
  To: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger
  Cc: Mark Rutland, devicetree, Yongqiang Niu, David Airlie,
	linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
	linux-mediatek, Daniel Vetter, linux-arm-kernel

Add address shift when compose jump instruction
to compatible with 35bit format.

Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")

Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 5665b6e..75378e3 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
 	dma_sync_single_for_cpu(dev, prev_task->pa_base,
 				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
-		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
+		(u64)CMDQ_JUMP_BY_PA << 32 |
+		(task->pa_base >> task->cmdq->shift_pa);
 	dma_sync_single_for_device(dev, prev_task->pa_base,
 				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
 
-- 
1.8.1.1.dirty
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
  2020-12-23  8:34   ` Yongqiang Niu
  (?)
  (?)
@ 2021-01-08  1:48     ` Yongqiang Niu
  -1 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2021-01-08  1:48 UTC (permalink / raw)
  To: CK Hu, Jassi Brar
  Cc: Philipp Zabel, Rob Herring, Matthias Brugger, David Airlie,
	Daniel Vetter, Mark Rutland, dri-devel, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek,
	Project_Global_Chrome_Upstream_Group, Chun-Kuang Hu, damon.chu,
	dennis-yc.hsieh

On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> Add address shift when compose jump instruction
> to compatible with 35bit format.
> 
> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> 
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 5665b6e..75378e3 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
>  	dma_sync_single_for_cpu(dev, prev_task->pa_base,
>  				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> -		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> +		(u64)CMDQ_JUMP_BY_PA << 32 |
> +		(task->pa_base >> task->cmdq->shift_pa);
>  	dma_sync_single_for_device(dev, prev_task->pa_base,
>  				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  

hi jassi

please confirm is there any question about this patch.
if not, please apply this into next version, tks

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-01-08  1:48     ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2021-01-08  1:48 UTC (permalink / raw)
  To: CK Hu, Jassi Brar
  Cc: Mark Rutland, devicetree, Chun-Kuang Hu, David Airlie,
	dennis-yc.hsieh, linux-kernel, dri-devel,
	Project_Global_Chrome_Upstream_Group, Rob Herring,
	linux-mediatek, Matthias Brugger, damon.chu, linux-arm-kernel

On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> Add address shift when compose jump instruction
> to compatible with 35bit format.
> 
> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> 
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 5665b6e..75378e3 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
>  	dma_sync_single_for_cpu(dev, prev_task->pa_base,
>  				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> -		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> +		(u64)CMDQ_JUMP_BY_PA << 32 |
> +		(task->pa_base >> task->cmdq->shift_pa);
>  	dma_sync_single_for_device(dev, prev_task->pa_base,
>  				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  

hi jassi

please confirm is there any question about this patch.
if not, please apply this into next version, tks
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-01-08  1:48     ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2021-01-08  1:48 UTC (permalink / raw)
  To: CK Hu, Jassi Brar
  Cc: Mark Rutland, devicetree, Philipp Zabel, Chun-Kuang Hu,
	David Airlie, dennis-yc.hsieh, linux-kernel, dri-devel,
	Project_Global_Chrome_Upstream_Group, Rob Herring,
	linux-mediatek, Daniel Vetter, Matthias Brugger, damon.chu,
	linux-arm-kernel

On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> Add address shift when compose jump instruction
> to compatible with 35bit format.
> 
> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> 
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 5665b6e..75378e3 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
>  	dma_sync_single_for_cpu(dev, prev_task->pa_base,
>  				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> -		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> +		(u64)CMDQ_JUMP_BY_PA << 32 |
> +		(task->pa_base >> task->cmdq->shift_pa);
>  	dma_sync_single_for_device(dev, prev_task->pa_base,
>  				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  

hi jassi

please confirm is there any question about this patch.
if not, please apply this into next version, tks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-01-08  1:48     ` Yongqiang Niu
  0 siblings, 0 replies; 16+ messages in thread
From: Yongqiang Niu @ 2021-01-08  1:48 UTC (permalink / raw)
  To: CK Hu, Jassi Brar
  Cc: Mark Rutland, devicetree, Philipp Zabel, Chun-Kuang Hu,
	David Airlie, dennis-yc.hsieh, linux-kernel, dri-devel,
	Project_Global_Chrome_Upstream_Group, Rob Herring,
	linux-mediatek, Daniel Vetter, Matthias Brugger, damon.chu,
	linux-arm-kernel

On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> Add address shift when compose jump instruction
> to compatible with 35bit format.
> 
> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> 
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 5665b6e..75378e3 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
>  	dma_sync_single_for_cpu(dev, prev_task->pa_base,
>  				prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  	prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> -		(u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> +		(u64)CMDQ_JUMP_BY_PA << 32 |
> +		(task->pa_base >> task->cmdq->shift_pa);
>  	dma_sync_single_for_device(dev, prev_task->pa_base,
>  				   prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
>  

hi jassi

please confirm is there any question about this patch.
if not, please apply this into next version, tks
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
  2021-01-08  1:48     ` Yongqiang Niu
  (?)
  (?)
@ 2021-02-15  5:16       ` Jassi Brar
  -1 siblings, 0 replies; 16+ messages in thread
From: Jassi Brar @ 2021-02-15  5:16 UTC (permalink / raw)
  To: Yongqiang Niu
  Cc: CK Hu, Philipp Zabel, Rob Herring, Matthias Brugger,
	David Airlie, Daniel Vetter, Mark Rutland, dri-devel,
	Devicetree List, Linux Kernel Mailing List, linux-arm-kernel,
	linux-mediatek, Project_Global_Chrome_Upstream_Group,
	Chun-Kuang Hu, Damon Chu, Dennis-YC Hsieh

On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu <yongqiang.niu@mediatek.com> wrote:
>
> On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> > Add address shift when compose jump instruction
> > to compatible with 35bit format.
> >
> > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 5665b6e..75378e3 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
> >       dma_sync_single_for_cpu(dev, prev_task->pa_base,
> >                               prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >       prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> > -             (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> > +             (u64)CMDQ_JUMP_BY_PA << 32 |
> > +             (task->pa_base >> task->cmdq->shift_pa);
> >       dma_sync_single_for_device(dev, prev_task->pa_base,
> >                                  prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >
>
> hi jassi
>
> please confirm is there any question about this patch.
> if not, please apply this into next version, tks
>
I can't locate this patch in my inbox. And I can't fwd it from lkml to
myself. Please resend.

thnks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-02-15  5:16       ` Jassi Brar
  0 siblings, 0 replies; 16+ messages in thread
From: Jassi Brar @ 2021-02-15  5:16 UTC (permalink / raw)
  To: Yongqiang Niu
  Cc: Mark Rutland, Devicetree List, Chun-Kuang Hu, David Airlie,
	Dennis-YC Hsieh, Linux Kernel Mailing List, dri-devel,
	Project_Global_Chrome_Upstream_Group, Matthias Brugger,
	Rob Herring, linux-mediatek, Damon Chu, linux-arm-kernel

On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu <yongqiang.niu@mediatek.com> wrote:
>
> On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> > Add address shift when compose jump instruction
> > to compatible with 35bit format.
> >
> > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 5665b6e..75378e3 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
> >       dma_sync_single_for_cpu(dev, prev_task->pa_base,
> >                               prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >       prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> > -             (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> > +             (u64)CMDQ_JUMP_BY_PA << 32 |
> > +             (task->pa_base >> task->cmdq->shift_pa);
> >       dma_sync_single_for_device(dev, prev_task->pa_base,
> >                                  prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >
>
> hi jassi
>
> please confirm is there any question about this patch.
> if not, please apply this into next version, tks
>
I can't locate this patch in my inbox. And I can't fwd it from lkml to
myself. Please resend.

thnks.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-02-15  5:16       ` Jassi Brar
  0 siblings, 0 replies; 16+ messages in thread
From: Jassi Brar @ 2021-02-15  5:16 UTC (permalink / raw)
  To: Yongqiang Niu
  Cc: Mark Rutland, Devicetree List, Philipp Zabel, Chun-Kuang Hu,
	David Airlie, Dennis-YC Hsieh, Linux Kernel Mailing List,
	dri-devel, Project_Global_Chrome_Upstream_Group,
	Matthias Brugger, Rob Herring, linux-mediatek, Daniel Vetter,
	CK Hu, Damon Chu, linux-arm-kernel

On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu <yongqiang.niu@mediatek.com> wrote:
>
> On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> > Add address shift when compose jump instruction
> > to compatible with 35bit format.
> >
> > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 5665b6e..75378e3 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
> >       dma_sync_single_for_cpu(dev, prev_task->pa_base,
> >                               prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >       prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> > -             (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> > +             (u64)CMDQ_JUMP_BY_PA << 32 |
> > +             (task->pa_base >> task->cmdq->shift_pa);
> >       dma_sync_single_for_device(dev, prev_task->pa_base,
> >                                  prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >
>
> hi jassi
>
> please confirm is there any question about this patch.
> if not, please apply this into next version, tks
>
I can't locate this patch in my inbox. And I can't fwd it from lkml to
myself. Please resend.

thnks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump
@ 2021-02-15  5:16       ` Jassi Brar
  0 siblings, 0 replies; 16+ messages in thread
From: Jassi Brar @ 2021-02-15  5:16 UTC (permalink / raw)
  To: Yongqiang Niu
  Cc: Mark Rutland, Devicetree List, Philipp Zabel, Chun-Kuang Hu,
	David Airlie, Dennis-YC Hsieh, Linux Kernel Mailing List,
	dri-devel, Project_Global_Chrome_Upstream_Group,
	Matthias Brugger, Rob Herring, linux-mediatek, Daniel Vetter,
	CK Hu, Damon Chu, linux-arm-kernel

On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu <yongqiang.niu@mediatek.com> wrote:
>
> On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote:
> > Add address shift when compose jump instruction
> > to compatible with 35bit format.
> >
> > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform")
> >
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >  drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index 5665b6e..75378e3 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -168,7 +168,8 @@ static void cmdq_task_insert_into_thread(struct cmdq_task *task)
> >       dma_sync_single_for_cpu(dev, prev_task->pa_base,
> >                               prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >       prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] =
> > -             (u64)CMDQ_JUMP_BY_PA << 32 | task->pa_base;
> > +             (u64)CMDQ_JUMP_BY_PA << 32 |
> > +             (task->pa_base >> task->cmdq->shift_pa);
> >       dma_sync_single_for_device(dev, prev_task->pa_base,
> >                                  prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE);
> >
>
> hi jassi
>
> please confirm is there any question about this patch.
> if not, please apply this into next version, tks
>
I can't locate this patch in my inbox. And I can't fwd it from lkml to
myself. Please resend.

thnks.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-02-15  8:22 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23  8:34 soc: mediatek: cmdq: add address shift in jump Yongqiang Niu
2020-12-23  8:34 ` Yongqiang Niu
2020-12-23  8:34 ` Yongqiang Niu
2020-12-23  8:34 ` Yongqiang Niu
2020-12-23  8:34 ` [PATCH v2] " Yongqiang Niu
2020-12-23  8:34   ` Yongqiang Niu
2020-12-23  8:34   ` Yongqiang Niu
2020-12-23  8:34   ` Yongqiang Niu
2021-01-08  1:48   ` Yongqiang Niu
2021-01-08  1:48     ` Yongqiang Niu
2021-01-08  1:48     ` Yongqiang Niu
2021-01-08  1:48     ` Yongqiang Niu
2021-02-15  5:16     ` Jassi Brar
2021-02-15  5:16       ` Jassi Brar
2021-02-15  5:16       ` Jassi Brar
2021-02-15  5:16       ` Jassi Brar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.