All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jassisinghbrar@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, ",
	linux-arm-kernel"@lists.infradead.org,
	srv_heupstream <linux-arm-kernel@lists.infradead.org>, ",
	Sascha Hauer" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>, ",
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	srv_heupstream" <linux-mediatek@lists.infradead.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support
Date: Mon, 30 Jul 2018 18:34:56 +0530	[thread overview]
Message-ID: <CABb+yY3PLcjduxm7uJ9xZpPP2zkcQ5Qngs4PjnhGAXp43QVzFA@mail.gmail.com> (raw)
In-Reply-To: <bf7aca98-7ec8-bcf3-b1a8-d86a7cf28d31@pengutronix.de>

On Mon, Jul 30, 2018 at 1:05 PM, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Hi Aishen, Jassie,
>
> i'm lost in this discussion. Please, as soon as I need to add some
> changes to my patches, notify me. Preferably on top for email.
>
I am ok with however you choose to implement, 8 unidirectional or 4
bidirectional channels or whatever.

We just can't have protocol specific s/w modes in the controller drivers.

The best solution is to fix the SCU firmware. If that is _really_
impossible, I provided a solution (3 cells work around). If you have a
better idea please feel free to propose and implement that.

It will also help if you could share the user code of "scu-mode". If
there is no such code (and we know the driver doesn't respect the
"scu-mode" property) why do we even have that binding? Maybe drop it.

thnx.

WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support
Date: Mon, 30 Jul 2018 18:34:56 +0530	[thread overview]
Message-ID: <CABb+yY3PLcjduxm7uJ9xZpPP2zkcQ5Qngs4PjnhGAXp43QVzFA@mail.gmail.com> (raw)
In-Reply-To: <bf7aca98-7ec8-bcf3-b1a8-d86a7cf28d31@pengutronix.de>

On Mon, Jul 30, 2018 at 1:05 PM, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Hi Aishen, Jassie,
>
> i'm lost in this discussion. Please, as soon as I need to add some
> changes to my patches, notify me. Preferably on top for email.
>
I am ok with however you choose to implement, 8 unidirectional or 4
bidirectional channels or whatever.

We just can't have protocol specific s/w modes in the controller drivers.

The best solution is to fix the SCU firmware. If that is _really_
impossible, I provided a solution (3 cells work around). If you have a
better idea please feel free to propose and implement that.

It will also help if you could share the user code of "scu-mode". If
there is no such code (and we know the driver doesn't respect the
"scu-mode" property) why do we even have that binding? Maybe drop it.

thnx.

  parent reply	other threads:[~2018-07-30 13:04 UTC|newest]

Thread overview: 155+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  6:53 [PATCH v7 0/6] add mailbox support for i.MX7D Oleksij Rempel
2018-07-26  6:53 ` Oleksij Rempel
2018-07-26  6:53 ` [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0 Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  9:41   ` Jassi Brar
2018-07-26  9:41     ` Jassi Brar
2018-07-26  9:41     ` Jassi Brar
2018-07-26 11:00     ` A.s. Dong
2018-07-26 11:00       ` A.s. Dong
2018-07-26 11:00       ` A.s. Dong
2018-07-26 11:36       ` Jassi Brar
2018-07-26 11:36         ` Jassi Brar
2018-07-26 11:36         ` Jassi Brar
2018-07-26 11:55         ` A.s. Dong
2018-07-26 11:55           ` A.s. Dong
2018-07-26 11:55           ` A.s. Dong
2018-07-26 12:04           ` Jassi Brar
2018-07-26 12:04             ` Jassi Brar
2018-07-26 12:04             ` Jassi Brar
2018-07-26  6:53 ` [PATCH v7 2/6] dt-bindings: arm: fsl: add mu binding doc Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  9:56   ` Jassi Brar
2018-07-26  9:56     ` Jassi Brar
2018-07-26  6:53 ` [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  9:49   ` Jassi Brar
2018-07-26  9:49     ` Jassi Brar
2018-07-26 10:57     ` Oleksij Rempel
2018-07-26 10:57       ` Oleksij Rempel
2018-07-26 11:28       ` Jassi Brar
2018-07-26 11:28         ` Jassi Brar
2018-07-26 11:51     ` A.s. Dong
2018-07-26 11:51       ` A.s. Dong
2018-07-26 12:26       ` Jassi Brar
2018-07-26 12:26         ` Jassi Brar
2018-07-26 13:34         ` A.s. Dong
2018-07-26 13:34           ` A.s. Dong
2018-07-26 13:49       ` Jassi Brar
2018-07-26 13:49         ` Jassi Brar
2018-07-26 14:13         ` A.s. Dong
2018-07-26 14:13           ` A.s. Dong
2018-07-26 15:44       ` Jassi Brar
2018-07-26 15:44         ` Jassi Brar
2018-07-27  4:02         ` A.s. Dong
2018-07-27  4:02           ` A.s. Dong
2018-07-27  4:55           ` Jassi Brar
2018-07-27  4:55             ` Jassi Brar
2018-07-27  6:00             ` A.s. Dong
2018-07-27  6:00               ` A.s. Dong
2018-07-27  6:46               ` Jassi Brar
2018-07-27  6:46                 ` Jassi Brar
2018-07-27  8:42                 ` A.s. Dong
2018-07-27  8:42                   ` A.s. Dong
2018-07-27  9:05                   ` A.s. Dong
2018-07-27  9:05                     ` A.s. Dong
2018-07-28 13:09                   ` Jassi Brar
2018-07-28 13:09                     ` Jassi Brar
2018-07-30  7:35                     ` Oleksij Rempel
2018-07-30  7:35                       ` Oleksij Rempel
2018-07-30  8:42                       ` A.s. Dong
2018-07-30  8:42                         ` A.s. Dong
2018-07-30 13:04                       ` Jassi Brar [this message]
2018-07-30 13:04                         ` Jassi Brar
2018-07-30 14:14                         ` A.s. Dong
2018-07-30 14:14                           ` A.s. Dong
2018-07-30 14:27                           ` A.s. Dong
2018-07-30 14:27                             ` A.s. Dong
2018-07-30 14:17                         ` A.s. Dong
2018-07-30 14:17                           ` A.s. Dong
2018-07-30 14:44                         ` Oleksij Rempel
2018-07-30 14:44                           ` Oleksij Rempel
2018-07-30 15:02                           ` Jassi Brar
2018-07-30 15:02                             ` Jassi Brar
2018-07-30 15:36                             ` A.s. Dong
2018-07-30 15:36                               ` A.s. Dong
2018-07-30 16:18                             ` Jassi Brar
2018-07-30 16:18                               ` Jassi Brar
2018-07-30 16:49                               ` Oleksij Rempel
2018-07-30 16:49                                 ` Oleksij Rempel
2018-07-31  2:51                                 ` Jassi Brar
2018-07-31  2:51                                   ` Jassi Brar
2018-07-31  7:21                               ` A.s. Dong
2018-07-31  7:21                                 ` A.s. Dong
2018-07-31 10:15                                 ` Jassi Brar
2018-07-31 10:15                                   ` Jassi Brar
2018-07-31 12:42                                   ` Jassi Brar
2018-07-31 12:42                                     ` Jassi Brar
2018-08-02  9:24                                     ` A.s. Dong
2018-08-02  9:24                                       ` A.s. Dong
2018-08-09  2:22                                       ` A.s. Dong
2018-08-09  2:22                                         ` A.s. Dong
2018-08-09  2:55                                         ` Jassi Brar
2018-08-09  2:55                                           ` Jassi Brar
2018-08-09  6:45                                           ` A.s. Dong
2018-08-09  6:45                                             ` A.s. Dong
2018-07-30  8:29                     ` A.s. Dong
2018-07-30  8:29                       ` A.s. Dong
2018-07-30  8:39         ` A.s. Dong
2018-07-30  8:39           ` A.s. Dong
2018-07-26  6:53 ` [PATCH v7 4/6] dt-bindings: mailbox: imx-mu: add i.MX6SX and i.MX7S SoCs Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  8:16   ` A.s. Dong
2018-07-26  8:16     ` A.s. Dong
2018-07-26  9:55   ` Jassi Brar
2018-07-26  9:55     ` Jassi Brar
2018-07-26 10:41     ` Lucas Stach
2018-07-26 10:41       ` Lucas Stach
2018-07-26 11:15       ` Jassi Brar
2018-07-26 11:15         ` Jassi Brar
2018-07-26 11:35         ` Lucas Stach
2018-07-26 11:35           ` Lucas Stach
2018-07-26 11:46           ` Jassi Brar
2018-07-26 11:46             ` Jassi Brar
2018-07-26 11:51             ` Vladimir Zapolskiy
2018-07-26 11:51               ` Vladimir Zapolskiy
2018-07-26 12:00               ` Jassi Brar
2018-07-26 12:00                 ` Jassi Brar
2018-07-26 12:10                 ` Vladimir Zapolskiy
2018-07-26 12:10                   ` Vladimir Zapolskiy
2018-07-26 11:54             ` Lucas Stach
2018-07-26 11:54               ` Lucas Stach
2018-07-26 11:44         ` Vladimir Zapolskiy
2018-07-26 11:44           ` Vladimir Zapolskiy
2018-07-26 11:52           ` Jassi Brar
2018-07-26 11:52             ` Jassi Brar
2018-07-26 11:55             ` Vladimir Zapolskiy
2018-07-26 11:55               ` Vladimir Zapolskiy
2018-07-26 12:10               ` Jassi Brar
2018-07-26 12:10                 ` Jassi Brar
     [not found]                 ` <CABb+yY02KNB9ELKiWYdB0LyvTghhk+nk-dTUGfG8_+KUB_H=Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-26 12:41                   ` Vladimir Zapolskiy
2018-07-26 12:41                     ` Vladimir Zapolskiy
2018-07-30 22:22     ` Rob Herring
2018-07-30 22:22       ` Rob Herring
2018-07-31 10:16       ` Jassi Brar
2018-07-31 10:16         ` Jassi Brar
2018-07-31 10:18       ` Jassi Brar
2018-07-31 10:18         ` Jassi Brar
2018-07-26  6:53 ` [PATCH v7 5/6] ARM: dts: imx7s: add i.MX7 messaging unit support Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  8:11   ` Lucas Stach
2018-07-26  8:11     ` Lucas Stach
2018-07-26  6:53 ` [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit Oleksij Rempel
2018-07-26  6:53   ` Oleksij Rempel
2018-07-26  8:07   ` Lucas Stach
2018-07-26  8:07     ` Lucas Stach
2018-07-26 10:15   ` Jassi Brar
2018-07-26 10:15     ` Jassi Brar
2018-07-26 10:51     ` Oleksij Rempel
2018-07-26 10:51       ` Oleksij Rempel
2018-07-26 11:09       ` Jassi Brar
2018-07-26 11:09         ` Jassi Brar
2018-07-26 11:42         ` Oleksij Rempel
2018-07-26 11:42           ` Oleksij Rempel
2018-07-26 12:17           ` Jassi Brar
2018-07-26 12:17             ` Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABb+yY3PLcjduxm7uJ9xZpPP2zkcQ5Qngs4PjnhGAXp43QVzFA@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=", linux-arm-kernel"@lists.infradead.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.