* [PATCH] gtk-icon-cache: Fix rdepends construction
@ 2013-01-31 19:11 Saul Wold
2013-01-31 19:50 ` Chris Larson
0 siblings, 1 reply; 4+ messages in thread
From: Saul Wold @ 2013-01-31 19:11 UTC (permalink / raw)
To: openembedded-core
The rdepends getVar is returning NoneType and the string constuction fails
this occurs with the hicolor-icon-theme recipe.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
meta/classes/gtk-icon-cache.bbclass | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
index d5fdcd5..cf33efd 100644
--- a/meta/classes/gtk-icon-cache.bbclass
+++ b/meta/classes/gtk-icon-cache.bbclass
@@ -67,9 +67,8 @@ python populate_packages_append () {
continue
bb.note("adding hicolor-icon-theme dependency to %s" % pkg)
- rdepends = d.getVar('RDEPENDS_%s' % pkg, True)
- rdepends = rdepends + ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"
- d.setVar('RDEPENDS_%s' % pkg, rdepends)
+ rdepends = ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"
+ d.appendVar('RDEPENDS_%s' % pkg, rdepends)
bb.note("adding gtk-icon-cache postinst and postrm scripts to %s" % pkg)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gtk-icon-cache: Fix rdepends construction
2013-01-31 19:11 [PATCH] gtk-icon-cache: Fix rdepends construction Saul Wold
@ 2013-01-31 19:50 ` Chris Larson
2013-01-31 19:50 ` Chris Larson
0 siblings, 1 reply; 4+ messages in thread
From: Chris Larson @ 2013-01-31 19:50 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Thu, Jan 31, 2013 at 12:11 PM, Saul Wold <sgw@linux.intel.com> wrote:
> - rdepends = d.getVar('RDEPENDS_%s' % pkg, True)
> - rdepends = rdepends + ' ' + d.getVar('MLPREFIX') +
> "hicolor-icon-theme"
> - d.setVar('RDEPENDS_%s' % pkg, rdepends)
> + rdepends = ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"
> + d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>
The new version isn't using a getVar of the old rdepends at all, so it's
just replacing it every time. Is that really what you intended here?
Wouldn't a getVar() or '' be a better approach? Further, the '' +
d.getVar('MLPREFIX') is pointless if you aren't including the original
value, as it adds a separator to the beginning when there's nothing to
separate.
--
Christopher Larson
[-- Attachment #2: Type: text/html, Size: 1253 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gtk-icon-cache: Fix rdepends construction
2013-01-31 19:50 ` Chris Larson
@ 2013-01-31 19:50 ` Chris Larson
2013-01-31 20:19 ` Saul Wold
0 siblings, 1 reply; 4+ messages in thread
From: Chris Larson @ 2013-01-31 19:50 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Thu, Jan 31, 2013 at 12:50 PM, Chris Larson <clarson@kergoth.com> wrote:
> On Thu, Jan 31, 2013 at 12:11 PM, Saul Wold <sgw@linux.intel.com> wrote:
>
>> - rdepends = d.getVar('RDEPENDS_%s' % pkg, True)
>> - rdepends = rdepends + ' ' + d.getVar('MLPREFIX') +
>> "hicolor-icon-theme"
>> - d.setVar('RDEPENDS_%s' % pkg, rdepends)
>> + rdepends = ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"
>> + d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>>
>
> The new version isn't using a getVar of the old rdepends at all, so it's
> just replacing it every time. Is that really what you intended here?
> Wouldn't a getVar() or '' be a better approach? Further, the '' +
> d.getVar('MLPREFIX') is pointless if you aren't including the original
> value, as it adds a separator to the beginning when there's nothing to
> separate.
Erm, ignore this, I'm apparently blind as a bat if I can't see 'appendVar'
:)
--
Christopher Larson
[-- Attachment #2: Type: text/html, Size: 1680 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gtk-icon-cache: Fix rdepends construction
2013-01-31 19:50 ` Chris Larson
@ 2013-01-31 20:19 ` Saul Wold
0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2013-01-31 20:19 UTC (permalink / raw)
To: Chris Larson; +Cc: Patches and discussions about the oe-core layer
On 01/31/2013 11:50 AM, Chris Larson wrote:
>
> On Thu, Jan 31, 2013 at 12:50 PM, Chris Larson <clarson@kergoth.com
> <mailto:clarson@kergoth.com>> wrote:
>
> On Thu, Jan 31, 2013 at 12:11 PM, Saul Wold <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>> wrote:
>
> - rdepends = d.getVar('RDEPENDS_%s' % pkg, True)
> - rdepends = rdepends + ' ' + d.getVar('MLPREFIX') +
> "hicolor-icon-theme"
> - d.setVar('RDEPENDS_%s' % pkg, rdepends)
> + rdepends = ' ' + d.getVar('MLPREFIX') +
> "hicolor-icon-theme"
> + d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>
>
> The new version isn't using a getVar of the old rdepends at all, so
> it's just replacing it every time. Is that really what you intended
> here? Wouldn't a getVar() or '' be a better approach? Further, the
> '' + d.getVar('MLPREFIX') is pointless if you aren't including the
> original value, as it adds a separator to the beginning when there's
> nothing to separate.
>
>
> Erm, ignore this, I'm apparently blind as a bat if I can't see
> 'appendVar' :)
No problem, I have had those days also.
Sau!
> --
> Christopher Larson
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-31 20:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-31 19:11 [PATCH] gtk-icon-cache: Fix rdepends construction Saul Wold
2013-01-31 19:50 ` Chris Larson
2013-01-31 19:50 ` Chris Larson
2013-01-31 20:19 ` Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.