[PATCH] selftest/fetch: Avoid occasional selftest failure from poor temp file name choice

[PATCH] selftest/fetch: Avoid occasional selftest failure from poor temp file name choice

[Richard Purdie]

The temp file name may contain "_" characters. Avoid this to avoid errors like:

bb.data_smart.ExpansionError: Failure expanding variable PN, expression was
${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[0] or 'defaultpkgname'}
which triggered exception ParseError:
ParseError in /tmp/tmpd_f2__to.bb: Unable to generate default variables from
filename (too many underscores)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/lib/oeqa/selftest/cases/fetch.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/fetch.py b/meta/lib/oeqa/selftest/cases/fetch.py
index 67e85d3e4c7..1d223c0778f 100644
--- a/meta/lib/oeqa/selftest/cases/fetch.py
+++ b/meta/lib/oeqa/selftest/cases/fetch.py
@@ -57,6 +57,8 @@ MIRRORS_forcevariable = "git://.*/.* http://downloads.yoctoproject.org/mirror/so
 class Dependencies(OESelftestTestCase):
     def write_recipe(self, content):
         f = tempfile.NamedTemporaryFile(mode="wt", suffix=".bb")
+        while "_" in f.name:
+            f = tempfile.NamedTemporaryFile(mode="wt", suffix=".bb")
         f.write(content)
         f.flush()
         return f
-- 
2.30.2

Re: [OE-core] [PATCH] selftest/fetch: Avoid occasional selftest failure from poor temp file name choice

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

Couldn't we also create a temporary directory and create a file with a
consistent name there, rather than retrying the named file approach?

On Thu, Jun 3, 2021 at 3:24 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> The temp file name may contain "_" characters. Avoid this to avoid errors
> like:
>
> bb.data_smart.ExpansionError: Failure expanding variable PN, expression was
> ${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[0] or
> 'defaultpkgname'}
> which triggered exception ParseError:
> ParseError in /tmp/tmpd_f2__to.bb: Unable to generate default variables
> from
> filename (too many underscores)
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/lib/oeqa/selftest/cases/fetch.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/fetch.py
> b/meta/lib/oeqa/selftest/cases/fetch.py
> index 67e85d3e4c7..1d223c0778f 100644
> --- a/meta/lib/oeqa/selftest/cases/fetch.py
> +++ b/meta/lib/oeqa/selftest/cases/fetch.py
> @@ -57,6 +57,8 @@ MIRRORS_forcevariable = "git://.*/.*
> http://downloads.yoctoproject.org/mirror/so
>  class Dependencies(OESelftestTestCase):
>      def write_recipe(self, content):
>          f = tempfile.NamedTemporaryFile(mode="wt", suffix=".bb")
> +        while "_" in f.name:
> +            f = tempfile.NamedTemporaryFile(mode="wt", suffix=".bb")
>          f.write(content)
>          f.flush()
>          return f
> --
> 2.30.2
>
>
> 
>
>

-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2553 bytes --]