* [PATCH V2] sanity: display the parsed PATH/BBPATH when complaining
@ 2012-07-18 14:12 Ross Burton
2012-07-18 14:12 ` [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2012-07-18 14:12 UTC (permalink / raw)
To: openembedded-core
In-Reply-To:
As pointed out by Martin, do the same for BBPATH.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements
2012-07-18 14:12 [PATCH V2] sanity: display the parsed PATH/BBPATH when complaining Ross Burton
@ 2012-07-18 14:12 ` Ross Burton
2012-07-18 14:53 ` Chris Larson
2012-07-24 20:32 ` Andrei Gherzan
0 siblings, 2 replies; 4+ messages in thread
From: Ross Burton @ 2012-07-18 14:12 UTC (permalink / raw)
To: openembedded-core
Many people don't understand the nuances of PATH/BBPATH, so help them by clarifying
the warning and displaying the parsed list element-by-element.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/classes/sanity.bbclass | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 765958e..52226f1 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -390,7 +390,8 @@ def check_sanity(sanity_data):
paths = sanity_data.getVar('PATH', True).split(":")
if "." in paths or "" in paths:
- messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
+ messages = messages + "PATH contains '.' or '' (empty element), which will break the build, please remove this.\n"
+ messages = messages + "Parsed PATH is " + str(paths) + "\n"
bbpaths = sanity_data.getVar('BBPATH', True).split(":")
if "." in bbpaths or "" in bbpaths:
@@ -402,6 +403,7 @@ def check_sanity(sanity_data):
"Please check your layer.conf files and other BBPATH " \
"settings to remove the current working directory " \
"references.");
+ bb.warn("Parsed BBPATH is" + str(bbpaths));
if sanity_data.getVar('TARGET_ARCH', True) == "arm":
# This path is no longer user-readable in modern (very recent) Linux
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements
2012-07-18 14:12 ` [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements Ross Burton
@ 2012-07-18 14:53 ` Chris Larson
2012-07-24 20:32 ` Andrei Gherzan
1 sibling, 0 replies; 4+ messages in thread
From: Chris Larson @ 2012-07-18 14:53 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Jul 18, 2012 at 7:12 AM, Ross Burton <ross.burton@intel.com> wrote:
> Many people don't understand the nuances of PATH/BBPATH, so help them by clarifying
> the warning and displaying the parsed list element-by-element.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
Looks good.
--
Christopher Larson
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements
2012-07-18 14:12 ` [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements Ross Burton
2012-07-18 14:53 ` Chris Larson
@ 2012-07-24 20:32 ` Andrei Gherzan
1 sibling, 0 replies; 4+ messages in thread
From: Andrei Gherzan @ 2012-07-24 20:32 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
On Wed, Jul 18, 2012 at 5:12 PM, Ross Burton <ross.burton@intel.com> wrote:
> Many people don't understand the nuances of PATH/BBPATH, so help them by
> clarifying
> the warning and displaying the parsed list element-by-element.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/classes/sanity.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 765958e..52226f1 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -390,7 +390,8 @@ def check_sanity(sanity_data):
>
> paths = sanity_data.getVar('PATH', True).split(":")
> if "." in paths or "" in paths:
> - messages = messages + "PATH contains '.' or '', which will break
> the build, please remove this."
> + messages = messages + "PATH contains '.' or '' (empty element),
> which will break the build, please remove this.\n"
> + messages = messages + "Parsed PATH is " + str(paths) + "\n"
>
> bbpaths = sanity_data.getVar('BBPATH', True).split(":")
> if "." in bbpaths or "" in bbpaths:
> @@ -402,6 +403,7 @@ def check_sanity(sanity_data):
> "Please check your layer.conf files and other BBPATH "
> \
> "settings to remove the current working directory "
> \
> "references.");
> + bb.warn("Parsed BBPATH is" + str(bbpaths));
>
> if sanity_data.getVar('TARGET_ARCH', True) == "arm":
> # This path is no longer user-readable in modern (very recent)
> Linux
>
Good change.
ag
[-- Attachment #2: Type: text/html, Size: 2240 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-24 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 14:12 [PATCH V2] sanity: display the parsed PATH/BBPATH when complaining Ross Burton
2012-07-18 14:12 ` [PATCH] sanity: display the parsed PATH/BBPATH when complaining about CWD elements Ross Burton
2012-07-18 14:53 ` Chris Larson
2012-07-24 20:32 ` Andrei Gherzan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.