[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Naresh Kamboju]

LTP master testing on Hikey (arm64) device reported newly added
execveat03 failed.

Test output,
execveat03.c:74: FAIL: execveat() returned unexpected errno: EINVAL

Full log link,
https://lkft.validation.linaro.org/scheduler/job/420924#L2941

FYI,
LTP Version: 20180515-270-ge7bab6188

Best regards

Naresh Kamboju

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Jan Stancek]

----- Original Message -----
> LTP master testing on Hikey (arm64) device reported newly added
> execveat03 failed.

Looks expected if your kernel doesn't have commit:
      355139a8dba4 ("cap_inode_getsecurity: use d_find_any_alias()
                     instead of d_find_alias()")

Can you confirm?

> 
> Test output,
> execveat03.c:74: FAIL: execveat() returned unexpected errno: EINVAL
> 
> Full log link,
> https://lkft.validation.linaro.org/scheduler/job/420924#L2941
> 
> FYI,
> LTP Version: 20180515-270-ge7bab6188
> 
> Best regards
> 
> Naresh Kamboju
> 

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Rafael David Tinoco]

Jan, Naresh:

The fix has been backported to:

$ git tag --contains ff1663fc9483e131f674db8b2f42f9a99460ae50
v4.18.7
v4.18.8

$ git tag --contains 5a842ecca279f583c3fdc9a1ed8fe7a4cc348789
v4.14.69
v4.14.70

This fix has not been backported to v4.9 nor v4.4.

From the build URL:
http://snapshots.linaro.org/openembedded/ltp/rocko/hikey/300/rpb/
Looks like build from commit 94710cac did NOT contain needed fix.

I think it will be all good for future builds.

Naresh,

I would blacklist this one for 4.4 and 4.9.

On Sat, Sep 15, 2018 at 7:50 AM Jan Stancek <jstancek@redhat.com> wrote:
> ----- Original Message -----
> > LTP master testing on Hikey (arm64) device reported newly added
> > execveat03 failed.
>
> Looks expected if your kernel doesn't have commit:
>       355139a8dba4 ("cap_inode_getsecurity: use d_find_any_alias()
>                      instead of d_find_alias()")
>
> Can you confirm?
>
> > Test output,
> > execveat03.c:74: FAIL: execveat() returned unexpected errno: EINVAL
> >
> > Full log link,
> > https://lkft.validation.linaro.org/scheduler/job/420924#L2941
> >
> > FYI,
> > LTP Version: 20180515-270-ge7bab6188
> >
> > Best regards
> >
> > Naresh Kamboju

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Naresh Kamboju]

On 15 September 2018 at 16:20, Jan Stancek <jstancek@redhat.com> wrote:
>
>
> ----- Original Message -----
>> LTP master testing on Hikey (arm64) device reported newly added
>> execveat03 failed.
>
> Looks expected if your kernel doesn't have commit:
>       355139a8dba4 ("cap_inode_getsecurity: use d_find_any_alias()
>                      instead of d_find_alias()")
>
> Can you confirm?

This required patch was not included on the kernel that have tested.
Thanks for sharing information.

- Naresh

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Naresh Kamboju]

On 16 September 2018 at 22:28, Rafael David Tinoco
<rafael.tinoco@linaro.org> wrote:
> Jan, Naresh:
>
> The fix has been backported to:
>
> $ git tag --contains ff1663fc9483e131f674db8b2f42f9a99460ae50
> v4.18.7
> v4.18.8
>
> $ git tag --contains 5a842ecca279f583c3fdc9a1ed8fe7a4cc348789
> v4.14.69
> v4.14.70
>
> This fix has not been backported to v4.9 nor v4.4.
>
> From the build URL:
> http://snapshots.linaro.org/openembedded/ltp/rocko/hikey/300/rpb/
> Looks like build from commit 94710cac did NOT contain needed fix.
>
> I think it will be all good for future builds.
>
> Naresh,
>
> I would blacklist this one for 4.4 and 4.9.

LTP test case should detect old kernel versions and skip (CONF) it on
older kernels instead of FAIL.

- Naresh

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Eddie.Horng]

On Tue, 2018-09-18 at 05:01 +0530, Naresh Kamboju wrote:
> >
> > Naresh,
> >
> > I would blacklist this one for 4.4 and 4.9.
> 
> LTP test case should detect old kernel versions and skip (CONF) it on
> older kernels instead of FAIL.
> 
> - Naresh

Hi Naresh,
The regression that execveat03 intends to test is introduced from 4.14, 
commit (8db6c34f1dbc Introduce v3 namespaced file capabilities).
So before 4.14 the case is expected to PASS, no required to skip it.

thanks,
Eddie

[LTP] LTP master: arm64: execveat03: execveat() returned unexpected errno: EINVAL

[Rafael Tinoco]

On Mon, Sep 17, 2018, 19:18 Eddie.Horng <eddie.horng@mediatek.com> wrote:

> On Tue, 2018-09-18 at 05:01 +0530, Naresh Kamboju wrote:
> > >
> > > Naresh,
> > >
> > > I would blacklist this one for 4.4 and 4.9.
> >
> > LTP test case should detect old kernel versions and skip (CONF) it on
> > older kernels instead of FAIL.
> >
> > - Naresh
>
> Hi Naresh,
> The regression that execveat03 intends to test is introduced from 4.14,
> commit (8db6c34f1dbc Introduce v3 namespaced file capabilities).
> So before 4.14 the case is expected to PASS, no required to skip it.
>

Thank you! I forgot to check that!

>
> thanks,
> Eddie
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180917/0fde496c/attachment.html>