All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: willemdebruijn.kernel@gmail.com,
	"David S. Miller" <davem@davemloft.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Network Devel Mailing List <netdev@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH 6/8] socket: Add struct sock_timeval
Date: Mon, 26 Nov 2018 08:33:22 -0800	[thread overview]
Message-ID: <CABeXuvp5KAhJmU69G54G1LAB69otk=svpuaV8vra_iuHa2VsBA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3UVOeaYqwOiAMrziVcY6GpbCkDRGGAgFJKBJnB1e=v=w@mail.gmail.com>

> I think we want signed types to keep it closer to what we
> have today with 'timeval'. as long as linux/types.h is included
> first (it is).
>
> Between __s64 or long long, I don't think it makes a difference,
> so let's just go with Willem's suggestion. We already rely on
> 'long long' being exactly 64 bit wide in 'struct __kernel_timespec'
> as well.

Sure, I will change this to __s64.
I was also thinking we want signed types because it should be possible
to set system time before 1970.

> We could however debate whether 'sock_timeval' should
> be visible to user space in linux/tme.h like this, or if it
> should be put in a namespace like '__kernel_sock_timeval'
> to ensure it won't conflict with user space headers defining
> a type of the same name.

Good idea. I can rename it to __kernel_sock_timeval.

Thanks,
Deepa

  reply	other threads:[~2018-11-26 16:33 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  2:20 [PATCH 0/8] net: y2038-safe socket timestamps Deepa Dinamani
2018-11-24  2:20 ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 1/8] arch: Use asm-generic/socket.h when possible Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 2/8] sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  3:58   ` Willem de Bruijn
2018-11-25  3:58     ` Willem de Bruijn
2018-11-30 22:38     ` Deepa Dinamani
2018-11-30 22:38       ` Deepa Dinamani
2018-11-30 23:33       ` Willem de Bruijn
2018-11-30 23:33         ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP Deepa Dinamani
2018-11-25  3:59   ` Willem de Bruijn
2018-11-25  5:06     ` Deepa Dinamani
2018-11-25 14:18       ` Willem de Bruijn
2018-11-25 18:19         ` David Miller
2018-11-30 22:16           ` Deepa Dinamani
2018-11-30 23:31             ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 4/8] arch: sparc: Override struct __kernel_old_timeval Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 5/8] socket: Use old_timeval types for socket timestamps Deepa Dinamani
2018-11-24  2:20 ` [PATCH 6/8] socket: Add struct sock_timeval Deepa Dinamani
2018-11-24 19:37   ` Willem de Bruijn
2018-11-24 19:37     ` Willem de Bruijn
2018-11-25  2:09     ` David Miller
2018-11-25  4:52     ` Deepa Dinamani
2018-11-25  4:52       ` Deepa Dinamani
2018-11-25 20:50       ` Arnd Bergmann
2018-11-26 16:33         ` Deepa Dinamani [this message]
2018-11-24  2:20 ` [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  3:59   ` Willem de Bruijn
2018-11-25  3:59     ` Willem de Bruijn
2018-11-25  4:17     ` Willem de Bruijn
2018-11-25  4:17       ` Willem de Bruijn
2018-11-25  4:17       ` Willem de Bruijn
2018-11-25  5:28       ` Deepa Dinamani
2018-11-25  5:28         ` Deepa Dinamani
2018-11-25  5:28         ` Deepa Dinamani
2018-11-25  5:55         ` Deepa Dinamani
2018-11-25  5:55           ` Deepa Dinamani
2018-11-25  5:55           ` Deepa Dinamani
2018-11-25 14:38           ` Willem de Bruijn
2018-11-25 14:38             ` Willem de Bruijn
2018-11-25 14:33         ` Willem de Bruijn
2018-11-25 14:33           ` Willem de Bruijn
2018-11-25 14:33           ` Willem de Bruijn
2018-11-25 22:35           ` Arnd Bergmann
2018-11-25 22:35             ` Arnd Bergmann
2018-11-26  0:25             ` Willem de Bruijn
2018-11-26  0:25               ` Willem de Bruijn
2018-11-30 22:43           ` Deepa Dinamani
2018-11-30 22:43             ` Deepa Dinamani
2018-11-30 23:37             ` Willem de Bruijn
2018-11-30 23:37               ` Willem de Bruijn
2018-11-30 23:37               ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 8/8] socket: Add SO_TIMESTAMPING_NEW Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  4:00   ` Willem de Bruijn
2018-11-25  4:00     ` Willem de Bruijn
2018-11-25  5:07     ` Deepa Dinamani
2018-11-25  5:07       ` Deepa Dinamani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABeXuvp5KAhJmU69G54G1LAB69otk=svpuaV8vra_iuHa2VsBA@mail.gmail.com' \
    --to=deepa.kernel@gmail.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.