All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	LKML <linux-kernel@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
	y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP
Date: Sat, 24 Nov 2018 22:59:08 -0500	[thread overview]
Message-ID: <CAF=yD-JGh23sA_6eUtBq8=wSZ5g=nipmhdr1WwjP5th51qEtiQ@mail.gmail.com> (raw)
In-Reply-To: <20181124022035.17519-4-deepa.kernel@gmail.com>

On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>
> SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP
> is always set along with SOCK_RCVTSTAMPNS. This leads to
> checking for two flag states whenever we need to check for
> SOCK_RCVTSTAMPS.
>
> Also SOCK_RCVTSTAMPS was the only flag that needed to be
> checked in order to verify if either of the two flags are
> set. But, the two features are not actually dependent on
> each other. This artificial dependency creates more
> confusion.

This is done so that the hot path only has to check one flag
in the common case where no timestamp is requested.

  reply	other threads:[~2018-11-25  3:59 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  2:20 [PATCH 0/8] net: y2038-safe socket timestamps Deepa Dinamani
2018-11-24  2:20 ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 1/8] arch: Use asm-generic/socket.h when possible Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 2/8] sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  3:58   ` Willem de Bruijn
2018-11-25  3:58     ` Willem de Bruijn
2018-11-30 22:38     ` Deepa Dinamani
2018-11-30 22:38       ` Deepa Dinamani
2018-11-30 23:33       ` Willem de Bruijn
2018-11-30 23:33         ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP Deepa Dinamani
2018-11-25  3:59   ` Willem de Bruijn [this message]
2018-11-25  5:06     ` Deepa Dinamani
2018-11-25 14:18       ` Willem de Bruijn
2018-11-25 18:19         ` David Miller
2018-11-30 22:16           ` Deepa Dinamani
2018-11-30 23:31             ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 4/8] arch: sparc: Override struct __kernel_old_timeval Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 5/8] socket: Use old_timeval types for socket timestamps Deepa Dinamani
2018-11-24  2:20 ` [PATCH 6/8] socket: Add struct sock_timeval Deepa Dinamani
2018-11-24 19:37   ` Willem de Bruijn
2018-11-24 19:37     ` Willem de Bruijn
2018-11-25  2:09     ` David Miller
2018-11-25  4:52     ` Deepa Dinamani
2018-11-25  4:52       ` Deepa Dinamani
2018-11-25 20:50       ` Arnd Bergmann
2018-11-26 16:33         ` Deepa Dinamani
2018-11-24  2:20 ` [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  3:59   ` Willem de Bruijn
2018-11-25  3:59     ` Willem de Bruijn
2018-11-25  4:17     ` Willem de Bruijn
2018-11-25  4:17       ` Willem de Bruijn
2018-11-25  4:17       ` Willem de Bruijn
2018-11-25  5:28       ` Deepa Dinamani
2018-11-25  5:28         ` Deepa Dinamani
2018-11-25  5:28         ` Deepa Dinamani
2018-11-25  5:55         ` Deepa Dinamani
2018-11-25  5:55           ` Deepa Dinamani
2018-11-25  5:55           ` Deepa Dinamani
2018-11-25 14:38           ` Willem de Bruijn
2018-11-25 14:38             ` Willem de Bruijn
2018-11-25 14:33         ` Willem de Bruijn
2018-11-25 14:33           ` Willem de Bruijn
2018-11-25 14:33           ` Willem de Bruijn
2018-11-25 22:35           ` Arnd Bergmann
2018-11-25 22:35             ` Arnd Bergmann
2018-11-26  0:25             ` Willem de Bruijn
2018-11-26  0:25               ` Willem de Bruijn
2018-11-30 22:43           ` Deepa Dinamani
2018-11-30 22:43             ` Deepa Dinamani
2018-11-30 23:37             ` Willem de Bruijn
2018-11-30 23:37               ` Willem de Bruijn
2018-11-30 23:37               ` Willem de Bruijn
2018-11-24  2:20 ` [PATCH 8/8] socket: Add SO_TIMESTAMPING_NEW Deepa Dinamani
2018-11-24  2:20   ` Deepa Dinamani
2018-11-25  4:00   ` Willem de Bruijn
2018-11-25  4:00     ` Willem de Bruijn
2018-11-25  5:07     ` Deepa Dinamani
2018-11-25  5:07       ` Deepa Dinamani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF=yD-JGh23sA_6eUtBq8=wSZ5g=nipmhdr1WwjP5th51qEtiQ@mail.gmail.com' \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=deepa.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.