All of lore.kernel.org
 help / color / mirror / Atom feed
From: "João Marcos Costa" <jmcosta944@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Genoud <richard.genoud@posteo.net>
Subject: Re: [PATCH 1/3] test/py: rewrite common tools for SquashFS tests
Date: Sat, 29 May 2021 15:14:13 -0300	[thread overview]
Message-ID: <CABfBAmDqQgyfwSZnQONPeyRwg1wjh84dnLAMumLzeCvwRsVyYQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0EUDKrsnxNLVe8nCdwZS2P6v77VqV=hdTjc-p+rtSs4Q@mail.gmail.com>

Hello,

Em qui., 27 de mai. de 2021 às 10:44, Simon Glass <sjg@chromium.org>
escreveu:

> Hi Joao,
>
> On Sun, 23 May 2021 at 20:31, Joao Marcos Costa <jmcosta944@gmail.com>
> wrote:
> >
> > Remove the previous OOP approach, which was confusing and incomplete.
> > Add more test cases by making SquashFS images with various options,
> > concerning file fragmentation and its compression. Add comments to
> > properly document the code.
> >
> > Signed-off-by: Joao Marcos Costa <jmcosta944@gmail.com>
> > ---
> [...]
>
> While we are here, can you please be a little more formal with your
> function comments? pylint3 will tell you about it if you run it on
> this file.
>
> [...]
>
> Regards,
> Simon
>

Absolutely, Simon, and thanks for suggesting pylint3!

-- 
Atenciosamente,
João Marcos Costa

www.linkedin.com/in/jmarcoscosta/
https://github.com/jmarcoscosta

  reply	other threads:[~2021-05-29 18:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  2:31 [PATCH 0/3] test/py: Rewrite SquashFS commands test suite Joao Marcos Costa
2021-05-24  2:31 ` [PATCH 1/3] test/py: rewrite common tools for SquashFS tests Joao Marcos Costa
2021-05-25 16:58   ` Tom Rini
2021-05-27 13:44   ` Simon Glass
2021-05-29 18:14     ` João Marcos Costa [this message]
2021-05-24  2:31 ` [PATCH 2/3] test/py: rewrite sqfsload command test suite Joao Marcos Costa
2021-05-24  2:31 ` [PATCH 3/3] test/py: rewrite sqfsls " Joao Marcos Costa
2021-05-26 13:37 ` [PATCH 0/3] test/py: Rewrite SquashFS commands " Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABfBAmDqQgyfwSZnQONPeyRwg1wjh84dnLAMumLzeCvwRsVyYQ@mail.gmail.com \
    --to=jmcosta944@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard.genoud@posteo.net \
    --cc=sjg@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.