* Audit and fix all misuse of NLA_STRING: STATUS
@ 2019-06-18 17:56 Romain Perier
2019-06-20 16:15 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Romain Perier @ 2019-06-18 17:56 UTC (permalink / raw)
To: Kernel Hardening, Kees Cook
Hi !
Here a first review, you can get the complete list here:
https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
Regards,
Romain
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Audit and fix all misuse of NLA_STRING: STATUS
2019-06-18 17:56 Audit and fix all misuse of NLA_STRING: STATUS Romain Perier
@ 2019-06-20 16:15 ` Kees Cook
2019-06-21 10:54 ` Romain Perier
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2019-06-20 16:15 UTC (permalink / raw)
To: Romain Perier; +Cc: Kernel Hardening
On Tue, Jun 18, 2019 at 07:56:42PM +0200, Romain Perier wrote:
> Hi !
>
> Here a first review, you can get the complete list here:
>
> https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
Cool! You identified three issues:
net/netfilter/nfnetlink_cthelper.c:
NF_CT_HELPER_NAME_LEN is used instead of NF_CT_EXP_POLICY_NAME_LEN
net/netfilter/ipset/ip_set_list_set.c:
IPSET_ATTR_NAME and IPSET_ATTR_NAMEREF both have a len of
IPSET_MAXNAMELEN for a string of size IPSET_MAXNAMELEN
net/openvswitch/conntrack.c:
maxlen of NF_CT_HELPER_NAME_LEN with a string of size
NF_CT_HELPER_NAME_LEN. maxlen of CTNL_TIMEOUT_NAME_MAX with a
string of size CTNL_TIMEOUT_NAME_MAX
I haven't looked closely at this myself yet, but I think the next step
would be to write patches for each of these. And while doing that, have
an eye toward thinking about how each case could be made more robust in
the future to avoid these kinds of flaws returning.
Nice!
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Audit and fix all misuse of NLA_STRING: STATUS
2019-06-20 16:15 ` Kees Cook
@ 2019-06-21 10:54 ` Romain Perier
2019-06-25 16:42 ` Romain Perier
0 siblings, 1 reply; 6+ messages in thread
From: Romain Perier @ 2019-06-21 10:54 UTC (permalink / raw)
To: Kees Cook; +Cc: Kernel Hardening
Hi!
Yeah, I have found some inconsistencies, but I am not 100% sure for
all of these. I will double check and review the code closely.
I keep you in touch.
Regards,
Romain
Le jeu. 20 juin 2019 à 18:15, Kees Cook <keescook@chromium.org> a écrit :
>
> On Tue, Jun 18, 2019 at 07:56:42PM +0200, Romain Perier wrote:
> > Hi !
> >
> > Here a first review, you can get the complete list here:
> >
> > https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
>
> Cool! You identified three issues:
>
> net/netfilter/nfnetlink_cthelper.c:
> NF_CT_HELPER_NAME_LEN is used instead of NF_CT_EXP_POLICY_NAME_LEN
>
> net/netfilter/ipset/ip_set_list_set.c:
> IPSET_ATTR_NAME and IPSET_ATTR_NAMEREF both have a len of
> IPSET_MAXNAMELEN for a string of size IPSET_MAXNAMELEN
>
> net/openvswitch/conntrack.c:
> maxlen of NF_CT_HELPER_NAME_LEN with a string of size
> NF_CT_HELPER_NAME_LEN. maxlen of CTNL_TIMEOUT_NAME_MAX with a
> string of size CTNL_TIMEOUT_NAME_MAX
>
> I haven't looked closely at this myself yet, but I think the next step
> would be to write patches for each of these. And while doing that, have
> an eye toward thinking about how each case could be made more robust in
> the future to avoid these kinds of flaws returning.
>
> Nice!
>
> --
> Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Audit and fix all misuse of NLA_STRING: STATUS
2019-06-21 10:54 ` Romain Perier
@ 2019-06-25 16:42 ` Romain Perier
2019-06-26 23:51 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Romain Perier @ 2019-06-25 16:42 UTC (permalink / raw)
To: Kees Cook; +Cc: Kernel Hardening
Hi,
I have double checked.
See, https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
Nothing worrying, it seems.
Regards,
Romain
Le ven. 21 juin 2019 à 12:54, Romain Perier <romain.perier@gmail.com> a écrit :
>
> Hi!
>
> Yeah, I have found some inconsistencies, but I am not 100% sure for
> all of these. I will double check and review the code closely.
> I keep you in touch.
>
> Regards,
> Romain
>
> Le jeu. 20 juin 2019 à 18:15, Kees Cook <keescook@chromium.org> a écrit :
> >
> > On Tue, Jun 18, 2019 at 07:56:42PM +0200, Romain Perier wrote:
> > > Hi !
> > >
> > > Here a first review, you can get the complete list here:
> > >
> > > https://salsa.debian.org/rperier-guest/linux-tree/raw/next/STATUS
> >
> > Cool! You identified three issues:
> >
> > net/netfilter/nfnetlink_cthelper.c:
> > NF_CT_HELPER_NAME_LEN is used instead of NF_CT_EXP_POLICY_NAME_LEN
> >
> > net/netfilter/ipset/ip_set_list_set.c:
> > IPSET_ATTR_NAME and IPSET_ATTR_NAMEREF both have a len of
> > IPSET_MAXNAMELEN for a string of size IPSET_MAXNAMELEN
> >
> > net/openvswitch/conntrack.c:
> > maxlen of NF_CT_HELPER_NAME_LEN with a string of size
> > NF_CT_HELPER_NAME_LEN. maxlen of CTNL_TIMEOUT_NAME_MAX with a
> > string of size CTNL_TIMEOUT_NAME_MAX
> >
> > I haven't looked closely at this myself yet, but I think the next step
> > would be to write patches for each of these. And while doing that, have
> > an eye toward thinking about how each case could be made more robust in
> > the future to avoid these kinds of flaws returning.
> >
> > Nice!
> >
> > --
> > Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-27 14:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 17:56 Audit and fix all misuse of NLA_STRING: STATUS Romain Perier
2019-06-20 16:15 ` Kees Cook
2019-06-21 10:54 ` Romain Perier
2019-06-25 16:42 ` Romain Perier
2019-06-26 23:51 ` Kees Cook
[not found] ` <CABgxDoJJo=AUHc1vWMeBpZHnMeBdRHSFnXWuN4RZwWnmB-9nBg@mail.gmail.com>
2019-06-27 14:30 ` Fwd: " Romain Perier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.