* [PATCH SBC] Fix for build on windows mingw @ 2016-08-02 15:14 Ilya Averyanov 2016-08-03 10:21 ` Luiz Augusto von Dentz 0 siblings, 1 reply; 6+ messages in thread From: Ilya Averyanov @ 2016-08-02 15:14 UTC (permalink / raw) To: linux-bluetooth --- sbc/sbc_math.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbc/sbc_math.h b/sbc/sbc_math.h index 5476860..25b08ea 100644 --- a/sbc/sbc_math.h +++ b/sbc/sbc_math.h @@ -24,6 +24,8 @@ * */ +#include <stdint.h> + #define fabs(x) ((x) < 0 ? -(x) : (x)) /* C does not provide an explicit arithmetic shift right but this will always be correct and every compiler *should* generate optimal code */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH SBC] Fix for build on windows mingw 2016-08-02 15:14 [PATCH SBC] Fix for build on windows mingw Ilya Averyanov @ 2016-08-03 10:21 ` Luiz Augusto von Dentz 2016-08-04 15:19 ` Ilya Averyanov 0 siblings, 1 reply; 6+ messages in thread From: Luiz Augusto von Dentz @ 2016-08-03 10:21 UTC (permalink / raw) To: Ilya Averyanov; +Cc: linux-bluetooth Hi Ilya, On Tue, Aug 2, 2016 at 6:14 PM, Ilya Averyanov <averyanovin@gmail.com> wrote: Please add some description, perhaps with the error caused by the lack of this include. > --- > sbc/sbc_math.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sbc/sbc_math.h b/sbc/sbc_math.h > index 5476860..25b08ea 100644 > --- a/sbc/sbc_math.h > +++ b/sbc/sbc_math.h > @@ -24,6 +24,8 @@ > * > */ > > +#include <stdint.h> > + > #define fabs(x) ((x) < 0 ? -(x) : (x)) > /* C does not provide an explicit arithmetic shift right but this will > always be correct and every compiler *should* generate optimal code */ > -- > 2.7.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SBC] Fix for build on windows mingw 2016-08-03 10:21 ` Luiz Augusto von Dentz @ 2016-08-04 15:19 ` Ilya Averyanov 2016-10-04 14:09 ` Ilya Averyanov 0 siblings, 1 reply; 6+ messages in thread From: Ilya Averyanov @ 2016-08-04 15:19 UTC (permalink / raw) To: Luiz Augusto von Dentz; +Cc: linux-bluetooth Errors occur because mingw int32_t type and other types define only in stdint.h make --no-print-directory all-am CC sbc/sbc.lo In file included from sbc/sbc.c:40:0: sbc/sbc_math.h:42:9: error: unknown type name ‘int32_t’ typedef int32_t sbc_fixed_t; ^ In file included from sbc/sbc.c:41:0: sbc/sbc_tables.h:51:14: error: unknown type name ‘int32_t’ static const int32_t sbc_proto_4_40m0[] = { ^ In file included from sbc/sbc.c:40:0: sbc/sbc_math.h:31:6: error: ‘int32_t’ undeclared here (not in a function) ((int32_t)(val)) >> (bits) : ((int32_t) (val)) / (1 << (bits))) ^ sbc/sbc_tables.h:46:18: note: in expansion of macro ‘ASR’ #define SS4(val) ASR(val, SCALE_SPROTO4_TBL) ^ sbc/sbc_tables.h:52:2: note: in expansion of macro ‘SS4’ SS4(0x00000000), SS4(0xffa6982f), SS4(0xfba93848), SS4(0x0456c7b8), ^ In file included from sbc/sbc.c:41:0: sbc/sbc_tables.h:59:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘sbc_proto_4_40m1’ static const int32_t sbc_proto_4_40m1[] = { ^ sbc/sbc_tables.h:67:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘sbc_proto_8_80m0’ static const int32_t sbc_proto_8_80m0[] = { ^ sbc/sbc_tables.h:80:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘sbc_proto_8_80m1’ static const int32_t sbc_proto_8_80m1[] = { ^ sbc/sbc_tables.h:93:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘synmatrix4’ static const int32_t synmatrix4[8][4] = { ^ sbc/sbc_tables.h:104:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘synmatrix8’ static const int32_t synmatrix8[16][8] = { ^ sbc/sbc_tables.h:145:17: error: unknown type name ‘int16_t’ #define FIXED_T int16_t /* data type for fixed point constants */ .... 2016-08-03 13:21 GMT+03:00 Luiz Augusto von Dentz <luiz.dentz@gmail.com>: > Hi Ilya, > > On Tue, Aug 2, 2016 at 6:14 PM, Ilya Averyanov <averyanovin@gmail.com> wrote: > > Please add some description, perhaps with the error caused by the lack > of this include. > >> --- >> sbc/sbc_math.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/sbc/sbc_math.h b/sbc/sbc_math.h >> index 5476860..25b08ea 100644 >> --- a/sbc/sbc_math.h >> +++ b/sbc/sbc_math.h >> @@ -24,6 +24,8 @@ >> * >> */ >> >> +#include <stdint.h> >> + >> #define fabs(x) ((x) < 0 ? -(x) : (x)) >> /* C does not provide an explicit arithmetic shift right but this will >> always be correct and every compiler *should* generate optimal code */ >> -- >> 2.7.4 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SBC] Fix for build on windows mingw 2016-08-04 15:19 ` Ilya Averyanov @ 2016-10-04 14:09 ` Ilya Averyanov 2016-10-04 14:22 ` Johan Hedberg 0 siblings, 1 reply; 6+ messages in thread From: Ilya Averyanov @ 2016-10-04 14:09 UTC (permalink / raw) Cc: linux-bluetooth What about the patch? 2016-08-04 18:19 GMT+03:00 Ilya Averyanov <averyanovin@gmail.com>: > Errors occur because mingw int32_t type and other types define only in st= dint.h > make --no-print-directory all-am > CC sbc/sbc.lo > In file included from sbc/sbc.c:40:0: > sbc/sbc_math.h:42:9: error: unknown type name =E2=80=98int32_t=E2=80=99 > typedef int32_t sbc_fixed_t; > ^ > In file included from sbc/sbc.c:41:0: > sbc/sbc_tables.h:51:14: error: unknown type name =E2=80=98int32_t=E2=80= =99 > static const int32_t sbc_proto_4_40m0[] =3D { > ^ > In file included from sbc/sbc.c:40:0: > sbc/sbc_math.h:31:6: error: =E2=80=98int32_t=E2=80=99 undeclared here (no= t in a function) > ((int32_t)(val)) >> (bits) : ((int32_t) (val)) / (1 << (bits))) > ^ > sbc/sbc_tables.h:46:18: note: in expansion of macro =E2=80=98ASR=E2=80=99 > #define SS4(val) ASR(val, SCALE_SPROTO4_TBL) > ^ > sbc/sbc_tables.h:52:2: note: in expansion of macro =E2=80=98SS4=E2=80=99 > SS4(0x00000000), SS4(0xffa6982f), SS4(0xfba93848), SS4(0x0456c7b8), > ^ > In file included from sbc/sbc.c:41:0: > sbc/sbc_tables.h:59:22: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,= =E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or > =E2=80=98__attribute__=E2=80=99 before =E2=80=98sbc_proto_4_40m1=E2=80=99 > static const int32_t sbc_proto_4_40m1[] =3D { > ^ > sbc/sbc_tables.h:67:22: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,= =E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or > =E2=80=98__attribute__=E2=80=99 before =E2=80=98sbc_proto_8_80m0=E2=80=99 > static const int32_t sbc_proto_8_80m0[] =3D { > ^ > sbc/sbc_tables.h:80:22: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,= =E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or > =E2=80=98__attribute__=E2=80=99 before =E2=80=98sbc_proto_8_80m1=E2=80=99 > static const int32_t sbc_proto_8_80m1[] =3D { > ^ > sbc/sbc_tables.h:93:22: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,= =E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or > =E2=80=98__attribute__=E2=80=99 before =E2=80=98synmatrix4=E2=80=99 > static const int32_t synmatrix4[8][4] =3D { > ^ > sbc/sbc_tables.h:104:22: error: expected =E2=80=98=3D=E2=80=99, =E2=80=98= ,=E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or > =E2=80=98__attribute__=E2=80=99 before =E2=80=98synmatrix8=E2=80=99 > static const int32_t synmatrix8[16][8] =3D { > ^ > sbc/sbc_tables.h:145:17: error: unknown type name =E2=80=98int16_t=E2=80= =99 > #define FIXED_T int16_t /* data type for fixed point constants */ > .... > > 2016-08-03 13:21 GMT+03:00 Luiz Augusto von Dentz <luiz.dentz@gmail.com>: >> Hi Ilya, >> >> On Tue, Aug 2, 2016 at 6:14 PM, Ilya Averyanov <averyanovin@gmail.com> w= rote: >> >> Please add some description, perhaps with the error caused by the lack >> of this include. >> >>> --- >>> sbc/sbc_math.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/sbc/sbc_math.h b/sbc/sbc_math.h >>> index 5476860..25b08ea 100644 >>> --- a/sbc/sbc_math.h >>> +++ b/sbc/sbc_math.h >>> @@ -24,6 +24,8 @@ >>> * >>> */ >>> >>> +#include <stdint.h> >>> + >>> #define fabs(x) ((x) < 0 ? -(x) : (x)) >>> /* C does not provide an explicit arithmetic shift right but this will >>> always be correct and every compiler *should* generate optimal code= */ >>> -- >>> 2.7.4 >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-bluetoo= th" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> >> -- >> Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SBC] Fix for build on windows mingw 2016-10-04 14:09 ` Ilya Averyanov @ 2016-10-04 14:22 ` Johan Hedberg 2016-10-04 15:24 ` Ilya Averyanov 0 siblings, 1 reply; 6+ messages in thread From: Johan Hedberg @ 2016-10-04 14:22 UTC (permalink / raw) To: Ilya Averyanov; +Cc: linux-bluetooth Hi Ilya, On Tue, Oct 04, 2016, Ilya Averyanov wrote: > What about the patch? I think Luiz meant for you to resend the patch with the added information in the commit message. You can adjust the commit message in your local tree using git commit --amend. Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH SBC] Fix for build on windows mingw 2016-10-04 14:22 ` Johan Hedberg @ 2016-10-04 15:24 ` Ilya Averyanov 0 siblings, 0 replies; 6+ messages in thread From: Ilya Averyanov @ 2016-10-04 15:24 UTC (permalink / raw) To: linux-bluetooth >From b2fdd53da7c684b56580c1332a25507530a5702e Mon Sep 17 00:00:00 2001 From: Ilya Averyanov <averyanovin@gmail.com> Date: Tue, 4 Oct 2016 17:47:17 +0300 Subject: [PATCH] Fix error for build on windows mingw Errors occur because int32_t type and other types define only in stdint.h and mingw not include this file by default --- sbc/sbc_math.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbc/sbc_math.h b/sbc/sbc_math.h index 5476860..25b08ea 100644 --- a/sbc/sbc_math.h +++ b/sbc/sbc_math.h @@ -24,6 +24,8 @@ * */ +#include <stdint.h> + #define fabs(x) ((x) < 0 ? -(x) : (x)) /* C does not provide an explicit arithmetic shift right but this will always be correct and every compiler *should* generate optimal code */ -- 2.7.4 2016-10-04 17:22 GMT+03:00 Johan Hedberg <johan.hedberg@gmail.com>: > Hi Ilya, > > On Tue, Oct 04, 2016, Ilya Averyanov wrote: >> What about the patch? > > I think Luiz meant for you to resend the patch with the added > information in the commit message. You can adjust the commit message in > your local tree using git commit --amend. > > Johan ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-04 15:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-02 15:14 [PATCH SBC] Fix for build on windows mingw Ilya Averyanov 2016-08-03 10:21 ` Luiz Augusto von Dentz 2016-08-04 15:19 ` Ilya Averyanov 2016-10-04 14:09 ` Ilya Averyanov 2016-10-04 14:22 ` Johan Hedberg 2016-10-04 15:24 ` Ilya Averyanov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.