All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] USB: core: skip unconfiguration if device doesn't support it
Date: Thu, 5 May 2022 14:35:28 +0200	[thread overview]
Message-ID: <CABk-BGte-1t-DQ0CUDbzy9u+5UVKcsA0WhZU57mq6WyWsP5gmQ@mail.gmail.com> (raw)
In-Reply-To: <50d48f9e-d7b1-a05a-5fbf-2c0461b540ef@suse.com>

Hello Oliver,

No worries, as you said, Bjorn has provided a perfect test.

Yes, I have considered but I have thought that a clean and fast
solution is enough, that is, suspending everything from the driver,
because a new configuration is going to be applied when binding again
from local or remote.
Device reset may have other implications and as you commented soft
unbinding is not a common operation at least without binding again.

Best regards
José Ignacio

On Thu, May 5, 2022 at 2:07 PM Oliver Neukum <oneukum@suse.com> wrote:
>
>
>
> On 05.05.22 13:15, Jose Ignacio Tornos Martinez wrote:
> > Hello Oliver,
> >
> > Of course, I am working with usbip to remotize usb devices, that is
> > the reason why unbind/bind is needed and with the btusb devices that I
> > have, it was not working.
> >
> >
>
> Hi,
>
> sorry for being unclear. I was not referring to positive
> knowledge about the devices you are testing with.
> I was having dark thoughts about the other devices
> they are sharing an ID with.
> But Bjorn's testing has resolved that. In that case
> we can indeed not penalize the compliant devices
> for the broken ones.
>
> One question, though. Your approach of simply doing
> nothing if config 0 is to be selected again is a bit
> brutal. Have you considered resetting the device
> and stopping the reenumeration right as a config
> is supposed to be chosen?
>
>     Regards
>         Oliver
>


  reply	other threads:[~2022-05-05 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  8:36 [PATCH v4] USB: core: skip unconfiguration if device doesn't support it Jose Ignacio Tornos Martinez
2022-05-04 12:23 ` Marcel Holtmann
2022-05-04 12:32   ` Jose Ignacio Tornos Martinez
2022-05-05 10:19   ` Oliver Neukum
2022-05-05 11:15     ` Jose Ignacio Tornos Martinez
2022-05-05 12:06       ` Oliver Neukum
2022-05-05 12:35         ` Jose Ignacio Tornos Martinez [this message]
2022-05-05 11:29     ` Bjørn Mork
2022-05-05 14:14       ` Alan Stern
2022-05-05 15:22         ` Bjørn Mork
2022-05-05 16:48           ` Jose Ignacio Tornos Martinez
2022-05-05 17:04           ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABk-BGte-1t-DQ0CUDbzy9u+5UVKcsA0WhZU57mq6WyWsP5gmQ@mail.gmail.com \
    --to=jtornosm@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.