[U-Boot] [PATCH v2 8/8] arm, davinci: add support for am1808 based enbw_cmc board

From: Christian Riesch <christian.riesch@omicron.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 8/8] arm, davinci: add support for am1808 based enbw_cmc board
Date: Fri, 30 Sep 2011 11:02:21 +0200	[thread overview]
Message-ID: <CABkLObp=DjnTXua_BU4Zg=eRS9SbDyZBDtLY7Kv1MDH8napDyQ@mail.gmail.com> (raw)
In-Reply-To: <4E8581FF.3020507@denx.de>

Hello Heiko,
thanks for your reply.

On Fri, Sep 30, 2011 at 10:46 AM, Heiko Schocher <hs@denx.de> wrote:
> Christian Riesch wrote:
>> On Mon, Sep 19, 2011 at 7:50 AM, Heiko Schocher <hs@denx.de> wrote:
>>> - booting from NOR Flash with direct boot method
>>> - POST support
>>> - LOGBUF support
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>> Cc: Paulraj Sandeep <s-paulraj@ti.com>
>>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>> ---
>>> - changes for v2
>>> ?- use CONFIG_MACH_TYPE instead setting the MACH_TYPE in
>>> ? ?board specific code, as Igor Grinberg suggested.
>>> ?- add logversion=2 to default Environment
>>>
>>> ?board/enbw/enbw_cmc/Makefile ? | ? 51 ++++
>>> ?board/enbw/enbw_cmc/enbw_cmc.c | ?570 ++++++++++++++++++++++++++++++++++++++++
>>> ?boards.cfg ? ? ? ? ? ? ? ? ? ? | ? ?1 +
>>> ?include/configs/enbw_cmc.h ? ? | ?443 +++++++++++++++++++++++++++++++
>>> ?4 files changed, 1065 insertions(+), 0 deletions(-)
>>> ?create mode 100644 board/enbw/enbw_cmc/Makefile
>>> ?create mode 100644 board/enbw/enbw_cmc/enbw_cmc.c
>>> ?create mode 100644 include/configs/enbw_cmc.h
>>
>> [...]
>>
>>> diff --git a/include/configs/enbw_cmc.h b/include/configs/enbw_cmc.h
>>> new file mode 100644
>>> index 0000000..e203089
>>> --- /dev/null
>>> +++ b/include/configs/enbw_cmc.h
>>
>> [...]
>>
>>> +#define CONFIG_SYS_AM1808_PLL0_PLLM ? ?37 ? ? ?/* PLL0 -> 456 MHz */
>>
>> With a 24 MHz input frequency this would result in a PLL0 frequency of
>> 24MHz / PREDIV * (CONFIG_SYS_AM1808_PLL0_PLLM + 1), so I guess you
>> assume a PREDIV of 2 here (PREDIV register value 0x00008001). However,
>
> No. The comment is wrong! I fix the comment from PLL0 to PLLC0
> in the next patch version, thanks!

Ok.

>> the AM1808 datasheet and the reference guide (section 7.3.10) state
>> that the default PREDIV is 1 (register value 0x00008000) and I don't
>> see how you set the PREDIV to 2. Am I missing something here?
>
> For calculating the resulting frequencies for the used Sysclocks
> don;t forget the POSTDIV value
>
> #define CONFIG_SYS_AM1808_PLL0_POSTDIV ?1
>
> So the correct calculation is:
>
> (24MHz / PREDIV * (CONFIG_SYS_AM1808_PLL0_PLLM + 1)) / POSTDIV
>
> (And with that, I get 456 MHz ;-)

But then you would be running PLL0 with 24MHz *
(CONFIG_SYS_AM1808_PLL0_PLLM + 1) = 912 MHz !? That would be out of
specs since the PLL output frequency must be between 300 and 600 MHz
according to the datasheet.

However, you can't set the PLLM to 37 anyway, since it's only a 5 bit
field, (37 & 0x1f) results in 5, so you only multiply the frequency by
6 in the PLL, resulting in 144MHz PLL frequency.

Regards, Christian