From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Subject: Re: [RFC PATCH] can: add tx/rx led trigger support
Date: Thu, 12 Apr 2012 19:46:41 +0200 [thread overview]
Message-ID: <CABkP77c1N_b=xtA_Hz=ZxYNDS6FxJEFhi4yhhpST-kfS4wx2zg@mail.gmail.com> (raw)
In-Reply-To: <4F86862C.5020007@grandegger.com>
On Thu, Apr 12, 2012 at 9:37 AM, Wolfgang Grandegger <wg@grandegger.com> wrote:
>> It stays on for some time after each frame. Above a certain
>> packet-rate (1/led_off_delay) LED appear to be constantly on. You can
>> tell periodic packets from bursts from it but nothing more.
>
> Concerning the LED control (on. off, blinking), could that not be
> done/configured in the generic LED interface (via sysfs files)? That
> seems the right place for me. Then the CAN LED software just needs to
> send the trigger which would significantly simplify the code (without
> timer).
Of course, that's possible, but I think a kernel implementation with
timers for blinking and some well placed trigger points would be more
effective that, for example, polling interface stats from userspace.
After all many other subsystems have similar triggers in kernel space
(netfilter, ide/ata with timers, mtd, mmc, mac80211 without triggers).
> Furthermore, if I understand your patch correctly, the LEDs with the
> names "canX-rx" and "canX-tx" are directly assigned (hardwired). A more
> flexible method would be appreciated, if it could be realized with just
> a little more code.
Well, they are just sprintf-ed from initial interface name, that's
also how mac80211 implementation works. Can you be more specific on
how should I change it? Like following interface rename or so?
Regards.
--
Fabio Baltieri
next prev parent reply other threads:[~2012-04-12 17:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:39 [RFC PATCH] can: add tx/rx led trigger support Fabio Baltieri
2012-04-11 6:14 ` Oliver Hartkopp
2012-04-11 17:58 ` Fabio Baltieri
2012-04-11 18:29 ` Oliver Hartkopp
2012-04-11 18:58 ` Wolfgang Grandegger
2012-04-12 6:16 ` Oliver Hartkopp
2012-04-11 19:02 ` Oliver Hartkopp
2012-04-11 19:36 ` Fabio Baltieri
2012-04-12 6:05 ` Oliver Hartkopp
2012-04-12 6:32 ` Alexander Stein
2012-04-12 15:52 ` Oliver Hartkopp
2012-04-12 18:30 ` Fabio Baltieri
2012-04-13 19:00 ` Oliver Hartkopp
2012-04-12 7:37 ` Wolfgang Grandegger
2012-04-12 11:07 ` Martin Gysel
2012-04-12 16:02 ` Oliver Hartkopp
2012-04-12 16:13 ` Wolfgang Grandegger
2012-04-12 17:28 ` Fabio Baltieri
2012-04-12 18:47 ` Wolfgang Grandegger
2012-04-12 17:46 ` Fabio Baltieri [this message]
2012-04-12 18:53 ` Wolfgang Grandegger
2012-04-11 6:29 ` Alexander Stein
2012-04-11 18:03 ` Fabio Baltieri
2012-04-11 14:45 ` Wolfgang Grandegger
2012-04-11 16:24 ` Oliver Hartkopp
2012-04-11 19:11 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABkP77c1N_b=xtA_Hz=ZxYNDS6FxJEFhi4yhhpST-kfS4wx2zg@mail.gmail.com' \
--to=fabio.baltieri@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.