* [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM
@ 2020-11-20 16:13 Thierry Reding
2020-11-20 16:13 ` [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM Thierry Reding
2020-11-20 20:52 ` [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Nicolas Chauvet
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2020-11-20 16:13 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Nicolas Chauvet, Jon Hunter
From: Thierry Reding <treding@nvidia.com>
For some reason this was never hooked up. Do it now so that over-current
interrupts can be logged.
Reported-by: Nicolas Chauvet <kwizart@gmail.com>
Suggested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm/boot/dts/tegra124.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 64f488ba1e72..d2714419d823 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -898,7 +898,9 @@ soctherm: thermal-sensor@700e2000 {
reg = <0x0 0x700e2000 0x0 0x600>, /* SOC_THERM reg_base */
<0x0 0x60006000 0x0 0x400>; /* CAR reg_base */
reg-names = "soctherm-reg", "car-reg";
- interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "thermal", "edp";
clocks = <&tegra_car TEGRA124_CLK_TSENSOR>,
<&tegra_car TEGRA124_CLK_SOC_THERM>;
clock-names = "tsensor", "soctherm";
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM
2020-11-20 16:13 [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Thierry Reding
@ 2020-11-20 16:13 ` Thierry Reding
2020-11-20 19:23 ` Jon Hunter
2020-11-20 20:52 ` [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Nicolas Chauvet
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2020-11-20 16:13 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Nicolas Chauvet, Jon Hunter
From: Thierry Reding <treding@nvidia.com>
For some reason this was never hooked up. Do it now so that over-current
interrupts can be logged.
Reported-by: Nicolas Chauvet <kwizart@gmail.com>
Suggested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra132.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index e40281510c0c..de420a117e59 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -865,7 +865,9 @@ soctherm: thermal-sensor@700e2000 {
reg = <0x0 0x700e2000 0x0 0x600>, /* 0: SOC_THERM reg_base */
<0x0 0x70040000 0x0 0x200>; /* 2: CCROC reg_base */
reg-names = "soctherm-reg", "ccroc-reg";
- interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
+ <GIT_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "thermal", "edp";
clocks = <&tegra_car TEGRA124_CLK_TSENSOR>,
<&tegra_car TEGRA124_CLK_SOC_THERM>;
clock-names = "tsensor", "soctherm";
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM
2020-11-20 16:13 ` [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM Thierry Reding
@ 2020-11-20 19:23 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2020-11-20 19:23 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Nicolas Chauvet
On 20/11/2020 16:13, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> For some reason this was never hooked up. Do it now so that over-current
> interrupts can be logged.
>
> Reported-by: Nicolas Chauvet <kwizart@gmail.com>
> Suggested-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index e40281510c0c..de420a117e59 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -865,7 +865,9 @@ soctherm: thermal-sensor@700e2000 {
> reg = <0x0 0x700e2000 0x0 0x600>, /* 0: SOC_THERM reg_base */
> <0x0 0x70040000 0x0 0x200>; /* 2: CCROC reg_base */
> reg-names = "soctherm-reg", "ccroc-reg";
> - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
> + <GIT_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
Looks like you got your GIT and GIC mixed up :-)
Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm64/boot/dts/nvidia/tegra132.dtsi:869.10-11 syntax error
FATAL ERROR: Unable to parse input tree
scripts/Makefile.lib:326: recipe for target 'arch/arm64/boot/dts/nvidia/tegra132-norrin.dtb' failed
make[3]: *** [arch/arm64/boot/dts/nvidia/tegra132-norrin.dtb] Error 1
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM
2020-11-20 16:13 [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Thierry Reding
2020-11-20 16:13 ` [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM Thierry Reding
@ 2020-11-20 20:52 ` Nicolas Chauvet
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Chauvet @ 2020-11-20 20:52 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Jon Hunter
Le ven. 20 nov. 2020 à 17:14, Thierry Reding
<thierry.reding@gmail.com> a écrit :
>
> From: Thierry Reding <treding@nvidia.com>
>
> For some reason this was never hooked up. Do it now so that over-current
> interrupts can be logged.
>
> Reported-by: Nicolas Chauvet <kwizart@gmail.com>
> Suggested-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm/boot/dts/tegra124.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 64f488ba1e72..d2714419d823 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -898,7 +898,9 @@ soctherm: thermal-sensor@700e2000 {
> reg = <0x0 0x700e2000 0x0 0x600>, /* SOC_THERM reg_base */
> <0x0 0x60006000 0x0 0x400>; /* CAR reg_base */
> reg-names = "soctherm-reg", "car-reg";
> - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "thermal", "edp";
> clocks = <&tegra_car TEGRA124_CLK_TSENSOR>,
> <&tegra_car TEGRA124_CLK_SOC_THERM>;
> clock-names = "tsensor", "soctherm";
Thanks for the fix. I confirm the interrupt is present on jetson-tk1.
cat /proc/interrupts |grep therm
101: 0 0 0 0 LIC 48 Level
700e2000.thermal-sensor
102: 0 0 0 0 LIC 51 Level
soctherm_edp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-20 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 16:13 [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Thierry Reding
2020-11-20 16:13 ` [PATCH 2/2] arm64: tegra: Hook up edp interrupt on Tegra132 SOCTHERM Thierry Reding
2020-11-20 19:23 ` Jon Hunter
2020-11-20 20:52 ` [PATCH 1/2] ARM: tegra: Hook up edp interrupt on Tegra124 SOCTHERM Nicolas Chauvet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.