hwtable janitoring

hwtable janitoring

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 130 bytes --]

Hi Xose,

I went through the patch backlog since June 4th and merged your work.

Best regards,
Christophe Varoqui
www.opensvc.com

[-- Attachment #1.2: Type: text/html, Size: 256 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: hwtable janitoring

[Xose Vazquez Perez]

On 06/20/2016 09:35 AM, Christophe Varoqui wrote:

> I went through the patch backlog since June 4th and merged your work.

Please delete:

add INFINIDAT devices to hardware table
9a0f22974c8de4702e083da0e255050b0d6d29f7

add TEGILE devices to hardware table
2d74e0154ac62a232ee282bb357ba74ca316642e

v2 were applied later. Sorry for not being clear that they
should have been deleted.


Thank you.

Re: hwtable janitoring

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]

Ok, done.

On Mon, Jun 20, 2016 at 9:55 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> On 06/20/2016 09:35 AM, Christophe Varoqui wrote:
>
> > I went through the patch backlog since June 4th and merged your work.
>
> Please delete:
>
> add INFINIDAT devices to hardware table
> 9a0f22974c8de4702e083da0e255050b0d6d29f7
>
> add TEGILE devices to hardware table
> 2d74e0154ac62a232ee282bb357ba74ca316642e
>
> v2 were applied later. Sorry for not being clear that they
> should have been deleted.
>
>
> Thank you.
>

[-- Attachment #1.2: Type: text/html, Size: 902 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Missing patches

[Xose Vazquez Perez]

On 06/20/2016 09:35 AM, Christophe Varoqui wrote:

> I went through the patch backlog since June 4th and merged your work.

These three are missing:
https://patchwork.kernel.org/project/dm-devel/list/?submitter=3680

- "[1/2] multipath-tools: replace spaces with tabs in defaults.h"
- "multipath-tools: fix up Apple controller family"
- "multipath-tools: RDAC border", this was more a RFC than a real patch.

And "[06/10] multipath-tools: new email address for Srinivas Ramani"
was applied, and it was waiting ACK from Srinivas. But it's up to you.

I thought you were using patchwork to handle your queue.

Re: Missing patches

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 1186 bytes --]

Thanks, I really missing the Apple controller family patch.

For "replace spaces with tabs in defaults.h" I was deferring, in doubt :
seems to be a coding style issue. Is the tabbed format agreed on with other
maintainers ? I wouldn't want to go in a patch-revert loop over this ;)

I deferred the RDAC border patch, waiting for responses to you RFC. The
one-liner "border" patch will be folded into the real patch resulting from
the argument.

Thanks,
Christophe



On Mon, Jun 20, 2016 at 1:06 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> On 06/20/2016 09:35 AM, Christophe Varoqui wrote:
>
> > I went through the patch backlog since June 4th and merged your work.
>
> These three are missing:
> https://patchwork.kernel.org/project/dm-devel/list/?submitter=3680
>
> - "[1/2] multipath-tools: replace spaces with tabs in defaults.h"
> - "multipath-tools: fix up Apple controller family"
> - "multipath-tools: RDAC border", this was more a RFC than a real patch.
>
> And "[06/10] multipath-tools: new email address for Srinivas Ramani"
> was applied, and it was waiting ACK from Srinivas. But it's up to you.
>
> I thought you were using patchwork to handle your queue.
>

[-- Attachment #1.2: Type: text/html, Size: 1864 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: Missing patches

[Xose Vazquez Perez]

On 06/20/2016 01:35 PM, Christophe Varoqui wrote:

> For "replace spaces with tabs in defaults.h" I was deferring, in doubt
> : seems to be a coding style issue. Is the tabbed format agreed on with
> other maintainers ?

Right now it's a mess:

$ sed -e 's/ /-space-/g' -e 's/\t/-tabulator-/g' libmultipath/defaults.h

#define-space-DEFAULT_UID_ATTRIBUTE-tabulator-"ID_SERIAL"
#define-space-DEFAULT_UDEVDIR-tabulator--tabulator-"/dev"
#define-space-DEFAULT_MULTIPATHDIR-tabulator-"/"-space-LIB_STRING-space-"/multipath"
#define-space-DEFAULT_SELECTOR-tabulator-"service-time-space-0"
#define-space-DEFAULT_ALIAS_PREFIX-tabulator-"mpath"
#define-space-DEFAULT_FEATURES-tabulator-"0"
#define-space-DEFAULT_HWHANDLER-tabulator-"0"
#define-space-DEFAULT_MINIO-tabulator--tabulator-1000
#define-space-DEFAULT_MINIO_RQ-tabulator-1
#define-space-DEFAULT_PGPOLICY-space--space--space--space--space--space--space-FAILOVER
#define-space-DEFAULT_FAILBACK-space--space--space--space--space--space--space--FAILBACK_MANUAL
#define-space-DEFAULT_RR_WEIGHT-space--space--space--space--space--space-RR_WEIGHT_NONE
#define-space-DEFAULT_NO_PATH_RETRY-space--space-NO_PATH_RETRY_UNDEF
#define-space-DEFAULT_VERBOSITY-tabulator-2
#define-space-DEFAULT_REASSIGN_MAPS-tabulator-0
#define-space-DEFAULT_FIND_MULTIPATHS-tabulator-0
#define-space-DEFAULT_FAST_IO_FAIL-tabulator-5
#define-space-DEFAULT_DEV_LOSS_TMO-space--space--space-600
#define-space-DEFAULT_RETAIN_HWHANDLER-space-RETAIN_HWHANDLER_OFF
#define-space-DEFAULT_DETECT_PRIO-space-DETECT_PRIO_OFF
#define-space-DEFAULT_DEFERRED_REMOVE-space-DEFERRED_REMOVE_OFF
#define-space-DEFAULT_DELAY_CHECKS-space-DELAY_CHECKS_OFF
#define-space-DEFAULT_UEVENT_STACKSIZE-space-256
#define-space-DEFAULT_RETRIGGER_DELAY-space-10
#define-space-DEFAULT_RETRIGGER_TRIES-space-3
#define-space-DEFAULT_UEV_WAIT_TIMEOUT-space-30

#define-space-DEFAULT_CHECKINT-tabulator-5
#define-space-MAX_CHECKINT(a)-tabulator--tabulator-(a-space-<<-space-2)

#define-space-MAX_DEV_LOSS_TMO-tabulator-0x7FFFFFFF
#define-space-DEFAULT_PIDFILE-tabulator--tabulator-"/"-space-RUN_DIR-space-"/multipathd.pid"
#define-space-DEFAULT_SOCKET-tabulator--tabulator-"/org/kernel/linux/storage/multipathd"
#define-space-DEFAULT_CONFIGFILE-tabulator-"/etc/multipath.conf"
#define-space-DEFAULT_BINDINGS_FILE-tabulator-"/etc/multipath/bindings"
#define-space-DEFAULT_WWIDS_FILE-tabulator-"/etc/multipath/wwids"
#define-space-DEFAULT_CONFIG_DIR-tabulator-"/etc/multipath/conf.d"

char-space-*-space-set_default-space-(char-space-*-space-str);

> I wouldn't want to go in a patch-revert loop over this ;)

With git it's easy: https://www.atlassian.com/git/tutorials/undoing-changes/