* [PATCH 0/3] ARM: dts: Add display DT changes for snow, peach_pit and peach_pi
@ 2014-07-25 19:44 ` Ajay Kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel
This series is based on dt-samsung branch of Kukjin's samsung repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
Add DT changes needed for bridge chips, panels and backlight on snow,
peach_pit and peach_pi.
To test these patches, you need the latest version of bridge chip series:
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34667.html
Ajay Kumar (3):
[PATCH 1/3] ARM: dts: Add DT changes for display on snow
[PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
[PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++-------------
arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++------------
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 +++++++------------
3 files changed, 50 insertions(+), 53 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/3] ARM: dts: Add DT changes for display on snow
2014-07-25 19:44 ` Ajay Kumar
@ 2014-07-25 19:44 ` Ajay Kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g, Ajay Kumar
Add DT nodes for ptn3460 bridge chip and panel-simple panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on snow.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 6c36d41..f57f993 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -270,7 +270,7 @@
dcdc3 {
ti,enable-ext-control;
};
- fet1 {
+ fet1: fet1 {
regulator-name = "vcd_led";
ti,overcurrent-wait = <3>;
};
@@ -293,7 +293,7 @@
regulator-always-on;
ti,overcurrent-wait = <3>;
};
- fet6 {
+ fet6: fet6 {
regulator-name = "lcd_vdd";
ti,overcurrent-wait = <3>;
};
@@ -342,6 +342,15 @@
pinctrl-0 = <&max98095_en>;
pinctrl-names = "default";
};
+
+ ptn3460: ptn3460-bridge@20 {
+ compatible = "nxp,ptn3460";
+ reg = <0x20>;
+ powerdown-gpios = <&gpy2 5 0>;
+ reset-gpios = <&gpx1 5 0>;
+ edid-emulation = <5>;
+ panel = <&panel>;
+ };
};
i2s0: i2s@03830000 {
@@ -389,11 +398,13 @@
vdd_pll-supply = <&ldo8_reg>;
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ enable-gpios = <&gpx3 0 0>;
+ power-supply = <&fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -403,6 +414,12 @@
samsung,invert-vclk;
};
+ panel: panel-simple {
+ compatible = "simple-panel";
+ power-supply = <&fet6>;
+ backlight = <&backlight>;
+ };
+
dp-controller@145B0000 {
status = "okay";
pinctrl-names = "default";
@@ -414,21 +431,6 @@
samsung,link-rate = <0x0a>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx0 7 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing@1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ptn3460>;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 1/3] ARM: dts: Add DT changes for display on snow
@ 2014-07-25 19:44 ` Ajay Kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel
Add DT nodes for ptn3460 bridge chip and panel-simple panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on snow.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index 6c36d41..f57f993 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -270,7 +270,7 @@
dcdc3 {
ti,enable-ext-control;
};
- fet1 {
+ fet1: fet1 {
regulator-name = "vcd_led";
ti,overcurrent-wait = <3>;
};
@@ -293,7 +293,7 @@
regulator-always-on;
ti,overcurrent-wait = <3>;
};
- fet6 {
+ fet6: fet6 {
regulator-name = "lcd_vdd";
ti,overcurrent-wait = <3>;
};
@@ -342,6 +342,15 @@
pinctrl-0 = <&max98095_en>;
pinctrl-names = "default";
};
+
+ ptn3460: ptn3460-bridge at 20 {
+ compatible = "nxp,ptn3460";
+ reg = <0x20>;
+ powerdown-gpios = <&gpy2 5 0>;
+ reset-gpios = <&gpx1 5 0>;
+ edid-emulation = <5>;
+ panel = <&panel>;
+ };
};
i2s0: i2s at 03830000 {
@@ -389,11 +398,13 @@
vdd_pll-supply = <&ldo8_reg>;
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ enable-gpios = <&gpx3 0 0>;
+ power-supply = <&fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -403,6 +414,12 @@
samsung,invert-vclk;
};
+ panel: panel-simple {
+ compatible = "simple-panel";
+ power-supply = <&fet6>;
+ backlight = <&backlight>;
+ };
+
dp-controller at 145B0000 {
status = "okay";
pinctrl-names = "default";
@@ -414,21 +431,6 @@
samsung,link-rate = <0x0a>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx0 7 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing at 1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ptn3460>;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 1/3] ARM: dts: Add DT changes for display on snow
2014-07-25 19:44 ` Ajay Kumar
@ 2014-08-23 10:47 ` Andreas Färber
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:47 UTC (permalink / raw)
To: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g, Thierry Reding
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for ptn3460 bridge chip and panel-simple panel.
"simple-panel"
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on snow.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
> 1 file changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 6c36d41..f57f993 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -270,7 +270,7 @@
> dcdc3 {
> ti,enable-ext-control;
> };
> - fet1 {
> + fet1: fet1 {
> regulator-name = "vcd_led";
> ti,overcurrent-wait = <3>;
> };
> @@ -293,7 +293,7 @@
> regulator-always-on;
> ti,overcurrent-wait = <3>;
> };
> - fet6 {
> + fet6: fet6 {
> regulator-name = "lcd_vdd";
> ti,overcurrent-wait = <3>;
> };
> @@ -342,6 +342,15 @@
> pinctrl-0 = <&max98095_en>;
> pinctrl-names = "default";
> };
> +
> + ptn3460: ptn3460-bridge@20 {
"lvds-bridge"? (AF)
> + compatible = "nxp,ptn3460";
> + reg = <0x20>;
> + powerdown-gpios = <&gpy2 5 0>;
> + reset-gpios = <&gpx1 5 0>;
> + edid-emulation = <5>;
> + panel = <&panel>;
> + };
> };
>
> i2s0: i2s@03830000 {
> @@ -389,11 +398,13 @@
> vdd_pll-supply = <&ldo8_reg>;
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + enable-gpios = <&gpx3 0 0>;
> + power-supply = <&fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -403,6 +414,12 @@
> samsung,invert-vclk;
> };
>
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "simple-panel";
Use something more concrete than "simple-panel"? (Thierry)
> + power-supply = <&fet6>;
> + backlight = <&backlight>;
> + };
> +
> dp-controller@145B0000 {
> status = "okay";
> pinctrl-names = "default";
> @@ -414,21 +431,6 @@
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx0 7 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing@1 {
> - clock-frequency = <70589280>;
> - hactive = <1366>;
> - vactive = <768>;
> - hfront-porch = <40>;
> - hback-porch = <40>;
> - hsync-len = <32>;
> - vback-porch = <10>;
> - vfront-porch = <12>;
> - vsync-len = <6>;
> - };
> - };
> + bridge = <&ptn3460>;
> };
> };
This patch will trivially conflict with my Snow cleanup [1]; ptn3460
would go into the appropriate &i2c_* and this hunk into &dp then.
Regards,
Andreas
[1] https://patchwork.kernel.org/patch/4664801/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/3] ARM: dts: Add DT changes for display on snow
@ 2014-08-23 10:47 ` Andreas Färber
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:47 UTC (permalink / raw)
To: linux-arm-kernel
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for ptn3460 bridge chip and panel-simple panel.
"simple-panel"
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on snow.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
> 1 file changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 6c36d41..f57f993 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -270,7 +270,7 @@
> dcdc3 {
> ti,enable-ext-control;
> };
> - fet1 {
> + fet1: fet1 {
> regulator-name = "vcd_led";
> ti,overcurrent-wait = <3>;
> };
> @@ -293,7 +293,7 @@
> regulator-always-on;
> ti,overcurrent-wait = <3>;
> };
> - fet6 {
> + fet6: fet6 {
> regulator-name = "lcd_vdd";
> ti,overcurrent-wait = <3>;
> };
> @@ -342,6 +342,15 @@
> pinctrl-0 = <&max98095_en>;
> pinctrl-names = "default";
> };
> +
> + ptn3460: ptn3460-bridge at 20 {
"lvds-bridge"? (AF)
> + compatible = "nxp,ptn3460";
> + reg = <0x20>;
> + powerdown-gpios = <&gpy2 5 0>;
> + reset-gpios = <&gpx1 5 0>;
> + edid-emulation = <5>;
> + panel = <&panel>;
> + };
> };
>
> i2s0: i2s at 03830000 {
> @@ -389,11 +398,13 @@
> vdd_pll-supply = <&ldo8_reg>;
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + enable-gpios = <&gpx3 0 0>;
> + power-supply = <&fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -403,6 +414,12 @@
> samsung,invert-vclk;
> };
>
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "simple-panel";
Use something more concrete than "simple-panel"? (Thierry)
> + power-supply = <&fet6>;
> + backlight = <&backlight>;
> + };
> +
> dp-controller at 145B0000 {
> status = "okay";
> pinctrl-names = "default";
> @@ -414,21 +431,6 @@
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx0 7 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing at 1 {
> - clock-frequency = <70589280>;
> - hactive = <1366>;
> - vactive = <768>;
> - hfront-porch = <40>;
> - hback-porch = <40>;
> - hsync-len = <32>;
> - vback-porch = <10>;
> - vfront-porch = <12>;
> - vsync-len = <6>;
> - };
> - };
> + bridge = <&ptn3460>;
> };
> };
This patch will trivially conflict with my Snow cleanup [1]; ptn3460
would go into the appropriate &i2c_* and this hunk into &dp then.
Regards,
Andreas
[1] https://patchwork.kernel.org/patch/4664801/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/3] ARM: dts: Add DT changes for display on snow
2014-08-23 10:47 ` Andreas Färber
@ 2014-08-25 6:08 ` Ajay kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:08 UTC (permalink / raw)
To: Andreas Färber
Cc: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree,
Kukjin Kim, Doug Anderson, sunil joshi, Prashanth G,
Thierry Reding
On Sat, Aug 23, 2014 at 4:17 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for ptn3460 bridge chip and panel-simple panel.
>
> "simple-panel"
Ok.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add bridge phandle needed by dp to enable display on snow.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
>> 1 file changed, 21 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 6c36d41..f57f993 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -270,7 +270,7 @@
>> dcdc3 {
>> ti,enable-ext-control;
>> };
>> - fet1 {
>> + fet1: fet1 {
>> regulator-name = "vcd_led";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -293,7 +293,7 @@
>> regulator-always-on;
>> ti,overcurrent-wait = <3>;
>> };
>> - fet6 {
>> + fet6: fet6 {
>> regulator-name = "lcd_vdd";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -342,6 +342,15 @@
>> pinctrl-0 = <&max98095_en>;
>> pinctrl-names = "default";
>> };
>> +
>> + ptn3460: ptn3460-bridge@20 {
>
> "lvds-bridge"? (AF)
Ok.
>> + compatible = "nxp,ptn3460";
>> + reg = <0x20>;
>> + powerdown-gpios = <&gpy2 5 0>;
>> + reset-gpios = <&gpx1 5 0>;
>> + edid-emulation = <5>;
>> + panel = <&panel>;
>> + };
>> };
>>
>> i2s0: i2s@03830000 {
>> @@ -389,11 +398,13 @@
>> vdd_pll-supply = <&ldo8_reg>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx3 0 0>;
>> + power-supply = <&fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -403,6 +414,12 @@
>> samsung,invert-vclk;
>> };
>>
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>
>> + compatible = "simple-panel";
>
> Use something more concrete than "simple-panel"? (Thierry)
Right.
>> + power-supply = <&fet6>;
>> + backlight = <&backlight>;
>> + };
>> +
>> dp-controller@145B0000 {
>> status = "okay";
>> pinctrl-names = "default";
>> @@ -414,21 +431,6 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx0 7 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing@1 {
>> - clock-frequency = <70589280>;
>> - hactive = <1366>;
>> - vactive = <768>;
>> - hfront-porch = <40>;
>> - hback-porch = <40>;
>> - hsync-len = <32>;
>> - vback-porch = <10>;
>> - vfront-porch = <12>;
>> - vsync-len = <6>;
>> - };
>> - };
>> + bridge = <&ptn3460>;
>> };
>> };
>
> This patch will trivially conflict with my Snow cleanup [1]; ptn3460
> would go into the appropriate &i2c_* and this hunk into &dp then.
Yes, display-timings node should be removed from the DP DT node.
Should I rebase these DT patches on top of your cleanup series?
Ajay
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/3] ARM: dts: Add DT changes for display on snow
@ 2014-08-25 6:08 ` Ajay kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:08 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 23, 2014 at 4:17 PM, Andreas F?rber <afaerber@suse.de> wrote:
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for ptn3460 bridge chip and panel-simple panel.
>
> "simple-panel"
Ok.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add bridge phandle needed by dp to enable display on snow.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250-snow.dts | 40 +++++++++++++++++----------------
>> 1 file changed, 21 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index 6c36d41..f57f993 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -270,7 +270,7 @@
>> dcdc3 {
>> ti,enable-ext-control;
>> };
>> - fet1 {
>> + fet1: fet1 {
>> regulator-name = "vcd_led";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -293,7 +293,7 @@
>> regulator-always-on;
>> ti,overcurrent-wait = <3>;
>> };
>> - fet6 {
>> + fet6: fet6 {
>> regulator-name = "lcd_vdd";
>> ti,overcurrent-wait = <3>;
>> };
>> @@ -342,6 +342,15 @@
>> pinctrl-0 = <&max98095_en>;
>> pinctrl-names = "default";
>> };
>> +
>> + ptn3460: ptn3460-bridge at 20 {
>
> "lvds-bridge"? (AF)
Ok.
>> + compatible = "nxp,ptn3460";
>> + reg = <0x20>;
>> + powerdown-gpios = <&gpy2 5 0>;
>> + reset-gpios = <&gpx1 5 0>;
>> + edid-emulation = <5>;
>> + panel = <&panel>;
>> + };
>> };
>>
>> i2s0: i2s at 03830000 {
>> @@ -389,11 +398,13 @@
>> vdd_pll-supply = <&ldo8_reg>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx3 0 0>;
>> + power-supply = <&fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -403,6 +414,12 @@
>> samsung,invert-vclk;
>> };
>>
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>
>> + compatible = "simple-panel";
>
> Use something more concrete than "simple-panel"? (Thierry)
Right.
>> + power-supply = <&fet6>;
>> + backlight = <&backlight>;
>> + };
>> +
>> dp-controller at 145B0000 {
>> status = "okay";
>> pinctrl-names = "default";
>> @@ -414,21 +431,6 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx0 7 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing at 1 {
>> - clock-frequency = <70589280>;
>> - hactive = <1366>;
>> - vactive = <768>;
>> - hfront-porch = <40>;
>> - hback-porch = <40>;
>> - hsync-len = <32>;
>> - vback-porch = <10>;
>> - vfront-porch = <12>;
>> - vsync-len = <6>;
>> - };
>> - };
>> + bridge = <&ptn3460>;
>> };
>> };
>
> This patch will trivially conflict with my Snow cleanup [1]; ptn3460
> would go into the appropriate &i2c_* and this hunk into &dp then.
Yes, display-timings node should be removed from the DP DT node.
Should I rebase these DT patches on top of your cleanup series?
Ajay
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
2014-07-25 19:44 ` Ajay Kumar
@ 2014-07-25 19:44 ` Ajay Kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g, Ajay Kumar
Add DT nodes for ps8622 bridge chip and panel-simple panel.
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.
Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
but still we choose to reuse the binding since "chunghwa,claa101wb01"
has similar LCD timings.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..79beba8 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -30,11 +30,12 @@
i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ power-supply = <&tps65090_fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -100,6 +101,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = "chunghwa,claa101wb01", "simple-panel";
+ power-supply = <&tps65090_fet6>;
+ backlight = <&backlight>;
+ };
};
&dp {
@@ -113,22 +120,7 @@
samsung,link-rate = <0x06>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx2 6 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing@1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ps8625>;
};
&fimd {
@@ -155,6 +147,16 @@
pinctrl-names = "default";
pinctrl-0 = <&max98090_irq>;
};
+
+ ps8625: ps8625-bridge@48 {
+ compatible = "parade,ps8625";
+ reg = <0x48>;
+ sleep-gpios = <&gpx3 5 0>;
+ reset-gpios = <&gpy7 7 0>;
+ lane-count = <2>;
+ panel = <&panel>;
+ backlight = <&backlight>;
+ };
};
&hsi2c_9 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
@ 2014-07-25 19:44 ` Ajay Kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel
Add DT nodes for ps8622 bridge chip and panel-simple panel.
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.
Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
but still we choose to reuse the binding since "chunghwa,claa101wb01"
has similar LCD timings.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..79beba8 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -30,11 +30,12 @@
i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ power-supply = <&tps65090_fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -100,6 +101,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = "chunghwa,claa101wb01", "simple-panel";
+ power-supply = <&tps65090_fet6>;
+ backlight = <&backlight>;
+ };
};
&dp {
@@ -113,22 +120,7 @@
samsung,link-rate = <0x06>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx2 6 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing at 1 {
- clock-frequency = <70589280>;
- hactive = <1366>;
- vactive = <768>;
- hfront-porch = <40>;
- hback-porch = <40>;
- hsync-len = <32>;
- vback-porch = <10>;
- vfront-porch = <12>;
- vsync-len = <6>;
- };
- };
+ bridge = <&ps8625>;
};
&fimd {
@@ -155,6 +147,16 @@
pinctrl-names = "default";
pinctrl-0 = <&max98090_irq>;
};
+
+ ps8625: ps8625-bridge at 48 {
+ compatible = "parade,ps8625";
+ reg = <0x48>;
+ sleep-gpios = <&gpx3 5 0>;
+ reset-gpios = <&gpy7 7 0>;
+ lane-count = <2>;
+ panel = <&panel>;
+ backlight = <&backlight>;
+ };
};
&hsi2c_9 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
2014-07-25 19:44 ` Ajay Kumar
@ 2014-08-22 23:31 ` Javier Martinez Canillas
-1 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-22 23:31 UTC (permalink / raw)
To: Ajay Kumar
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, Kukjin Kim,
Douglas Anderson, Ajay kumar, sunil joshi, Prashanth G
Hello Ajay,
On Fri, Jul 25, 2014 at 9:44 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:
> Add DT nodes for ps8622 bridge chip and panel-simple panel.
> Add backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on peach_pit.
>
> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> has similar LCD timings.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
@ 2014-08-22 23:31 ` Javier Martinez Canillas
0 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-22 23:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello Ajay,
On Fri, Jul 25, 2014 at 9:44 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:
> Add DT nodes for ps8622 bridge chip and panel-simple panel.
> Add backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on peach_pit.
>
> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> has similar LCD timings.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
2014-07-25 19:44 ` Ajay Kumar
@ 2014-08-23 10:35 ` Andreas Färber
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:35 UTC (permalink / raw)
To: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g, Thierry Reding
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for ps8622 bridge chip and panel-simple panel.
"simple-panel"
> Add backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on peach_pit.
Note that peach_pi[t] is inconsistent with the file names being
peach-pi[t] here and in the two subjects.
>
> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> has similar LCD timings.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index 228a6b1..79beba8 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -30,11 +30,12 @@
> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + power-supply = <&tps65090_fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -100,6 +101,12 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "chunghwa,claa101wb01", "simple-panel";
Drop "simple-panel" (Thierry)
> + power-supply = <&tps65090_fet6>;
> + backlight = <&backlight>;
> + };
> };
>
> &dp {
> @@ -113,22 +120,7 @@
> samsung,link-rate = <0x06>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx2 6 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing@1 {
> - clock-frequency = <70589280>;
> - hactive = <1366>;
> - vactive = <768>;
> - hfront-porch = <40>;
> - hback-porch = <40>;
> - hsync-len = <32>;
> - vback-porch = <10>;
> - vfront-porch = <12>;
> - vsync-len = <6>;
> - };
> - };
> + bridge = <&ps8625>;
> };
>
> &fimd {
> @@ -155,6 +147,16 @@
> pinctrl-names = "default";
> pinctrl-0 = <&max98090_irq>;
> };
> +
> + ps8625: ps8625-bridge@48 {
"lvds-bridge"? (AF)
> + compatible = "parade,ps8625";
> + reg = <0x48>;
> + sleep-gpios = <&gpx3 5 0>;
> + reset-gpios = <&gpy7 7 0>;
> + lane-count = <2>;
> + panel = <&panel>;
> + backlight = <&backlight>;
> + };
> };
>
> &hsi2c_9 {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
@ 2014-08-23 10:35 ` Andreas Färber
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:35 UTC (permalink / raw)
To: linux-arm-kernel
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for ps8622 bridge chip and panel-simple panel.
"simple-panel"
> Add backlight power supply for pwm-backlight.
> Also add bridge phandle needed by dp to enable display on peach_pit.
Note that peach_pi[t] is inconsistent with the file names being
peach-pi[t] here and in the two subjects.
>
> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
> but still we choose to reuse the binding since "chunghwa,claa101wb01"
> has similar LCD timings.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index 228a6b1..79beba8 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -30,11 +30,12 @@
> i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + power-supply = <&tps65090_fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -100,6 +101,12 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "chunghwa,claa101wb01", "simple-panel";
Drop "simple-panel" (Thierry)
> + power-supply = <&tps65090_fet6>;
> + backlight = <&backlight>;
> + };
> };
>
> &dp {
> @@ -113,22 +120,7 @@
> samsung,link-rate = <0x06>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx2 6 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing at 1 {
> - clock-frequency = <70589280>;
> - hactive = <1366>;
> - vactive = <768>;
> - hfront-porch = <40>;
> - hback-porch = <40>;
> - hsync-len = <32>;
> - vback-porch = <10>;
> - vfront-porch = <12>;
> - vsync-len = <6>;
> - };
> - };
> + bridge = <&ps8625>;
> };
>
> &fimd {
> @@ -155,6 +147,16 @@
> pinctrl-names = "default";
> pinctrl-0 = <&max98090_irq>;
> };
> +
> + ps8625: ps8625-bridge at 48 {
"lvds-bridge"? (AF)
> + compatible = "parade,ps8625";
> + reg = <0x48>;
> + sleep-gpios = <&gpx3 5 0>;
> + reset-gpios = <&gpy7 7 0>;
> + lane-count = <2>;
> + panel = <&panel>;
> + backlight = <&backlight>;
> + };
> };
>
> &hsi2c_9 {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
2014-08-23 10:35 ` Andreas Färber
@ 2014-08-25 6:01 ` Ajay kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:01 UTC (permalink / raw)
To: Andreas Färber
Cc: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree,
Kukjin Kim, Doug Anderson, sunil joshi, Prashanth G,
Thierry Reding
On Sat, Aug 23, 2014 at 4:05 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for ps8622 bridge chip and panel-simple panel.
>
> "simple-panel"
Ok.
>> Add backlight power supply for pwm-backlight.
>> Also add bridge phandle needed by dp to enable display on peach_pit.
>
> Note that peach_pi[t] is inconsistent with the file names being
> peach-pi[t] here and in the two subjects.
Ok.
>>
>> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
>> but still we choose to reuse the binding since "chunghwa,claa101wb01"
>> has similar LCD timings.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
>> 1 file changed, 19 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> index 228a6b1..79beba8 100644
>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -30,11 +30,12 @@
>> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + power-supply = <&tps65090_fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -100,6 +101,12 @@
>> regulator-boot-on;
>> regulator-always-on;
>> };
>> +
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>
>> + compatible = "chunghwa,claa101wb01", "simple-panel";
>
> Drop "simple-panel" (Thierry)
Right.
>> + power-supply = <&tps65090_fet6>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &dp {
>> @@ -113,22 +120,7 @@
>> samsung,link-rate = <0x06>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx2 6 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing@1 {
>> - clock-frequency = <70589280>;
>> - hactive = <1366>;
>> - vactive = <768>;
>> - hfront-porch = <40>;
>> - hback-porch = <40>;
>> - hsync-len = <32>;
>> - vback-porch = <10>;
>> - vfront-porch = <12>;
>> - vsync-len = <6>;
>> - };
>> - };
>> + bridge = <&ps8625>;
>> };
>>
>> &fimd {
>> @@ -155,6 +147,16 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&max98090_irq>;
>> };
>> +
>> + ps8625: ps8625-bridge@48 {
>
> "lvds-bridge"? (AF)
Ok.
I will fix all these nits and resend along with the driver patches.
Ajay
>> + compatible = "parade,ps8625";
>> + reg = <0x48>;
>> + sleep-gpios = <&gpx3 5 0>;
>> + reset-gpios = <&gpy7 7 0>;
>> + lane-count = <2>;
>> + panel = <&panel>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &hsi2c_9 {
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
@ 2014-08-25 6:01 ` Ajay kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:01 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 23, 2014 at 4:05 PM, Andreas F?rber <afaerber@suse.de> wrote:
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for ps8622 bridge chip and panel-simple panel.
>
> "simple-panel"
Ok.
>> Add backlight power supply for pwm-backlight.
>> Also add bridge phandle needed by dp to enable display on peach_pit.
>
> Note that peach_pi[t] is inconsistent with the file names being
> peach-pi[t] here and in the two subjects.
Ok.
>>
>> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel,
>> but still we choose to reuse the binding since "chunghwa,claa101wb01"
>> has similar LCD timings.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++-------------
>> 1 file changed, 19 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> index 228a6b1..79beba8 100644
>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -30,11 +30,12 @@
>> i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + power-supply = <&tps65090_fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -100,6 +101,12 @@
>> regulator-boot-on;
>> regulator-always-on;
>> };
>> +
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>
>> + compatible = "chunghwa,claa101wb01", "simple-panel";
>
> Drop "simple-panel" (Thierry)
Right.
>> + power-supply = <&tps65090_fet6>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &dp {
>> @@ -113,22 +120,7 @@
>> samsung,link-rate = <0x06>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx2 6 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing at 1 {
>> - clock-frequency = <70589280>;
>> - hactive = <1366>;
>> - vactive = <768>;
>> - hfront-porch = <40>;
>> - hback-porch = <40>;
>> - hsync-len = <32>;
>> - vback-porch = <10>;
>> - vfront-porch = <12>;
>> - vsync-len = <6>;
>> - };
>> - };
>> + bridge = <&ps8625>;
>> };
>>
>> &fimd {
>> @@ -155,6 +147,16 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&max98090_irq>;
>> };
>> +
>> + ps8625: ps8625-bridge at 48 {
>
> "lvds-bridge"? (AF)
Ok.
I will fix all these nits and resend along with the driver patches.
Ajay
>> + compatible = "parade,ps8625";
>> + reg = <0x48>;
>> + sleep-gpios = <&gpx3 5 0>;
>> + reset-gpios = <&gpy7 7 0>;
>> + lane-count = <2>;
>> + panel = <&panel>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &hsi2c_9 {
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
2014-07-25 19:44 ` Ajay Kumar
@ 2014-07-25 19:44 ` Ajay Kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g, Ajay Kumar
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..5342638 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ enable-gpios = <&gpx2 2 0>;
+ power-supply = <&tps65090_fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = "auo,b133htn01", "simple-panel";
+ power-supply = <&tps65090_fet6>;
+ backlight = <&backlight>;
+ };
};
&dp {
@@ -111,22 +119,7 @@
samsung,link-rate = <0x0a>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx2 6 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing@1 {
- clock-frequency = <150660000>;
- hactive = <1920>;
- vactive = <1080>;
- hfront-porch = <60>;
- hback-porch = <172>;
- hsync-len = <80>;
- vback-porch = <25>;
- vfront-porch = <10>;
- vsync-len = <10>;
- };
- };
+ panel = <&panel>;
};
&fimd {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
@ 2014-07-25 19:44 ` Ajay Kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay Kumar @ 2014-07-25 19:44 UTC (permalink / raw)
To: linux-arm-kernel
Add DT nodes for panel-simple "auo,b133htn01" panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..5342638 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
pwms = <&pwm 0 1000000 0>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
+ enable-gpios = <&gpx2 2 0>;
+ power-supply = <&tps65090_fet1>;
pinctrl-0 = <&pwm0_out>;
pinctrl-names = "default";
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = "auo,b133htn01", "simple-panel";
+ power-supply = <&tps65090_fet6>;
+ backlight = <&backlight>;
+ };
};
&dp {
@@ -111,22 +119,7 @@
samsung,link-rate = <0x0a>;
samsung,lane-count = <2>;
samsung,hpd-gpio = <&gpx2 6 0>;
-
- display-timings {
- native-mode = <&timing1>;
-
- timing1: timing at 1 {
- clock-frequency = <150660000>;
- hactive = <1920>;
- vactive = <1080>;
- hfront-porch = <60>;
- hback-porch = <172>;
- hsync-len = <80>;
- vback-porch = <25>;
- vfront-porch = <10>;
- vsync-len = <10>;
- };
- };
+ panel = <&panel>;
};
&fimd {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
2014-07-25 19:44 ` Ajay Kumar
@ 2014-08-22 23:32 ` Javier Martinez Canillas
-1 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-22 23:32 UTC (permalink / raw)
To: Ajay Kumar
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, Kukjin Kim,
Douglas Anderson, Ajay kumar, sunil joshi, Prashanth G
Hello Ajay,
On Fri, Jul 25, 2014 at 9:44 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:
> Add DT nodes for panel-simple "auo,b133htn01" panel.
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add panel phandle needed by dp to enable display on peach_pi.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
@ 2014-08-22 23:32 ` Javier Martinez Canillas
0 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-22 23:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello Ajay,
On Fri, Jul 25, 2014 at 9:44 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:
> Add DT nodes for panel-simple "auo,b133htn01" panel.
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add panel phandle needed by dp to enable display on peach_pi.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
2014-07-25 19:44 ` Ajay Kumar
@ 2014-08-23 10:29 ` Andreas Färber
-1 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:29 UTC (permalink / raw)
To: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree
Cc: kgene.kim, dianders, ajaynumb, joshi, prashanth.g,
Javier Martinez Canillas, Thierry Reding
Seeing a Reviewed-by, I'm recording comments from another thread so that
they don't get forgotten:
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for panel-simple "auo,b133htn01" panel.
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add panel phandle needed by dp to enable display on peach_pi.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index f3ee48b..5342638 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -28,11 +28,13 @@
> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + enable-gpios = <&gpx2 2 0>;
> + power-supply = <&tps65090_fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -98,6 +100,12 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "auo,b133htn01", "simple-panel";
Drop "simple-panel" (Thierry)
> + power-supply = <&tps65090_fet6>;
> + backlight = <&backlight>;
> + };
> };
>
> &dp {
> @@ -111,22 +119,7 @@
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx2 6 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing@1 {
> - clock-frequency = <150660000>;
> - hactive = <1920>;
> - vactive = <1080>;
> - hfront-porch = <60>;
> - hback-porch = <172>;
> - hsync-len = <80>;
> - vback-porch = <25>;
> - vfront-porch = <10>;
> - vsync-len = <10>;
> - };
> - };
> + panel = <&panel>;
> };
>
> &fimd {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
@ 2014-08-23 10:29 ` Andreas Färber
0 siblings, 0 replies; 24+ messages in thread
From: Andreas Färber @ 2014-08-23 10:29 UTC (permalink / raw)
To: linux-arm-kernel
Seeing a Reviewed-by, I'm recording comments from another thread so that
they don't get forgotten:
Am 25.07.2014 21:44, schrieb Ajay Kumar:
> Add DT nodes for panel-simple "auo,b133htn01" panel.
> Add backlight enable pin and backlight power supply for pwm-backlight.
> Also add panel phandle needed by dp to enable display on peach_pi.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index f3ee48b..5342638 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -28,11 +28,13 @@
> i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
> };
>
> - backlight {
> + backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&pwm 0 1000000 0>;
> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
> default-brightness-level = <7>;
> + enable-gpios = <&gpx2 2 0>;
> + power-supply = <&tps65090_fet1>;
> pinctrl-0 = <&pwm0_out>;
> pinctrl-names = "default";
> };
> @@ -98,6 +100,12 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + panel: panel-simple {
Just "panel"? (AF)
> + compatible = "auo,b133htn01", "simple-panel";
Drop "simple-panel" (Thierry)
> + power-supply = <&tps65090_fet6>;
> + backlight = <&backlight>;
> + };
> };
>
> &dp {
> @@ -111,22 +119,7 @@
> samsung,link-rate = <0x0a>;
> samsung,lane-count = <2>;
> samsung,hpd-gpio = <&gpx2 6 0>;
> -
> - display-timings {
> - native-mode = <&timing1>;
> -
> - timing1: timing at 1 {
> - clock-frequency = <150660000>;
> - hactive = <1920>;
> - vactive = <1080>;
> - hfront-porch = <60>;
> - hback-porch = <172>;
> - hsync-len = <80>;
> - vback-porch = <25>;
> - vfront-porch = <10>;
> - vsync-len = <10>;
> - };
> - };
> + panel = <&panel>;
> };
>
> &fimd {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
2014-08-23 10:29 ` Andreas Färber
@ 2014-08-25 6:00 ` Ajay kumar
-1 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:00 UTC (permalink / raw)
To: Andreas Färber
Cc: Ajay Kumar, linux-arm-kernel, linux-samsung-soc, devicetree,
Kukjin Kim, Doug Anderson, sunil joshi, Prashanth G,
Javier Martinez Canillas, Thierry Reding
On Sat, Aug 23, 2014 at 3:59 PM, Andreas Färber <afaerber@suse.de> wrote:
> Seeing a Reviewed-by, I'm recording comments from another thread so that
> they don't get forgotten:
I did remember these. Thanks for the reminder though!
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for panel-simple "auo,b133htn01" panel.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add panel phandle needed by dp to enable display on peach_pi.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
>> 1 file changed, 10 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index f3ee48b..5342638 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -28,11 +28,13 @@
>> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel";
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx2 2 0>;
>> + power-supply = <&tps65090_fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -98,6 +100,12 @@
>> regulator-boot-on;
>> regulator-always-on;
>> };
>> +
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>> + compatible = "auo,b133htn01", "simple-panel";
>
> Drop "simple-panel" (Thierry)
I will fix all these nits as per the other patch and resend along with
the driver patches.
Ajay
>> + power-supply = <&tps65090_fet6>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &dp {
>> @@ -111,22 +119,7 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx2 6 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing@1 {
>> - clock-frequency = <150660000>;
>> - hactive = <1920>;
>> - vactive = <1080>;
>> - hfront-porch = <60>;
>> - hback-porch = <172>;
>> - hsync-len = <80>;
>> - vback-porch = <25>;
>> - vfront-porch = <10>;
>> - vsync-len = <10>;
>> - };
>> - };
>> + panel = <&panel>;
>> };
>>
>> &fimd {
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
@ 2014-08-25 6:00 ` Ajay kumar
0 siblings, 0 replies; 24+ messages in thread
From: Ajay kumar @ 2014-08-25 6:00 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 23, 2014 at 3:59 PM, Andreas F?rber <afaerber@suse.de> wrote:
> Seeing a Reviewed-by, I'm recording comments from another thread so that
> they don't get forgotten:
I did remember these. Thanks for the reminder though!
> Am 25.07.2014 21:44, schrieb Ajay Kumar:
>> Add DT nodes for panel-simple "auo,b133htn01" panel.
>> Add backlight enable pin and backlight power supply for pwm-backlight.
>> Also add panel phandle needed by dp to enable display on peach_pi.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++++++++++-----------------
>> 1 file changed, 10 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index f3ee48b..5342638 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -28,11 +28,13 @@
>> i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel";
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&pwm 0 1000000 0>;
>> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
>> default-brightness-level = <7>;
>> + enable-gpios = <&gpx2 2 0>;
>> + power-supply = <&tps65090_fet1>;
>> pinctrl-0 = <&pwm0_out>;
>> pinctrl-names = "default";
>> };
>> @@ -98,6 +100,12 @@
>> regulator-boot-on;
>> regulator-always-on;
>> };
>> +
>> + panel: panel-simple {
>
> Just "panel"? (AF)
>> + compatible = "auo,b133htn01", "simple-panel";
>
> Drop "simple-panel" (Thierry)
I will fix all these nits as per the other patch and resend along with
the driver patches.
Ajay
>> + power-supply = <&tps65090_fet6>;
>> + backlight = <&backlight>;
>> + };
>> };
>>
>> &dp {
>> @@ -111,22 +119,7 @@
>> samsung,link-rate = <0x0a>;
>> samsung,lane-count = <2>;
>> samsung,hpd-gpio = <&gpx2 6 0>;
>> -
>> - display-timings {
>> - native-mode = <&timing1>;
>> -
>> - timing1: timing at 1 {
>> - clock-frequency = <150660000>;
>> - hactive = <1920>;
>> - vactive = <1080>;
>> - hfront-porch = <60>;
>> - hback-porch = <172>;
>> - hsync-len = <80>;
>> - vback-porch = <25>;
>> - vfront-porch = <10>;
>> - vsync-len = <10>;
>> - };
>> - };
>> + panel = <&panel>;
>> };
>>
>> &fimd {
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
^ permalink raw reply [flat|nested] 24+ messages in thread