From: Javier Martinez Canillas <javier@dowhile0.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>, Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
Date: Wed, 7 Jun 2017 14:42:43 +0200 [thread overview]
Message-ID: <CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASBztX033t36vz_MXAgeyHd76roMBtRZ4mi-q9VFB4Lkg@mail.gmail.com>
Hello Masahiro,
On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
[snip]
>>>
>>> Why didn't you touch
>>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?
>>>
>>
>> Because the compatible string "microchip,24lc128" used by the I2C
>> EEPROM node on that DTS is not supported by the
>> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for
>> 24lc128 I see is in that DTS).
>>
>> Maybe is a typo and it should be "microchip,24c128" instead ?
>
> I do not think so.
> I consulted a board developer.
>
> I also see 24LC128 on Microchip web site:
> http://www.microchip.com/wwwproducts/en/24LC128
>
Ah Ok, it was just a wild guess I did since the at24 driver didn't
have support for this chip variant.
My point stands though, this is an unrelated change to the goal of
this patch-series and should be fixed separately.
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
To: Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
Date: Wed, 7 Jun 2017 14:42:43 +0200 [thread overview]
Message-ID: <CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASBztX033t36vz_MXAgeyHd76roMBtRZ4mi-q9VFB4Lkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello Masahiro,
On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> wrote:
[snip]
>>>
>>> Why didn't you touch
>>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?
>>>
>>
>> Because the compatible string "microchip,24lc128" used by the I2C
>> EEPROM node on that DTS is not supported by the
>> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for
>> 24lc128 I see is in that DTS).
>>
>> Maybe is a typo and it should be "microchip,24c128" instead ?
>
> I do not think so.
> I consulted a board developer.
>
> I also see 24LC128 on Microchip web site:
> http://www.microchip.com/wwwproducts/en/24LC128
>
Ah Ok, it was just a wild guess I did since the at24 driver didn't
have support for this chip variant.
My point stands though, this is an unrelated change to the goal of
this patch-series and should be fixed separately.
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: javier@dowhile0.org (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
Date: Wed, 7 Jun 2017 14:42:43 +0200 [thread overview]
Message-ID: <CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNASBztX033t36vz_MXAgeyHd76roMBtRZ4mi-q9VFB4Lkg@mail.gmail.com>
Hello Masahiro,
On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
[snip]
>>>
>>> Why didn't you touch
>>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?
>>>
>>
>> Because the compatible string "microchip,24lc128" used by the I2C
>> EEPROM node on that DTS is not supported by the
>> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for
>> 24lc128 I see is in that DTS).
>>
>> Maybe is a typo and it should be "microchip,24c128" instead ?
>
> I do not think so.
> I consulted a board developer.
>
> I also see 24LC128 on Microchip web site:
> http://www.microchip.com/wwwproducts/en/24LC128
>
Ah Ok, it was just a wild guess I did since the at24 driver didn't
have support for this chip variant.
My point stands though, this is an unrelated change to the goal of
this patch-series and should be fixed separately.
Best regards,
Javier
next prev parent reply other threads:[~2017-06-07 12:42 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 13:34 [PATCH v5 00/20] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 01/20] dt-bindings: i2c: eeprom: Document vendor to be used and deprecated ones Javier Martinez Canillas
2017-05-23 15:30 ` Rob Herring
2017-05-23 13:34 ` [PATCH v5 02/20] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 03/20] ARM: dts: omap: Add generic compatible string for I2C EEPROM Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-26 15:51 ` Tony Lindgren
2017-05-26 15:51 ` Tony Lindgren
2017-05-26 15:51 ` Tony Lindgren
2017-05-23 13:34 ` [PATCH v5 04/20] ARM: dts: turris-omnia: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-06-08 17:04 ` Gregory CLEMENT
2017-06-08 17:04 ` Gregory CLEMENT
2017-06-08 17:04 ` Gregory CLEMENT
2017-05-23 13:34 ` [PATCH v5 05/20] ARM: dts: efm32: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-25 18:29 ` Uwe Kleine-König
2017-05-25 18:29 ` Uwe Kleine-König
2017-05-25 18:29 ` Uwe Kleine-König
2017-05-25 20:17 ` Javier Martinez Canillas
2017-05-25 20:17 ` Javier Martinez Canillas
2017-05-25 20:17 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 06/20] ARM: dts: imx: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-25 7:32 ` Shawn Guo
2017-05-25 7:32 ` Shawn Guo
2017-05-25 7:32 ` Shawn Guo
2017-05-23 13:34 ` [PATCH v5 07/20] ARM: dts: keystone: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 08/20] ARM: dts: lpc18xx: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 09/20] ARM: dts: r7s72100: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 10/20] ARM: dts: koelsch: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 11/20] ARM: dts: socfpga: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 12/20] ARM: dts: uniphier: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-06-05 5:13 ` Masahiro Yamada
2017-06-05 5:13 ` Masahiro Yamada
2017-06-05 5:13 ` Masahiro Yamada
2017-06-06 9:04 ` Javier Martinez Canillas
2017-06-06 9:04 ` Javier Martinez Canillas
2017-06-06 9:04 ` Javier Martinez Canillas
2017-06-07 1:10 ` Masahiro Yamada
2017-06-07 1:10 ` Masahiro Yamada
2017-06-07 1:10 ` Masahiro Yamada
2017-06-07 12:42 ` Javier Martinez Canillas [this message]
2017-06-07 12:42 ` Javier Martinez Canillas
2017-06-07 12:42 ` Javier Martinez Canillas
2017-06-09 16:12 ` Masahiro Yamada
2017-06-09 16:12 ` Masahiro Yamada
2017-06-09 16:12 ` Masahiro Yamada
2017-05-23 13:34 ` [PATCH v5 13/20] ARM: dts: zynq: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 14/20] arm64: dts: ls1043a: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-25 7:33 ` Shawn Guo
2017-05-25 7:33 ` Shawn Guo
2017-05-25 7:33 ` Shawn Guo
2017-05-23 13:34 ` [PATCH v5 15/20] arm64: zynqmp: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 16/20] powerpc/5200: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 17/20] powerpc/fsl: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 18/20] powerpc/512x: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 19/20] powerpc/83xx: " Javier Martinez Canillas
2017-05-23 13:34 ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 20/20] powerpc/44x: " Javier Martinez Canillas
2017-06-01 8:07 ` [PATCH v5 00/20] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-06-01 8:07 ` Javier Martinez Canillas
2017-06-01 8:07 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.