[U-Boot] [BUG] test_avb_persistent_values() fails

[U-Boot] [BUG] test_avb_persistent_values() fails

[Heinrich Schuchardt]

Hello Igor,

when I run `make tests` with current origin/master
commit a69120a0d7c8d4044cdaceea9eb03913ba4e49c7
I get an error. I think your submitted this test recently:
commit fc1fe01b08ce ("avb: add support for named persistent values")

u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
0x7ff056222cd0>

     @pytest.mark.buildconfigspec('cmd_avb')
     @pytest.mark.buildconfigspec('optee_ta_avb')
     def test_avb_persistent_values(u_boot_console):
         """Test reading/writing persistent storage to avb
         """

         response = u_boot_console.run_command('avb init %s' % str(mmc_dev))
         assert response == ''

         response = u_boot_console.run_command('avb write_pvalue test
value_value')
         assert response == 'Wrote 12 bytes'

         response = u_boot_console.run_command('avb read_pvalue test 12')
 >       assert response == 'Read 12 bytes, value = value_value'
E       AssertionError: assert 'Read 12 byte...alue_value/XU' == 'Read
12 bytes...= value_value'
E         - Read 12 bytes, value = value_value/XU
E         ?                                   ---
E         + Read 12 bytes, value = value_value

test/py/tests/test_avb.py:134: AssertionError

Best regards

Heinrich

[U-Boot] [BUG] test_avb_persistent_values() fails

[Igor Opaniuk]

On Tue, Apr 30, 2019, 23:14 Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> Hello Igor,
>
> when I run `make tests` with current origin/master
> commit a69120a0d7c8d4044cdaceea9eb03913ba4e49c7
> I get an error. I think your submitted this test recently:
> commit fc1fe01b08ce ("avb: add support for named persistent values")
>
> u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
> 0x7ff056222cd0>
>
>      @pytest.mark.buildconfigspec('cmd_avb')
>      @pytest.mark.buildconfigspec('optee_ta_avb')
>      def test_avb_persistent_values(u_boot_console):
>          """Test reading/writing persistent storage to avb
>          """
>
>          response = u_boot_console.run_command('avb init %s' %
> str(mmc_dev))
>          assert response == ''
>
>          response = u_boot_console.run_command('avb write_pvalue test
> value_value')
>          assert response == 'Wrote 12 bytes'
>
>          response = u_boot_console.run_command('avb read_pvalue test 12')
>  >       assert response == 'Read 12 bytes, value = value_value'
> E       AssertionError: assert 'Read 12 byte...alue_value/XU' == 'Read
> 12 bytes...= value_value'
> E         - Read 12 bytes, value = value_value/XU
> E         ?                                   ---
> E         + Read 12 bytes, value = value_value
>
> test/py/tests/test_avb.py:134: AssertionError
>
> Best regards
>
> Heinrich
>

Hi Heinrich,

Thanks for reporting this. Interesting, that when I sent v5 everything was
ok (where I addressed an issue reported by Tom, actually I played a lot
with `make tests` and all tests were passing successfully) and the only
thing I did in v6 - adding R-b tag(v5 was posted ~3 month ago, so I assume
something probably was changed in py/tests).

Unfortunately I am AFK till Sunday, will look into this ASAP(Monday
morning).

Regards,
Igor

[U-Boot] [BUG] test_avb_persistent_values() fails

[Igor Opaniuk]

On Tue, Apr 30, 2019 at 11:14 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Hello Igor,
>
> when I run `make tests` with current origin/master
> commit a69120a0d7c8d4044cdaceea9eb03913ba4e49c7
> I get an error. I think your submitted this test recently:
> commit fc1fe01b08ce ("avb: add support for named persistent values")
>
> u_boot_console = <u_boot_console_sandbox.ConsoleSandbox object at
> 0x7ff056222cd0>
>
>      @pytest.mark.buildconfigspec('cmd_avb')
>      @pytest.mark.buildconfigspec('optee_ta_avb')
>      def test_avb_persistent_values(u_boot_console):
>          """Test reading/writing persistent storage to avb
>          """
>
>          response = u_boot_console.run_command('avb init %s' % str(mmc_dev))
>          assert response == ''
>
>          response = u_boot_console.run_command('avb write_pvalue test
> value_value')
>          assert response == 'Wrote 12 bytes'
>
>          response = u_boot_console.run_command('avb read_pvalue test 12')
>  >       assert response == 'Read 12 bytes, value = value_value'
> E       AssertionError: assert 'Read 12 byte...alue_value/XU' == 'Read
> 12 bytes...= value_value'
> E         - Read 12 bytes, value = value_value/XU
> E         ?                                   ---
> E         + Read 12 bytes, value = value_value
>
> test/py/tests/test_avb.py:134: AssertionError
>
> Best regards
>
> Heinrich

Hi Heinrich,

Just posted the fix [1].

[1]: https://patchwork.ozlabs.org/patch/1095734/

Thanks


-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk