From: Ashijeet Acharya <ashijeetacharya@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Richard W.M. Jones" <rjones@redhat.com>,
jcody@redhat.com, Eric Blake <eblake@redhat.com>,
mreitz@redhat.com, armbru@redhat.com,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH
Date: Wed, 12 Oct 2016 14:07:10 +0530 [thread overview]
Message-ID: <CAC2QTZaE2XRGTqYxvuDHEfg5ro0BZsSnHfR=puj0tPnDaVVu7g@mail.gmail.com> (raw)
In-Reply-To: <20161012082254.GA5544@noname.redhat.com>
On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben:
> Of course, we must be able to build qemu correctly both with ssh enabled
> and disabled, so if you can indeed see a (different) build error with
> disabled libssh2, that needs to be fixed.
I am able to reproduce it when I don't apply Dan's patch with libssh2 enabled.
After disabling libssh2, it compiles perfectly because then the SSH
driver will get ignored I guess.
libssh2 doesn't seem to be the problem.
>
> But I can't see how that would happen, you don't touch configure and it
> already compiled the ssh driver out if libssh2 is disabled.
Yes, with libssh2 disabled it builds with no error just like the first
output of auto-build shows.
So, I think with libssh2 enabled it throws an error (just like second
output of auto-build) since Dan's patches are not merged yet. Right?
Ashijeet
> Kevin
next prev parent reply other threads:[~2016-10-12 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 7:37 [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH Ashijeet Acharya
2016-10-11 7:37 ` [Qemu-devel] [PATCH 1/4] block/ssh: Add ssh_has_filename_options_conflict() Ashijeet Acharya
2016-10-11 7:37 ` [Qemu-devel] [PATCH 2/4] block/ssh: Add InetSocketAddress and accept it Ashijeet Acharya
2016-10-12 15:51 ` Kevin Wolf
2016-10-12 16:49 ` Ashijeet Acharya
2016-10-13 18:34 ` Ashijeet Acharya
2016-10-11 7:37 ` [Qemu-devel] [PATCH 3/4] block/ssh: Use InetSocketAddress options Ashijeet Acharya
2016-10-11 7:37 ` [Qemu-devel] [PATCH 4/4] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-11 20:28 ` [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH no-reply
2016-10-12 8:09 ` Ashijeet Acharya
2016-10-12 8:22 ` Kevin Wolf
2016-10-12 8:37 ` Ashijeet Acharya [this message]
2016-10-12 8:43 ` Kevin Wolf
2016-10-12 8:43 ` Ashijeet Acharya
2016-10-12 16:01 ` Kevin Wolf
2016-10-12 16:20 ` Ashijeet Acharya
2016-10-12 16:40 ` Kevin Wolf
2016-10-12 16:57 ` Ashijeet Acharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC2QTZaE2XRGTqYxvuDHEfg5ro0BZsSnHfR=puj0tPnDaVVu7g@mail.gmail.com' \
--to=ashijeetacharya@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.