All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"Kishon Vijay Abraham I" <kishon-l0cyMroinI0@public.gmane.org>,
	"Florian Fainelli"
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Ray Jui" <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"Scott Branden"
	<sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"Jon Mason" <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"BCM Kernel Feedback"
	<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"Yendapally Reddy Dhananjaya Reddy"
	<yendapally.reddy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
Subject: Re: [PATCH for-4.11 2/2] Revert "dt-bindings: phy: Add documentation for NSP USB3 PHY"
Date: Thu, 9 Feb 2017 19:30:06 -0500	[thread overview]
Message-ID: <CAC3K-4oju7mEAhaTM3VaF_NGt1agsuN8Reb6XzxM5qo54Eo0dA@mail.gmail.com> (raw)
In-Reply-To: <20170208233023.31922-2-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Wed, Feb 8, 2017 at 6:30 PM, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
>
> This reverts commit c8ca631f9480 ("dt-bindings: phy: Add documentation
> for NSP USB3 PHY") to match reverting commit adding the new PHY driver.
> Please note we revert this commit before it reached stable release.
>
> If new compatible string is needed it should be added to the existing
> bcm-ns-usb3-phy.txt which already describes this PHY.
>
> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>

(previous email got caught in HTML filters)

Per the discussion with Rafal, this is acceptable

Acked-by: Jon Mason <jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

> ---
>  .../devicetree/bindings/phy/brcm,nsp-usb3-phy.txt  | 39 ----------------------
>  1 file changed, 39 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt b/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
> deleted file mode 100644
> index e68ae5dec9c9..000000000000
> --- a/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -Broadcom USB3 phy binding for northstar plus SoC
> -The USB3 phy is internal to the SoC and is accessed using mdio interface.
> -
> -Required mdio bus properties:
> -- reg: Should be 0x0 for SoC internal USB3 phy
> -- #address-cells: must be 1
> -- #size-cells: must be 0
> -
> -Required USB3 PHY properties:
> -- compatible: should be "brcm,nsp-usb3-phy"
> -- reg: USB3 Phy address on SoC internal MDIO bus and it should be 0x10.
> -- usb3-ctrl-syscon: handler of syscon node defining physical address
> -  of usb3 control register.
> -- #phy-cells: must be 0
> -
> -Required usb3 control properties:
> -- compatible: should be "brcm,nsp-usb3-ctrl"
> -- reg: offset and length of the control registers
> -
> -Example:
> -
> -       mdio@0 {
> -               reg = <0x0>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> -
> -               usb3_phy: usb-phy@10 {
> -                       compatible = "brcm,nsp-usb3-phy";
> -                       reg = <0x10>;
> -                       usb3-ctrl-syscon = <&usb3_ctrl>;
> -                       #phy-cells = <0>;
> -                       status = "disabled";
> -               };
> -       };
> -
> -       usb3_ctrl: syscon@104408 {
> -               compatible = "brcm,nsp-usb3-ctrl", "syscon";
> -               reg = <0x104408 0x3fc>;
> -       };
> --
> 2.11.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jon.mason@broadcom.com (Jon Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH for-4.11 2/2] Revert "dt-bindings: phy: Add documentation for NSP USB3 PHY"
Date: Thu, 9 Feb 2017 19:30:06 -0500	[thread overview]
Message-ID: <CAC3K-4oju7mEAhaTM3VaF_NGt1agsuN8Reb6XzxM5qo54Eo0dA@mail.gmail.com> (raw)
In-Reply-To: <20170208233023.31922-2-zajec5@gmail.com>

On Wed, Feb 8, 2017 at 6:30 PM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> From: Rafa? Mi?ecki <rafal@milecki.pl>
>
> This reverts commit c8ca631f9480 ("dt-bindings: phy: Add documentation
> for NSP USB3 PHY") to match reverting commit adding the new PHY driver.
> Please note we revert this commit before it reached stable release.
>
> If new compatible string is needed it should be added to the existing
> bcm-ns-usb3-phy.txt which already describes this PHY.
>
> Signed-off-by: Rafa? Mi?ecki <rafal@milecki.pl>

(previous email got caught in HTML filters)

Per the discussion with Rafal, this is acceptable

Acked-by: Jon Mason <jon.mason@broadcom.com>

> ---
>  .../devicetree/bindings/phy/brcm,nsp-usb3-phy.txt  | 39 ----------------------
>  1 file changed, 39 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt b/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
> deleted file mode 100644
> index e68ae5dec9c9..000000000000
> --- a/Documentation/devicetree/bindings/phy/brcm,nsp-usb3-phy.txt
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -Broadcom USB3 phy binding for northstar plus SoC
> -The USB3 phy is internal to the SoC and is accessed using mdio interface.
> -
> -Required mdio bus properties:
> -- reg: Should be 0x0 for SoC internal USB3 phy
> -- #address-cells: must be 1
> -- #size-cells: must be 0
> -
> -Required USB3 PHY properties:
> -- compatible: should be "brcm,nsp-usb3-phy"
> -- reg: USB3 Phy address on SoC internal MDIO bus and it should be 0x10.
> -- usb3-ctrl-syscon: handler of syscon node defining physical address
> -  of usb3 control register.
> -- #phy-cells: must be 0
> -
> -Required usb3 control properties:
> -- compatible: should be "brcm,nsp-usb3-ctrl"
> -- reg: offset and length of the control registers
> -
> -Example:
> -
> -       mdio at 0 {
> -               reg = <0x0>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> -
> -               usb3_phy: usb-phy at 10 {
> -                       compatible = "brcm,nsp-usb3-phy";
> -                       reg = <0x10>;
> -                       usb3-ctrl-syscon = <&usb3_ctrl>;
> -                       #phy-cells = <0>;
> -                       status = "disabled";
> -               };
> -       };
> -
> -       usb3_ctrl: syscon at 104408 {
> -               compatible = "brcm,nsp-usb3-ctrl", "syscon";
> -               reg = <0x104408 0x3fc>;
> -       };
> --
> 2.11.0
>

  parent reply	other threads:[~2017-02-10  0:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 23:30 [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" Rafał Miłecki
2017-02-08 23:30 ` Rafał Miłecki
     [not found] ` <20170208233023.31922-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-08 23:30   ` [PATCH for-4.11 2/2] Revert "dt-bindings: phy: Add documentation for NSP USB3 PHY" Rafał Miłecki
2017-02-08 23:30     ` Rafał Miłecki
2017-02-10  0:27     ` Jon Mason
     [not found]     ` <20170208233023.31922-2-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-10  0:30       ` Jon Mason [this message]
2017-02-10  0:30         ` Jon Mason
2017-02-15 23:04       ` Rob Herring
2017-02-15 23:04         ` Rob Herring
2017-02-08 23:32 ` [PATCH for-4.11 1/2] Revert "phy: Add USB3 PHY support for Broadcom NSP SoC" Florian Fainelli
2017-02-08 23:32   ` Florian Fainelli
     [not found]   ` <82b47a03-c41b-378b-2d7c-f263eff514a9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-08 23:36     ` Jon Mason
2017-02-08 23:36       ` Jon Mason
2017-02-08 23:39   ` Rafał Miłecki
2017-02-08 23:39     ` Rafał Miłecki
2017-02-08 23:44     ` Florian Fainelli
2017-02-08 23:44       ` Florian Fainelli
2017-02-09  7:21       ` Rafał Miłecki
2017-02-09  7:21         ` Rafał Miłecki
2017-02-09 19:18         ` Florian Fainelli
2017-02-09 19:18           ` Florian Fainelli
2017-02-10  0:27           ` Jon Mason
     [not found]             ` <CAC3K-4o+ARP=_hg2XQszQh6v+ySpubyKRspCF38SLUUx4mXQDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-08 12:13               ` Rafał Miłecki
2017-03-08 12:13                 ` Rafał Miłecki
2017-03-08 12:26                 ` Kishon Vijay Abraham I
2017-03-08 12:26                   ` Kishon Vijay Abraham I
     [not found]                   ` <58BFF88F.8080008-l0cyMroinI0@public.gmane.org>
2017-03-09  8:11                     ` Kishon Vijay Abraham I
2017-03-09  8:11                       ` Kishon Vijay Abraham I
2017-03-09  9:17                       ` Rafał Miłecki
2017-03-09  9:17                         ` Rafał Miłecki
     [not found]           ` <b2bdc1a7-4e5c-a13e-0cda-c90759d7308c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-10  0:29             ` Jon Mason
2017-02-10  0:29               ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC3K-4oju7mEAhaTM3VaF_NGt1agsuN8Reb6XzxM5qo54Eo0dA@mail.gmail.com \
    --to=jon.mason-dy08kvg/lbpwk0htik3j/w@public.gmane.org \
    --cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org \
    --cc=rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=yendapally.reddy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.