From: Jon Mason <jon.mason@broadcom.com> To: "Rafał Miłecki" <zajec5@gmail.com> Cc: "Mathias Nyman" <mathias.nyman@linux.intel.com>, "Florian Fainelli" <f.fainelli@gmail.com>, "BCM Kernel Feedback" <bcm-kernel-feedback-list@broadcom.com>, "Mathias Nyman" <mathias.nyman@intel.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Hauke Mehrtens" <hauke@hauke-m.de>, "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Rafał Miłecki" <rafal@milecki.pl> Subject: Re: [PATCH V2] usb: xhci: add support for performing fake doorbell Date: Wed, 8 Feb 2017 17:39:52 -0500 [thread overview] Message-ID: <CAC3K-4p=KRQySpO-qKZS75-RzR1AnfqWHqsO9RjBR6X0+Xy+SQ@mail.gmail.com> (raw) In-Reply-To: <CACna6ryJ7fod1KUOa9BVuQQWpCKg0_ArtMzHq_P5xYfW9Namxw@mail.gmail.com> On Mon, Jan 16, 2017 at 2:32 AM, Rafał Miłecki <zajec5@gmail.com> wrote: > On 21 November 2016 at 16:31, Mathias Nyman > <mathias.nyman@linux.intel.com> wrote: >> On 21.11.2016 09:57, Rafał Miłecki wrote: >>> >>> Hi Mathias, >>> >>> On 17 October 2016 at 22:30, Rafał Miłecki <zajec5@gmail.com> wrote: >>>> >>>> From: Rafał Miłecki <rafal@milecki.pl> >>>> >>>> Broadcom's Northstar XHCI controllers seem to need a special start >>>> procedure to work correctly. There isn't any official documentation of >>>> this, the problem is that controller doesn't detect any connected >>>> devices with default setup. Moreover connecting USB device to controller >>>> that doesn't run properly can cause SoC's watchdog issues. >>>> >>>> A workaround that was successfully tested on multiple devices is to >>>> perform a fake doorbell. This patch adds code for doing this and enables >>>> it on BCM4708 family. >>>> >>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >>>> --- >>>> V2: Enable quirk for brcm,bcm4708 machines instead of adding separated >>>> binding >>>> for it. Thanks Rob for your comment on this. >>> >>> >>> Do you think you can pick & push this one? V2 follows Rob's suggestion >>> and he has some DT knowledge for sure, so I guess it should be OK. >>> -- >> >> >> Is there some more background information on this? >> >> I don't have any contacts to Broadcom myself, adding the BMC Kernel Feedback >> list to CC. >> Maybe someone over there has an errata, documentation or just general >> feedback. >> >> How was this workaround even figured out? ringing the doorbell for the first >> device doesn't seem like something found by trial and error, especially >> when >> xhci specs state that: >> >> "Software shall not write the Doorbell of an endpoint until after it has >> issued a >> Configure Endpoint Command for the endpoint and received a successful >> Command >> Completion Event." >> >> The whole workaround is a bit intrusive, allocating a fake device, ring a >> doorbell for a >> fake device in the wrong state, clearing off HSE (host system error) which >> should only be set >> when things really go bad, some random usleeps, and possible calling >> xhci_start() twice. >> >> I can't take this as is without some more info. > > Hi (ping) Broadcom guys, could you help us with this USB workaround, please? Investigating internally. I'll let you know if I can find anything. Thanks, Jon > > -- > Rafał
WARNING: multiple messages have this Message-ID (diff)
From: Jon Mason <jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: "Mathias Nyman" <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "Florian Fainelli" <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "BCM Kernel Feedback" <bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>, "Mathias Nyman" <mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Greg Kroah-Hartman" <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, "Hauke Mehrtens" <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>, "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Linux Kernel Mailing List" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> Subject: Re: [PATCH V2] usb: xhci: add support for performing fake doorbell Date: Wed, 8 Feb 2017 17:39:52 -0500 [thread overview] Message-ID: <CAC3K-4p=KRQySpO-qKZS75-RzR1AnfqWHqsO9RjBR6X0+Xy+SQ@mail.gmail.com> (raw) In-Reply-To: <CACna6ryJ7fod1KUOa9BVuQQWpCKg0_ArtMzHq_P5xYfW9Namxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Mon, Jan 16, 2017 at 2:32 AM, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On 21 November 2016 at 16:31, Mathias Nyman > <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote: >> On 21.11.2016 09:57, Rafał Miłecki wrote: >>> >>> Hi Mathias, >>> >>> On 17 October 2016 at 22:30, Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >>>> >>>> From: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> >>>> >>>> Broadcom's Northstar XHCI controllers seem to need a special start >>>> procedure to work correctly. There isn't any official documentation of >>>> this, the problem is that controller doesn't detect any connected >>>> devices with default setup. Moreover connecting USB device to controller >>>> that doesn't run properly can cause SoC's watchdog issues. >>>> >>>> A workaround that was successfully tested on multiple devices is to >>>> perform a fake doorbell. This patch adds code for doing this and enables >>>> it on BCM4708 family. >>>> >>>> Signed-off-by: Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org> >>>> --- >>>> V2: Enable quirk for brcm,bcm4708 machines instead of adding separated >>>> binding >>>> for it. Thanks Rob for your comment on this. >>> >>> >>> Do you think you can pick & push this one? V2 follows Rob's suggestion >>> and he has some DT knowledge for sure, so I guess it should be OK. >>> -- >> >> >> Is there some more background information on this? >> >> I don't have any contacts to Broadcom myself, adding the BMC Kernel Feedback >> list to CC. >> Maybe someone over there has an errata, documentation or just general >> feedback. >> >> How was this workaround even figured out? ringing the doorbell for the first >> device doesn't seem like something found by trial and error, especially >> when >> xhci specs state that: >> >> "Software shall not write the Doorbell of an endpoint until after it has >> issued a >> Configure Endpoint Command for the endpoint and received a successful >> Command >> Completion Event." >> >> The whole workaround is a bit intrusive, allocating a fake device, ring a >> doorbell for a >> fake device in the wrong state, clearing off HSE (host system error) which >> should only be set >> when things really go bad, some random usleeps, and possible calling >> xhci_start() twice. >> >> I can't take this as is without some more info. > > Hi (ping) Broadcom guys, could you help us with this USB workaround, please? Investigating internally. I'll let you know if I can find anything. Thanks, Jon > > -- > Rafał -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-08 22:40 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-01 21:58 [PATCH] usb: xhci: add support for performing fake doorbell Rafał Miłecki 2016-10-01 21:58 ` Rafał Miłecki 2016-10-08 22:32 ` Rob Herring 2016-10-09 1:28 ` Rob Herring 2016-10-09 1:28 ` Rob Herring 2016-10-17 20:30 ` [PATCH V2] " Rafał Miłecki 2016-10-17 20:30 ` Rafał Miłecki 2016-10-17 21:10 ` Hauke Mehrtens 2016-10-17 21:21 ` Rafał Miłecki 2016-10-17 21:21 ` Rafał Miłecki 2016-11-21 7:57 ` Rafał Miłecki 2016-11-21 15:31 ` Mathias Nyman 2017-01-16 7:32 ` Rafał Miłecki 2017-02-08 22:39 ` Jon Mason [this message] 2017-02-08 22:39 ` Jon Mason
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC3K-4p=KRQySpO-qKZS75-RzR1AnfqWHqsO9RjBR6X0+Xy+SQ@mail.gmail.com' \ --to=jon.mason@broadcom.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hauke@hauke-m.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathias.nyman@intel.com \ --cc=mathias.nyman@linux.intel.com \ --cc=rafal@milecki.pl \ --cc=robh+dt@kernel.org \ --cc=zajec5@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.