From: Jon Mason <jon.mason@broadcom.com>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: David Miller <davem@davemloft.net>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Network Development <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family
Date: Fri, 3 Feb 2017 17:35:50 -0500 [thread overview]
Message-ID: <CAC3K-4rHRuSaDf_ks5kZB0cQiW-suXy=M+uE0ORRPV2LT2AqKQ@mail.gmail.com> (raw)
In-Reply-To: <cdd5a5472af15d6da11e80306424d8b9@milecki.pl>
On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki <rafal@milecki.pl> wrote:
> On 2017-02-03 22:39, Jon Mason wrote:
>>
>> BCM471X and BCM535X are of the same family (from what I can derive from
>> internal documents). Group them into the case statement together, which
>> results in more code reuse.
>>
>> Also, use existing helper variables to make the code a little more
>> readable too.
>>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>
>
> I'd like to review it / test it on few devices. Please give me weekend for
> that.
Yes, please test this as much as you can. The code move was pretty
innocuous, and those are always the times when it comes back to bite
me.
Thanks,
Jon
next prev parent reply other threads:[~2017-02-03 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 21:39 [PATCH net-next 0/3] net: ethernet: bgmac: PM support and clean-ups Jon Mason
2017-02-03 21:39 ` [PATCH 1/3] net: ethernet: bgmac: use #defines for MAX size Jon Mason
2017-02-03 21:39 ` [PATCH 2/3] net: ethernet: bgmac: unify code of the same family Jon Mason
2017-02-03 21:48 ` Rafał Miłecki
2017-02-03 22:35 ` Jon Mason [this message]
2017-02-03 21:39 ` [PATCH 3/3] net: ethernet: bgmac: driver power manangement Jon Mason
2017-02-04 2:16 ` Florian Fainelli
2017-02-06 16:30 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC3K-4rHRuSaDf_ks5kZB0cQiW-suXy=M+uE0ORRPV2LT2AqKQ@mail.gmail.com' \
--to=jon.mason@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.