All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH v2] fault-inject: support systematic fault injection
Date: Wed, 29 Mar 2017 08:41:06 +0900	[thread overview]
Message-ID: <CAC5umyhYbez6bpM0QnS3icuRCq2g-=0Yf-pj4+kxedmrp6hnwA@mail.gmail.com> (raw)
In-Reply-To: <20170328130128.101773-1-dvyukov@google.com>

2017-03-28 22:01 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
> Add /proc/self/task/<current-tid>/fail-nth file that allows failing
> 0-th, 1-st, 2-nd and so on calls systematically.
> Excerpt from the added documentation:
>
> ===
> Write to this file of integer N makes N-th call in the current task fail
> (N is 0-based). Read from this file returns a single char 'Y' or 'N'
> that says if the fault setup with a previous write to this file was
> injected or not, and disables the fault if it wasn't yet injected.
> Note that this file enables all types of faults (slab, futex, etc).
> This setting takes precedence over all other generic settings like
> probability, interval, times, etc. But per-capability settings
> (e.g. fail_futex/ignore-private) take precedence over it.
> This feature is intended for systematic testing of faults in a single
> system call. See an example below.
> ===

This asymmetric read/write interface looks a bit odd. (write a string
representation of integer, but read Y or N).

How about just return the string representation of task->fail_nth for
read and let the user space tools check if it is zero or not?

WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH v2] fault-inject: support systematic fault injection
Date: Wed, 29 Mar 2017 08:41:06 +0900	[thread overview]
Message-ID: <CAC5umyhYbez6bpM0QnS3icuRCq2g-=0Yf-pj4+kxedmrp6hnwA@mail.gmail.com> (raw)
In-Reply-To: <20170328130128.101773-1-dvyukov@google.com>

2017-03-28 22:01 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
> Add /proc/self/task/<current-tid>/fail-nth file that allows failing
> 0-th, 1-st, 2-nd and so on calls systematically.
> Excerpt from the added documentation:
>
> ===
> Write to this file of integer N makes N-th call in the current task fail
> (N is 0-based). Read from this file returns a single char 'Y' or 'N'
> that says if the fault setup with a previous write to this file was
> injected or not, and disables the fault if it wasn't yet injected.
> Note that this file enables all types of faults (slab, futex, etc).
> This setting takes precedence over all other generic settings like
> probability, interval, times, etc. But per-capability settings
> (e.g. fail_futex/ignore-private) take precedence over it.
> This feature is intended for systematic testing of faults in a single
> system call. See an example below.
> ===

This asymmetric read/write interface looks a bit odd. (write a string
representation of integer, but read Y or N).

How about just return the string representation of task->fail_nth for
read and let the user space tools check if it is zero or not?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-03-28 23:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 13:01 [PATCH v2] fault-inject: support systematic fault injection Dmitry Vyukov
2017-03-28 13:01 ` Dmitry Vyukov
2017-03-28 21:40 ` Andrew Morton
2017-03-28 21:40   ` Andrew Morton
2017-03-28 23:41 ` Akinobu Mita [this message]
2017-03-28 23:41   ` Akinobu Mita
2017-03-30 23:04 ` Andrew Morton
2017-03-30 23:04   ` Andrew Morton
2017-04-04 14:57 ` Akinobu Mita
2017-04-04 14:57   ` Akinobu Mita
2017-04-06 18:33 ` Michal Hocko
2017-04-06 18:33   ` Michal Hocko
2017-04-06 18:33   ` Michal Hocko
2017-04-07 16:47   ` Akinobu Mita
2017-04-07 16:47     ` Akinobu Mita
2017-04-08 17:40     ` Dmitry Vyukov
2017-04-08 17:40       ` Dmitry Vyukov
2017-04-09 10:39       ` Akinobu Mita
2017-04-09 10:39         ` Akinobu Mita
2017-04-09 10:39         ` Akinobu Mita
2017-05-24 10:22         ` Dmitry Vyukov
2017-05-24 10:22           ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC5umyhYbez6bpM0QnS3icuRCq2g-=0Yf-pj4+kxedmrp6hnwA@mail.gmail.com' \
    --to=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.