All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v14 6/9] added support for DesignWare Controller
Date: Wed, 13 Apr 2016 21:19:19 +0900	[thread overview]
Message-ID: <CAC5umyiSCeBMMwdxo2SqteVNjOtTPqO6g-KQ-Ebta_QFR0pX2A@mail.gmail.com> (raw)
In-Reply-To: <75cb43b16231f67d1e94e174a45ad6ffc68e1df6.1459448160.git.jpinto@synopsys.com>

Hi Joao,

2016-04-13 18:04 GMT+09:00 Joao Pinto <Joao.Pinto@synopsys.com>:

> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index e3931d0..c780d14 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -263,6 +263,7 @@ struct ufs_pwr_mode_info {
>   * @suspend: called during host controller PM callback
>   * @resume: called during host controller PM callback
>   * @dbg_register_dump: used to dump controller debug information
> + * @phy_initialization: used to initialize phys
>   */
>  struct ufs_hba_variant_ops {
>         const char *name;
> @@ -284,6 +285,7 @@ struct ufs_hba_variant_ops {
>         int     (*suspend)(struct ufs_hba *, enum ufs_pm_op);
>         int     (*resume)(struct ufs_hba *, enum ufs_pm_op);
>         void    (*dbg_register_dump)(struct ufs_hba *hba);
> +       int     (*phy_initialization)(struct ufs_hba *);
>  };

This vops->phy_initialization is only called from ufs dwc specific
source files and not called from ufs core.  So this should not belong
to ufs_hba_variant_ops.

You can use hba->priv to put the controller specific data structure
including phy_initialization and you also need to define vops->init
callback which allocates and initialize the data structure.

  reply	other threads:[~2016-04-13 12:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 18:57 [PATCH v12 0/9] add support for DWC UFS Controller Joao Pinto
2016-03-31 18:57 ` [PATCH v12 1/9] fixed typo in ufshcd-pltfrm Joao Pinto
2016-03-31 18:57 ` [PATCH v12 2/9] add UFS 2.0 to ufshcd-pltfrm bindings Joao Pinto
2016-04-04  5:15   ` Rob Herring
2016-03-31 18:57 ` [PATCH v12 3/9] added UFS 2.0 capabilities Joao Pinto
2016-03-31 20:27   ` Winkler, Tomas
2016-04-01  9:19     ` Joao Pinto
2016-03-31 18:57 ` [PATCH v12 4/9] added unipro attributes Joao Pinto
2016-03-31 18:57 ` [PATCH v12 5/9] added link status to ufshci Joao Pinto
2016-03-31 18:57   ` Joao Pinto
2016-03-31 18:57 ` [PATCH v12 6/9] added support for DesignWare Controller Joao Pinto
2016-04-13 12:19   ` Akinobu Mita [this message]
2016-04-13 12:57     ` [PATCH v14 " Joao Pinto
2016-04-13 13:30       ` Akinobu Mita
2016-03-31 18:57 ` [PATCH v12 7/9] added support for Synopsys G210 Test Chip Joao Pinto
2016-03-31 18:57 ` [PATCH v12 8/9] add TC G210 platform driver Joao Pinto
2016-04-04  5:15   ` Rob Herring
2016-04-04 10:48     ` Joao Pinto
2016-04-04 10:48       ` Joao Pinto
2016-04-07 17:57       ` Rob Herring
2016-04-08  9:13         ` Joao Pinto
2016-04-08  9:13           ` Joao Pinto
2016-03-31 18:57 ` [PATCH v12 9/9] add TC G210 pci driver Joao Pinto
2016-04-04 23:34 ` [PATCH v13 0/9] add support for DWC UFS Controller Martin K. Petersen
2016-04-05  9:09   ` Joao Pinto
2016-04-05  9:09     ` Joao Pinto
2016-04-05 10:15     ` Winkler, Tomas
2016-04-05 10:27       ` Joao Pinto
2016-04-05 10:27         ` Joao Pinto
2016-04-15 14:09 ` [PATCH v14 " Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC5umyiSCeBMMwdxo2SqteVNjOtTPqO6g-KQ-Ebta_QFR0pX2A@mail.gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.